From 5bdfc41f94a75f9904b3173a8e44ab6bb19f7526 Mon Sep 17 00:00:00 2001 From: wandji Date: Mon, 5 Feb 2024 10:18:56 +0100 Subject: [PATCH] Improve logic for unsharing shared task [SCI-10097] (#7026) --- .../components/shareable_link_modal.vue | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/app/javascript/vue/shareable_links/components/shareable_link_modal.vue b/app/javascript/vue/shareable_links/components/shareable_link_modal.vue index 278eeb38c..40bc6b7dd 100644 --- a/app/javascript/vue/shareable_links/components/shareable_link_modal.vue +++ b/app/javascript/vue/shareable_links/components/shareable_link_modal.vue @@ -34,8 +34,8 @@ class="sci-toggle-checkbox" :disabled="!canShare" tabindex="0" - @change="checkboxChange" - @keyup.enter="handleCheckboxEnter"/> + @click.prevent="checkboxChange" + @keyup.enter="checkboxChange"/> @@ -199,12 +199,8 @@ export default { this.characterCount = this.$refs.textarea.value.length; }); }, - handleCheckboxEnter() { - this.sharedEnabled = !this.sharedEnabled; - this.checkboxChange(); - }, checkboxChange() { - if (this.sharedEnabled) { + if (!this.sharedEnabled) { $.post(this.shareableLinkUrl, { description: this.description }, (result) => { this.shareableData = result.data; this.$emit('enable'); @@ -224,6 +220,7 @@ export default { this.shareableData = {}; this.description = ''; this.dirty = false; + this.sharedEnabled = false; this.$emit('disable'); this.$emit('close');