Prevent user being added to project/task multiple times [SCI-2869]

app/controllers/user_my_modules_controller.rb

@@ -64,12 +64,11 @@ class UserMyModulesController < ApplicationController
       end
     else
       respond_to do |format|
-        format.json {
+        format.json do
-          render :json => {
+          render json: {
-            :errors => [
+            errors: @um.errors
-              flash_error]
           }
-        }
+        end
       end
     end
   end
@@ -102,13 +101,11 @@ class UserMyModulesController < ApplicationController
       end
     else
       respond_to do |format|
-        format.json {
+        format.json do
-          render :json => {
+          render json: {
-            :errors => [
+            errors: @um.errors
-              flash_error
-            ]
           }
-        }
+        end
       end
     end
   end

app/controllers/user_projects_controller.rb

@@ -111,14 +111,12 @@ class UserProjectsController < ApplicationController
       end
     else
       respond_to do |format|
-        format.json {
+        format.json do
-          render :json => {
+          render json: {
             status: 'error',
-            :errors => [
+            errors: @up.errors
-              flash_error
-            ]
           }
-        }
+        end
       end
     end
   end
@@ -148,13 +146,11 @@ class UserProjectsController < ApplicationController
       end
     else
       respond_to do |format|
-        format.json {
+        format.json do
-          render :json => {
+          render json: {
-            :errors => [
+            errors: @up.errors
-              flash_error
-            ]
           }
-        }
+        end
       end
     end
   end

app/models/user_my_module.rb

@@ -1,5 +1,6 @@
 class UserMyModule < ApplicationRecord
-  validates :user, :my_module, presence: true
+  validates :user, presence: true, uniqueness: { scope: :my_module }
+  validates :my_module, presence: true
 
   belongs_to :user, inverse_of: :user_my_modules, touch: true, optional: true
   belongs_to :assigned_by,

app/models/user_project.rb

@@ -2,7 +2,7 @@ class UserProject < ApplicationRecord
   enum role: { owner: 0, normal_user: 1, technician: 2, viewer: 3 }
 
   validates :role, presence: true
-  validates :user, presence: true
+  validates :user, presence: true, uniqueness: { scope: :project }
   validates :project, presence: true
 
   belongs_to :user, inverse_of: :user_projects, touch: true, optional: true

config/locales/en.yml

@@ -543,6 +543,7 @@ en:
     create:
       select_user_role: "Please select a user role."
       add_user_generic_error: "An error occured. "
+      can_add_user_to_project: "Can not add user to the project."
 
   my_modules:
     buttons: