scinote-eln/scinote-web
1
1
Fork 0
mirror of https://github.com/scinote-eln/scinote-web.git synced 2025-03-03 19:24:48 +08:00
Code Issues Projects Releases Packages Wiki Activity

Improve cancel edit button reliability, fix blink for non-smart-annotation fields [SCI-7068] (#4344)

Browse source
This commit is contained in:
artoscinote 2022-08-10 15:34:17 +02:00 committed by GitHub
parent a37c236518
commit 5df1701ae7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/javascript/vue/shared/inline_edit.vue
View file

@ -13,7 +13,7 @@
@blur="handleBlur"
@keyup.escape="cancelEdit"
></textarea>
<div v-else @click="enableEdit($event)" class="sci-inline-edit__view" v-html="(smartAnnotation ? sa_value : value) || placeholder" :class="{ 'blank': isBlank }"></div>
<div v-else @click="enableEdit($event)" class="sci-inline-edit__view" v-html="(smartAnnotation ? sa_value : newValue) || placeholder" :class="{ 'blank': isBlank }"></div>
<div v-if="editing && error" class="sci-inline-edit__error">
{{ error }}
</div>
@ -22,7 +22,7 @@
<div :class="{ 'btn-primary': !error, 'btn-disabled': error }" class="sci-inline-edit__control btn icon-btn" @click="update">
<i class="fas fa-check"></i>
</div>
<div class="sci-inline-edit__control btn btn-light icon-btn" @click="cancelEdit">
<div class="sci-inline-edit__control btn btn-light icon-btn" @mousedown="cancelEdit">
<i class="fas fa-times"></i>
</div>
</template>
@ -182,7 +182,6 @@
return;
}
setTimeout(() => {
if(this.error) return;
if(!this.$refs.input) return;
this.newValue = this.$refs.input.value // Fix for smart annotation
@ -190,7 +189,6 @@
this.editing = false;
this.$emit('editingDisabled');
this.$emit('update', this.newValue);
}, 100) // due to clicking 'x' also triggering a blur event
}
}
}