From 5e89f1f829ee99ff716bca7cc90a12d8ba63d09f Mon Sep 17 00:00:00 2001
From: sboursen-scinote <soufiane@scinote.net>
Date: Tue, 7 Mar 2023 05:48:20 +0100
Subject: [PATCH] Update my_module protocol status dropdown [SCI-7991]

---
 .../my_modules/protocols/index.scss           | 10 ++-
 .../protocols/_protocol_status_bar.html.erb   | 88 ++++++++++---------
 2 files changed, 53 insertions(+), 45 deletions(-)

diff --git a/app/assets/stylesheets/my_modules/protocols/index.scss b/app/assets/stylesheets/my_modules/protocols/index.scss
index 6fe56daac..81be7f68a 100644
--- a/app/assets/stylesheets/my_modules/protocols/index.scss
+++ b/app/assets/stylesheets/my_modules/protocols/index.scss
@@ -427,9 +427,14 @@
     max-width: 100vw;
     width: 506px;
 
+    .dropdown-content {
+      padding: 24px;
+    }
+
     .dropdown-header,
-    .dropdown-body {
-      padding: 10px 24px;
+    .dropdown-body,
+    .dropdown-footer {
+      padding: 12px 0;
     }
 
     .dropdown-header {
@@ -507,7 +512,6 @@
 
     .dropdown-footer {
       border-top: $border-tertiary;
-      padding: 12px 0 0;
     }
   }
 }
diff --git a/app/views/my_modules/protocols/_protocol_status_bar.html.erb b/app/views/my_modules/protocols/_protocol_status_bar.html.erb
index a933316e0..e8a0600ce 100644
--- a/app/views/my_modules/protocols/_protocol_status_bar.html.erb
+++ b/app/views/my_modules/protocols/_protocol_status_bar.html.erb
@@ -15,53 +15,57 @@
     <i class="fas fa-info-circle"></i>
   </a>
   <div class="dropdown-menu status-info-dropdown" aria-labelledby="my-module-protocol-info-button">
-    <div class="dropdown-header">
-      <h2 class="protocol-name">
-        <%= @protocol.parent&.name || @protocol.name %>
-      </h2>
-      <% if @protocol.linked? %>
-        <div class="protocol-header-info">
-          <span><%= t('my_modules.protocols.protocol_status_bar.protocol_id_label') %> <%= @protocol.parent&.code %></span>
-          <span><%= t('my_modules.protocols.protocol_status_bar.protocol_version_label') %> <%= @protocol.parent&.version_number %></span>
+    <div class="dropdown-content">
+        <div class="dropdown-header">
+          <h2 class="protocol-name">
+            <%= @protocol.parent&.name || @protocol.name %>
+          </h2>
+          <% if @protocol.linked? %>
+            <div class="protocol-header-info">
+              <span><%= t('my_modules.protocols.protocol_status_bar.protocol_id_label') %> <%= @protocol.parent&.code %></span>
+              <span><%= t('my_modules.protocols.protocol_status_bar.protocol_version_label') %> <%= @protocol.parent&.version_number %></span>
+            </div>
+          <% end %>
         </div>
-      <% end %>
-    </div>
-    <div class="dropdown-body">
-      <% if @protocol.unlinked? %>
-        <div class="info-line">
-          <div class="description"><%= t("my_modules.protocols.protocol_status_bar.protocol_created") %></div>
-          <div class="value"><%= I18n.l(@protocol.created_at, format: :full) %></div>
-        </div>
-      <% end %>
-      <div class="info-line">
-        <div class="description"><%= t("my_modules.protocols.protocol_status_bar.protocol_updated") %></div>
-        <div class="value"><%= I18n.l(@protocol.updated_at, format: :full) %></div>
-      </div>
-      <% if @protocol.linked?%>
-        <div class="info-line">
-          <div class="description"><%= t("my_modules.protocols.protocol_status_bar.protocol_loaded") %></div>
-          <div class="value"><%= @protocol.linked_at ? I18n.l(@protocol.linked_at, format: :full) : '' %></div>
-        </div>
-        <div class="info-line">
-          <div class="description"><%= t("my_modules.protocols.protocol_status_bar.protocol_published") %></div>
-          <div class="value"><%= I18n.l(@protocol&.parent&.published_on, format: :full) %></div>
+        <div class="dropdown-body">
+          <% if @protocol.unlinked? %>
+            <div class="info-line">
+              <div class="description"><%= t("my_modules.protocols.protocol_status_bar.protocol_created") %></div>
+              <div class="value"><%= I18n.l(@protocol.created_at, format: :full) %></div>
+            </div>
+          <% end %>
+          <div class="info-line">
+            <div class="description"><%= t("my_modules.protocols.protocol_status_bar.protocol_updated") %></div>
+            <div class="value"><%= I18n.l(@protocol.updated_at, format: :full) %></div>
+          </div>
+          <% if @protocol.linked?%>
+            <div class="info-line">
+              <div class="description"><%= t("my_modules.protocols.protocol_status_bar.protocol_loaded") %></div>
+              <div class="value"><%= @protocol.linked_at ? I18n.l(@protocol.linked_at, format: :full) : '' %></div>
+            </div>
+            <div class="info-line">
+              <div class="description"><%= t("my_modules.protocols.protocol_status_bar.protocol_published") %></div>
+              <div class="value"><%= I18n.l(@protocol&.parent&.published_on, format: :full) %></div>
+            </div>
+          <% end %>
         </div>
         <div class="dropdown-footer">
-          <% if @protocol.parent_newer? || @protocol.parent_and_self_newer? %>
-            <div class="notification-line new-parent-version">
-              <i class="fas fa-info-circle"></i>
-              <div class="description"><%= t("my_modules.protocols.protocol_status_bar.messages.template_updated_html") %></div>
-            </div>
-          <% end %>
-          <% if @protocol.newer_than_parent? %>
-            <div class="notification-line new-protocol-version">
-              <i class="fas fa-info-circle"></i>
-              <div class="description"><%= t("my_modules.protocols.protocol_status_bar.messages.protocol_updated") %></div>
-            </div>
+          <% if @protocol.linked? %>
+            <% if @protocol.parent_newer? || @protocol.parent_and_self_newer? %>
+              <div class="notification-line new-parent-version">
+                <i class="fas fa-info-circle"></i>
+                <div class="description"><%= t("my_modules.protocols.protocol_status_bar.messages.template_updated_html") %></div>
+              </div>
+            <% end %>
+            <% if @protocol.newer_than_parent? %>
+              <div class="notification-line new-protocol-version">
+                <i class="fas fa-info-circle"></i>
+                <div class="description"><%= t("my_modules.protocols.protocol_status_bar.messages.protocol_updated") %></div>
+              </div>
+            <% end %>
           <% end %>
         </div>
-      <% end %>
+      </div>
     </div>
-  </div>
 </div>
 <%= javascript_include_tag("my_modules/protocols/protocol_status_bar") %>