From 63b7b937bbd8d110c9446d7e0a53d012ce57f034 Mon Sep 17 00:00:00 2001 From: Luka Murn Date: Mon, 14 May 2018 23:48:03 +0200 Subject: [PATCH] Fix a bug with table order not updating properly with col deletion --- .../repository_table_state_column_update_service.rb | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/app/services/repository_table_state_column_update_service.rb b/app/services/repository_table_state_column_update_service.rb index b80c5a74c..2598a7327 100644 --- a/app/services/repository_table_state_column_update_service.rb +++ b/app/services/repository_table_state_column_update_service.rb @@ -54,7 +54,12 @@ class RepositoryTableStateColumnUpdateService end end - state['order'].reject! { |k, v| v[0] == old_column_index } + state['order'].reject! { |_, v| v[0] == old_column_index } + state['order'].each do |k, v| + if v[0].to_i > old_column_index.to_i + state['order'][k] = [(v[0].to_i - 1).to_s, v[1]] + end + end if state['order'].empty? # Fallback to default order if user had table ordered by # the deleted column