From 6d3b6042766ad0cabc09b360674c4f1d5b4855be Mon Sep 17 00:00:00 2001 From: Gregor Lasnibat Date: Mon, 29 Jan 2024 12:57:43 +0100 Subject: [PATCH] (fix) TypeError is logged when you press backspace in an empty keywords input field [SCI-9389] --- app/assets/javascripts/sitewide/dropdown_selector.js | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/app/assets/javascripts/sitewide/dropdown_selector.js b/app/assets/javascripts/sitewide/dropdown_selector.js index 1ef939225..b78704270 100644 --- a/app/assets/javascripts/sitewide/dropdown_selector.js +++ b/app/assets/javascripts/sitewide/dropdown_selector.js @@ -716,15 +716,16 @@ var dropdownSelector = (function() { // Add timeout for deleting animation setTimeout(() => { - if (selector.data('combine-tags')) { + const $selector = $(selector); + if ($selector.data('combine-tags')) { // if we use combine-tags options we simply clear all values container.find('.data-field').val('[]'); - updateTags(selector, container); + updateTags($selector, container); } else { // Or delete specific one - deleteValue(selector, container, tagLabel.data('ds-tag-id'), tagLabel.data('ds-tag-group')); - if (selector.data('config').tagClass) { - removeOptionFromSelector(selector, tagLabel.data('ds-tag-id')); + deleteValue($selector, container, tagLabel.data('ds-tag-id'), tagLabel.data('ds-tag-group')); + if ($selector.data('config').tagClass) { + removeOptionFromSelector($selector, tagLabel.data('ds-tag-id')); } } }, 350);