From 703be13fb00cc798ca056bd472ac316f086674c5 Mon Sep 17 00:00:00 2001
From: zmagod <zmago_devetak@yahoo.com>
Date: Thu, 22 Jun 2017 15:21:36 +0200
Subject: [PATCH] removes imported repository row if the row value is not valid
 [fixes SCI-1393]

---
 app/models/repository.rb | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/app/models/repository.rb b/app/models/repository.rb
index 333f62282..40664560d 100644
--- a/app/models/repository.rb
+++ b/app/models/repository.rb
@@ -90,11 +90,9 @@ class Repository < ActiveRecord::Base
                                  created_by: user,
                                  last_modified_by: user)
 
-      next unless record_row.save
-      nr_of_added += 1
+      next unless record_row.valid?
       sheet.row(i).each.with_index do |value, index|
-        if custom_fields[index]
-          # we're working with CustomField
+        if custom_fields[index] && value
           rep_column = RepositoryTextValue.new(
             data: value,
             created_by: user,
@@ -105,11 +103,14 @@ class Repository < ActiveRecord::Base
             }
           )
           error << rep_column.errors.messages unless rep_column.save
-        else
-          # This custom_field does not exist
-          error << { '#{mappings[index]}': 'Does not exists' }
         end
       end
+      if error.any?
+        record_row.destroy
+      else
+        nr_of_added += 1
+        record_row.save
+      end
     end
 
     if errors.count > 0