From 7719b825e34c44f3d7d74f79d4b8c2ff9687c855 Mon Sep 17 00:00:00 2001
From: Urban Rotnik <urban.rotnik@gmail.com>
Date: Fri, 9 Aug 2019 12:44:41 +0200
Subject: [PATCH] Update wording for sharing activities, rename button, add
 view-only paragraph

---
 app/assets/stylesheets/repositories.scss                   | 6 ++++++
 app/controllers/team_repositories_controller.rb            | 3 ++-
 app/services/repositories/multiple_share_update_service.rb | 3 ++-
 app/views/repositories/show.html.erb                       | 5 ++---
 config/initializers/extends.rb                             | 5 +++++
 config/locales/en.yml                                      | 4 ++--
 config/locales/global_activities/en.yml                    | 4 ++--
 7 files changed, 21 insertions(+), 9 deletions(-)

diff --git a/app/assets/stylesheets/repositories.scss b/app/assets/stylesheets/repositories.scss
index ef9c8764c..c108127c3 100644
--- a/app/assets/stylesheets/repositories.scss
+++ b/app/assets/stylesheets/repositories.scss
@@ -89,6 +89,12 @@
   }
 }
 
+.toolbarButtonsDatatable {
+  .view-only-label {
+    opacity: .6;
+  }
+}
+
 .sidebar-button {
   span {
     display: inline-block !important;
diff --git a/app/controllers/team_repositories_controller.rb b/app/controllers/team_repositories_controller.rb
index 3f604f01b..39e79fadb 100644
--- a/app/controllers/team_repositories_controller.rb
+++ b/app/controllers/team_repositories_controller.rb
@@ -101,6 +101,7 @@ class TeamRepositoriesController < ApplicationController
             team: current_team,
             message_items: { repository: team_repository.repository.id,
                              team: team_repository.team.id,
-                             permission_level: team_repository.permission_level })
+                             permission_level:
+                               Extends::SHARED_INVENTORIES_PL_MAPPINGS[team_repository.permission_level.to_sym] })
   end
 end
diff --git a/app/services/repositories/multiple_share_update_service.rb b/app/services/repositories/multiple_share_update_service.rb
index a034e6ff2..7356b4d9f 100644
--- a/app/services/repositories/multiple_share_update_service.rb
+++ b/app/services/repositories/multiple_share_update_service.rb
@@ -101,7 +101,8 @@ module Repositories
               team: @team,
               message_items: { repository: team_repository.repository.id,
                                team: team_repository.team.id,
-                               permission_level: team_repository.permission_level })
+                               permission_level:
+                                 Extends::SHARED_INVENTORIES_PL_MAPPINGS[team_repository.permission_level.to_sym] })
     end
   end
 end
diff --git a/app/views/repositories/show.html.erb b/app/views/repositories/show.html.erb
index f8901fcb1..26162e1f3 100644
--- a/app/views/repositories/show.html.erb
+++ b/app/views/repositories/show.html.erb
@@ -53,9 +53,6 @@
 
         <% if can_perform_repository_actions(@repository) %>
           <ul class="dropdown-menu pull-right">
-            <li class="dropdown-header">
-              <%= t("repositories.index.options_dropdown.header") %>
-            </li>
             <% if can_create_repository_columns?(@repository) %>
               <li>
                 <%= link_to t('repositories.index.options_dropdown.manage_columns'),
@@ -148,6 +145,8 @@
         <span class="fas fa-copy"></span>
         <span class="hidden-xs-custom"><%= t("repositories.copy_record") %></span>
       </button>
+    <% elsif @repository.team_repositories.where(team: current_team).first.read? %>
+      <p class="view-only-label"><%= t('repositories.index.view_only_permission_label') %></p>
     <% end %>
   </div>
 
diff --git a/config/initializers/extends.rb b/config/initializers/extends.rb
index 46e37e73c..b494095a2 100644
--- a/config/initializers/extends.rb
+++ b/config/initializers/extends.rb
@@ -244,4 +244,9 @@ class Extends
     read: 0,
     write: 1
   }.freeze
+
+  SHARED_INVENTORIES_PL_MAPPINGS = {
+    read: 'view-only',
+    write: 'edit'
+  }.freeze
 end
diff --git a/config/locales/en.yml b/config/locales/en.yml
index a21e06f9f..facb33f7c 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -987,8 +987,8 @@ en:
       edit_inventory: "Edit Inventory"
       share_inventory: "Share"
       title_label: "Inventory:"
+      view_only_permission_label: "This team has a view-only permission"
       options_dropdown:
-        header: "Edit inventory"
         manage_columns: 'Manage columns'
         import_items: 'Import items'
         export_items: 'Export items'
@@ -1044,7 +1044,7 @@ en:
         errors_list_title: "Items were not imported because one or more errors were found:"
         no_repository_name: "Item name is required!"
     edit_record: "Edit"
-    copy_record: "Copy"
+    copy_record: "Duplicate"
     delete_record: "Delete"
     save_record: "Save"
     cancel_save: "Cancel"
diff --git a/config/locales/global_activities/en.yml b/config/locales/global_activities/en.yml
index 87612ff00..b17818777 100644
--- a/config/locales/global_activities/en.yml
+++ b/config/locales/global_activities/en.yml
@@ -102,9 +102,9 @@ en:
       create_inventory_html: "%{user} created inventory %{repository}."
       rename_inventory_html: "%{user} renamed inventory %{repository}."
       delete_inventory_html: "%{user} deleted inventory %{repository}."
-      share_inventory_html: "%{user} shared inventory %{repository} with team %{team} with %{permission_level} permission."
+      share_inventory_html: "%{user} shared inventory %{repository} with team %{team} with %{permission_level} permissions."
       unshare_inventory_html: "%{user} stopped sharing inventory %{repository} with team %{team}."
-      update_share_inventory_html: "%{user} set permission to %{permission_level} for sharing inventory %{repository} with team %{team}."
+      update_share_inventory_html: "%{user} changed permission of the shared inventory %{repository} to %{permission_level} with team %{team}."
       create_item_inventory_html: "%{user} created inventory item %{repository_row}."
       edit_item_inventory_html: "%{user} edited inventory item %{repository_row}."
       delete_item_inventory_html: "%{user} deleted inventory item %{repository_row}."