From 774aa6cf9c20facf5cb1ea3341cf4b9a1d84b4ed Mon Sep 17 00:00:00 2001 From: Anton Date: Tue, 23 Nov 2021 11:08:46 +0100 Subject: [PATCH] Fix experiment moving with archived tasks [SCI-6291] --- app/permissions/my_module.rb | 4 ++++ app/services/experiments/move_to_project_service.rb | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/app/permissions/my_module.rb b/app/permissions/my_module.rb index 0f595a446..278e4be0e 100644 --- a/app/permissions/my_module.rb +++ b/app/permissions/my_module.rb @@ -35,6 +35,10 @@ Canaid::Permissions.register_for(MyModule) do !my_module.archived? && my_module.permission_granted?(user, MyModulePermissions::MANAGE) end + can :move_my_module do |user, my_module| + my_module.permission_granted?(user, MyModulePermissions::MANAGE) + end + can :update_my_module_start_date do |user, my_module| my_module.permission_granted?(user, MyModulePermissions::UPDATE_START_DATE) end diff --git a/app/services/experiments/move_to_project_service.rb b/app/services/experiments/move_to_project_service.rb index e84a47082..c36b32cd4 100644 --- a/app/services/experiments/move_to_project_service.rb +++ b/app/services/experiments/move_to_project_service.rb @@ -26,7 +26,7 @@ module Experiments ActiveRecord::Base.transaction do @exp.project = @project @exp.my_modules.each do |my_module| - raise unless can_manage_my_module?(@user, my_module) + raise unless can_move_my_module?(@user, my_module) sync_user_assignments(my_module) move_tags!(my_module)