Fix rendering of RTE images for shareable links [SCI-8970] (#5913)

app/models/concerns/tiny_mce_images.rb

@@ -47,6 +47,10 @@ module TinyMceImages
       TinyMceAsset.generate_url(self[field], self)
     end
 
+    def shareable_tinymce_render(field)
+      TinyMceAsset.generate_url(self[field], self, is_shared_object: true)
+    end
+
     # Takes array of old/new TinyMCE asset ID pairs
     # and updates references in assosiated object's description
     def reassign_tiny_mce_image_references(images = [])

app/models/tiny_mce_asset.rb

@@ -58,7 +58,7 @@ class TinyMceAsset < ApplicationRecord
     Rails.logger.error e.backtrace.join("\n")
   end
 
-  def self.generate_url(description, obj = nil)
+  def self.generate_url(description, obj = nil, is_shared_object: false)
     # Check tinymce for old format
     description = update_old_tinymce(description, obj)
 
@@ -75,7 +75,11 @@ class TinyMceAsset < ApplicationRecord
       asset_id = tm_asset.attr('data-mce-token')
       new_asset = obj.tiny_mce_assets.find_by(id: Base62.decode(asset_id))
       if new_asset&.image&.attached?
-        tm_asset.attributes['src'].value = Rails.application.routes.url_helpers.url_for(new_asset.image)
+        tm_asset.attributes['src'].value = if is_shared_object
+                                             new_asset.image.url(expires_in: Constants::URL_SHORT_EXPIRE_TIME.minutes)
+                                           else
+                                             Rails.application.routes.url_helpers.url_for(new_asset.image)
+                                           end
         tm_asset['class'] = 'img-responsive'
       end
     end

app/views/shareable_links/my_module_protocol_show.html.erb

@@ -42,7 +42,7 @@
         <div class="task-notes">
           <div class="task-notes-content">
             <% if @my_module.description.present? %>
-            <%= smart_annotation_text(@my_module.tinymce_render(:description)) %>
+            <%= smart_annotation_text(@my_module.shareable_tinymce_render(:description)) %>
             <% else %>
               <span class="no-description"><%= t('my_modules.notes.no_description') %></span>
             <% end %>

app/views/shareable_links/my_modules/_protocol.html.erb

@@ -33,7 +33,7 @@
           <div id="protocol-description-container" >
             <% if protocol.description.present? %>
               <div>
-                <%=  smart_annotation_text(protocol.tinymce_render(:description)) %>
+                <%=  smart_annotation_text(protocol.shareable_tinymce_render(:description)) %>
               </div>
             <% else %>
               <div class="empty-protocol-description">

app/views/shareable_links/my_modules/step_elements/_text.html.erb

@@ -2,7 +2,7 @@
   <div class="step-element-grip-placeholder"></div>
   <% if element.text.present? %>
     <div class="view-text-element">
-      <%= smart_annotation_text(element.tinymce_render(:text)) %>
+      <%= smart_annotation_text(element.shareable_tinymce_render(:text)) %>
     </div>
   <% else %>
     <div class="empty-text-element">