Merge pull request #4657 from artoscinote/ma_SCI_7534

Move atwho initialization to when a field is focused [SCI-7534]
This commit is contained in:
artoscinote 2022-11-28 12:39:45 +01:00 committed by GitHub
commit 7cc09faa94
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -122,8 +122,10 @@ var SmartAnnotation = (function() {
}
function init() {
$(field)
.on('shown.atwho', function() {
$(field).on('focus', function() {
if ($(this).data('atwho-initialized')) return;
$(field).on('shown.atwho', function() {
var $currentAtWho = $('.atwho-view[style]:not(.old)');
var atWhoId = $currentAtWho.find('.atwho-header-res').data('at-who-key');
$currentAtWho.addClass('old').attr('data-at-who-id', atWhoId);
@ -157,8 +159,7 @@ var SmartAnnotation = (function() {
}
$currentAtWho.find(`.${filterType}`).click();
}
})
.on('reposition.atwho', function(event, flag, query) {
}).on('reposition.atwho', function(event, flag, query) {
let inputFieldLeft = query.$inputor.offset().left;
if (inputFieldLeft > $(window).width()) {
let leftPosition;
@ -172,8 +173,7 @@ var SmartAnnotation = (function() {
if ($('.repository-show').length) {
query.$el.find('.atwho-view').css('top', flag.top + 'px');
}
})
.atwho({
}).atwho({
at: '@',
callbacks: {
remoteFilter: function(query, callback) {
@ -197,11 +197,14 @@ var SmartAnnotation = (function() {
acceptSpaceBar: true,
displayTimeout: 120000
})
.atwho(atWhoSettings('#'));
// .atwho(atWhoSettings('task#', FilterTypeEnum.TASK)) Waiting for better times
// .atwho(atWhoSettings('project#', FilterTypeEnum.PROJECT))
// .atwho(atWhoSettings('experiment#', FilterTypeEnum.EXPERIMENT))
// .atwho(atWhoSettings('sample#', FilterTypeEnum.REPOSITORY));
.atwho(atWhoSettings('#'));
// .atwho(atWhoSettings('task#', FilterTypeEnum.TASK)) Waiting for better times
// .atwho(atWhoSettings('project#', FilterTypeEnum.PROJECT))
// .atwho(atWhoSettings('experiment#', FilterTypeEnum.EXPERIMENT))
// .atwho(atWhoSettings('sample#', FilterTypeEnum.REPOSITORY));
$(this).data('atwho-initialized', true);
});
}
return {