From 82b114871a2cc6717cc3b897112fcc2c8389f056 Mon Sep 17 00:00:00 2001 From: wandji20 Date: Tue, 2 Apr 2024 09:40:05 +0100 Subject: [PATCH] Remove unnecessary window function [SCI-10553] --- .../vue/shared/datatable/mixins/card_selector.js | 8 ++++---- app/javascript/vue/shared/datatable/table.vue | 2 -- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/app/javascript/vue/shared/datatable/mixins/card_selector.js b/app/javascript/vue/shared/datatable/mixins/card_selector.js index 85b50e3f9..031c1520e 100644 --- a/app/javascript/vue/shared/datatable/mixins/card_selector.js +++ b/app/javascript/vue/shared/datatable/mixins/card_selector.js @@ -1,20 +1,20 @@ export default { computed: { cardSelected() { - const item = window.dtComponent.selectedRows.find((i) => (i.code === this.params.code)); + const item = this.dtComponent.selectedRows.find((i) => (i.code === this.params.code)); return !!item; } }, methods: { itemSelected() { - const item = window.dtComponent.selectedRows.find((i) => (i.code === this.params.code)); + const item = this.dtComponent.selectedRows.find((i) => (i.code === this.params.code)); if (item) { - window.dtComponent.selectedRows = window.dtComponent.selectedRows + this.dtComponent.selectedRows = this.dtComponent.selectedRows .filter((i) => (i.code !== this.params.code)); } else { - window.dtComponent.selectedRows.push(this.params); + this.dtComponent.selectedRows.push(this.params); } }, }, diff --git a/app/javascript/vue/shared/datatable/table.vue b/app/javascript/vue/shared/datatable/table.vue index 806292fd5..4c7697200 100644 --- a/app/javascript/vue/shared/datatable/table.vue +++ b/app/javascript/vue/shared/datatable/table.vue @@ -335,11 +335,9 @@ export default { this.setGridColsClass(); window.addEventListener('resize', this.resize); - window.dtComponent = this; }, beforeDestroy() { delete window.resetGridColumns; - delete window.dtComponent; window.removeEventListener('resize', this.resize); }, methods: {