scinote-eln/scinote-web
1
1
Fork 0
mirror of https://github.com/scinote-eln/scinote-web.git synced 2025-01-30 19:48:18 +08:00
Code Issues Projects Releases Packages Wiki Activity

Use service in controller

Browse source
This commit is contained in:
Urban Rotnik 2019-06-14 10:41:51 +02:00
parent 7fad5fc594
commit 88d96c0938
3 changed files with 14 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
app/controllers/external_protocols_controller.rb
View file

@ -6,25 +6,18 @@ class ExternalProtocolsController < ApplicationController
# GET list_external_protocol # GET list_external_protocol
def index def index
# list_protocols = SearchService.call(index_params) service_call = ProtocolImporters::SearchProtocolsService
succeed = true .call(protocol_source: 'protocolsio/v3', query_params: index_params)
protocols = [
{ name: 'Protocol1' },
{ name: 'Protocol2' },
{ name: 'Protocol3' }
]
if succeed if service_call.succeed?
render json: { render json: {
html: render_to_string( html: render_to_string(
partial: 'protocol_importers/list_of_protocol_cards.html.erb', partial: 'protocol_importers/list_of_protocol_cards.html.erb',
locals: { protocols: protocols } locals: { protocols: service_call.protocols_list }
) )
} }
else else
render json: { render json: { errors: service_call.errors }, status: 400
errors: { protocol: 'error_placeholder' }
}, status: 400
end end
end end

2
app/services/protocol_importers/search_protocols_service.rb
View file

@ -35,7 +35,7 @@ module ProtocolImporters
@errors[:invalid_params][:key] = 'Key cannot be empty' if @query_params[:key].blank? @errors[:invalid_params][:key] = 'Key cannot be empty' if @query_params[:key].blank?
# try if page id is ok # try if page id is ok
if @query_params[:page_id] && !@query_params[:page_id].positive? if @query_params[:page_id] && !@query_params[:page_id].to_i.positive?
@errors[:invalid_params][:page_id] = 'Page needs to be positive' @errors[:invalid_params][:page_id] = 'Page needs to be positive'
end end

8
spec/controllers/external_protocols_controller_spec.rb
View file

@ -24,6 +24,14 @@ describe ExternalProtocolsController, type: :controller do
let(:action) { get :index, params: params } let(:action) { get :index, params: params }
before do
service = double('success_service')
allow(service).to(receive(:succeed?)).and_return(true)
allow(service).to(receive(:protocols_list)).and_return({})
allow_any_instance_of(ProtocolImporters::SearchProtocolsService).to(receive(:call)).and_return(service)
end
it 'returns JSON, 200 response when protocol parsing was valid' do it 'returns JSON, 200 response when protocol parsing was valid' do
action action
expect(response).to have_http_status(:success) expect(response).to have_http_status(:success)