scinote-eln/scinote-web
1
1
Fork 0
mirror of https://github.com/scinote-eln/scinote-web.git synced 2025-09-06 05:04:35 +08:00
Code Issues Projects Releases Packages Wiki Activity

Move REPOSITORIES_LIMIT from constants to env variables [SCI-2301]

Browse source
This commit is contained in:
Oleksii Kriuchykhin 2018-05-09 18:03:16 +02:00
parent a6275062b7
commit 8ec643c54b
5 changed files with 11 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
app/controllers/at_who_controller.rb
View file

@ -44,7 +44,8 @@ class AtWhoController < ApplicationController
end end
def repositories def repositories
repositories = @team.repositories.limit(Constants::REPOSITORIES_LIMIT) repositories =
@team.repositories.limit(Rails.configuration.x.repositories_limit)
respond_to do |format| respond_to do |format|
format.json do format.json do
render json: { render json: {

6
app/controllers/repositories_controller.rb
View file

@ -300,8 +300,10 @@ class RepositoriesController < ApplicationController
end end
def check_create_permissions def check_create_permissions
render_403 unless can_create_repositories?(@team) || unless can_create_repositories?(@team) ||
@team.repositories.count < Constants::REPOSITORIES_LIMIT @team.repositories.count < Rails.configuration.x.repositories_limit
render_403
end
end end
def check_manage_permissions def check_manage_permissions

2
app/permissions/team.rb
View file

@ -44,7 +44,7 @@ Canaid::Permissions.register_for(Team) do
# repository: create, copy # repository: create, copy
can :create_repositories do |user, team| can :create_repositories do |user, team|
user.is_admin_of_team?(team) && user.is_admin_of_team?(team) &&
team.repositories.count < Constants::REPOSITORIES_LIMIT team.repositories.count < Rails.configuration.x.repositories_limit
end end
# repository: create/import record # repository: create/import record

3
config/initializers/constants.rb
View file

@ -58,9 +58,6 @@ class Constants
# Max characters for repository name in Atwho modal # Max characters for repository name in Atwho modal
ATWHO_REP_NAME_LIMIT = 16 ATWHO_REP_NAME_LIMIT = 16
# Maximum number of repositories per team allowed
REPOSITORIES_LIMIT = 5
#============================================================================= #=============================================================================
# File and data memory size # File and data memory size
#============================================================================= #=============================================================================

4
config/initializers/repositories.rb Normal file
View file

@ -0,0 +1,4 @@
Rails.application.configure do
# Maximum number of repositories per team allowed
config.x.repositories_limit = ENV['REPOSITORIES_LIMIT'].to_i || 5
end