From c61a075818d3d2a4a242eca6bd1bf33795b6ded6 Mon Sep 17 00:00:00 2001
From: Oleksii Kriuchykhin <oleksii@scinote.net>
Date: Fri, 4 Aug 2023 15:09:59 +0200
Subject: [PATCH] Fix file URL generation on shared task page [SCI-8974]

---
 app/controllers/my_module_shareable_links_controller.rb    | 7 +++----
 app/models/my_module.rb                                    | 3 +++
 .../my_modules/step_attachments/_file_preview.html.erb     | 6 +++---
 .../my_modules/step_attachments/_inline.html.erb           | 2 +-
 .../my_modules/step_attachments/_thumbnail.html.erb        | 2 +-
 5 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/app/controllers/my_module_shareable_links_controller.rb b/app/controllers/my_module_shareable_links_controller.rb
index 266d794cd..1a566ff5c 100644
--- a/app/controllers/my_module_shareable_links_controller.rb
+++ b/app/controllers/my_module_shareable_links_controller.rb
@@ -68,7 +68,8 @@ class MyModuleShareableLinksController < ApplicationController
   end
 
   def download_asset
-    redirect_to @asset.file.url(disposition: 'attachment')
+    redirect_to @asset.file.url(expires_in: Constants::URL_SHORT_EXPIRE_TIME.minutes, disposition: 'attachment'),
+                allow_other_host: true
   end
 
   def create
@@ -119,9 +120,7 @@ class MyModuleShareableLinksController < ApplicationController
   end
 
   def load_asset
-    @asset = Asset.joins(step: { protocol: :my_module })
-                  .find_by(my_modules: { id: @my_module.id },
-                           assets: { id: params[:id] })
+    @asset = @my_module.assets_in_steps.find_by(id: params[:id])
 
     return render_404 if @asset.blank?
   end
diff --git a/app/models/my_module.rb b/app/models/my_module.rb
index 11e0e5ee8..15b53b201 100644
--- a/app/models/my_module.rb
+++ b/app/models/my_module.rb
@@ -69,6 +69,9 @@ class MyModule < ApplicationRecord
   has_many :designated_users, through: :user_my_modules, source: :user
   has_many :report_elements, inverse_of: :my_module, dependent: :destroy
   has_many :protocols, inverse_of: :my_module, dependent: :destroy
+  has_many :steps, through: :protocols
+  has_many :assets_in_steps, class_name: 'Asset', source: :assets, through: :steps
+  has_many :assets_in_results, class_name: 'Asset', source: :asset, through: :results
   # Associations for old activity type
   has_many :activities, inverse_of: :my_module
 
diff --git a/app/views/shareable_links/my_modules/step_attachments/_file_preview.html.erb b/app/views/shareable_links/my_modules/step_attachments/_file_preview.html.erb
index 414e29dc1..347cfd96a 100644
--- a/app/views/shareable_links/my_modules/step_attachments/_file_preview.html.erb
+++ b/app/views/shareable_links/my_modules/step_attachments/_file_preview.html.erb
@@ -22,7 +22,7 @@
       </div>
       <div class="modal-body">
         <div class="file-preview-container">
-          <% if asset.previewable? %>
+          <% if asset.previewable? && !asset.file_processing %>
             <% if wopi_enabled? && wopi_file?(asset) %>
               <iframe class="wopi-file-preview" src="<%= asset.get_action_url(nil, 'embedview', false) %>"></iframe>
             <% elsif asset.pdf_previewable? %>
@@ -46,7 +46,7 @@
               class: "previous-asset shareable-gallery-switcher",
               data: { id: previous_asset.id } do %>
               <i class="sn-icon sn-icon-arrow-left"></i>
-              <% if previous_asset.previewable? %>
+              <% if previous_asset.previewable? && !previous_asset.file_processing %>
                 <%= image_tag previous_asset.file.representation(resize_to_limit: Constants::MEDIUM_PIC_FORMAT).url(expires_in: Constants::URL_SHORT_EXPIRE_TIME.minutes),
                     class: 'asset-image',
                     style: 'opacity: 0' %>
@@ -63,7 +63,7 @@
             <%= link_to '#',
               class: "next-asset shareable-gallery-switcher",
               data: { id: next_asset.id } do %>
-              <% if next_asset.previewable? %>
+              <% if next_asset.previewable? && !next_asset.file_processing %>
                 <%= image_tag next_asset.file.representation(resize_to_limit: Constants::MEDIUM_PIC_FORMAT).url(expires_in: Constants::URL_SHORT_EXPIRE_TIME.minutes),
                     class: 'asset-image',
                     style: 'opacity: 0' %>
diff --git a/app/views/shareable_links/my_modules/step_attachments/_inline.html.erb b/app/views/shareable_links/my_modules/step_attachments/_inline.html.erb
index b9fcd1e09..4f0cea393 100644
--- a/app/views/shareable_links/my_modules/step_attachments/_inline.html.erb
+++ b/app/views/shareable_links/my_modules/step_attachments/_inline.html.erb
@@ -25,7 +25,7 @@
     <iframe class="wopi-file-preview" src="<%= asset.get_action_url(nil, 'embedview', false) %>"></iframe>
   <% elsif asset.pdf_previewable? %>
     <%= render partial: 'shared/pdf_viewer', locals: { asset: asset, report_document: false, shareable_document: true } %>
-  <% elsif asset.previewable? %>
+  <% elsif asset.previewable? && !asset.file_processing %>
     <div class="image-container">
       <%= image_tag asset.file.representation(resize_to_limit: Constants::LARGE_PIC_FORMAT).url(expires_in: Constants::URL_SHORT_EXPIRE_TIME.minutes),
           class: 'asset-preview-image',
diff --git a/app/views/shareable_links/my_modules/step_attachments/_thumbnail.html.erb b/app/views/shareable_links/my_modules/step_attachments/_thumbnail.html.erb
index dc02f3632..c4ba547d8 100644
--- a/app/views/shareable_links/my_modules/step_attachments/_thumbnail.html.erb
+++ b/app/views/shareable_links/my_modules/step_attachments/_thumbnail.html.erb
@@ -7,7 +7,7 @@
             id: asset.id
           } do %>
     <div class="attachment-preview <%= asset.file.attached? ? asset.file.metadata['asset_type'] : '' %>">
-      <% if asset.previewable? %>
+      <% if asset.previewable? && !asset.file_processing %>
         <%= image_tag asset.file.representation(resize_to_limit: Constants::MEDIUM_PIC_FORMAT).url(expires_in: Constants::URL_SHORT_EXPIRE_TIME.minutes),
             class: 'asset-preview-image',
             style: 'opacity: 0' %>