From b8e91e91a1bbeb271e0abe693ce298bbfad800aa Mon Sep 17 00:00:00 2001
From: mlorb <mlorber@biosistemika.com>
Date: Thu, 5 Apr 2018 16:30:02 +0200
Subject: [PATCH 1/5] refactor settings into the new navigation bar

---
 .../javascripts/users/settings/list_toggle.js | 11 +++
 .../users/registrations_controller.rb         |  1 +
 .../settings/account/addons_controller.rb     |  1 +
 .../account/preferences_controller.rb         |  1 +
 .../users/settings/teams_controller.rb        |  2 +
 app/views/users/registrations/edit.html.erb   |  7 +-
 app/views/users/settings/_sidebar.html.erb    | 95 +++++++++++++++++++
 .../settings/account/addons/index.html.erb    |  7 +-
 .../account/preferences/index.html.erb        |  7 +-
 app/views/users/settings/teams/index.html.erb |  2 +-
 app/views/users/settings/teams/new.html.erb   |  2 +-
 app/views/users/settings/teams/show.html.erb  |  2 +-
 config/initializers/assets.rb                 |  1 +
 config/locales/en.yml                         |  8 ++
 14 files changed, 129 insertions(+), 18 deletions(-)
 create mode 100644 app/assets/javascripts/users/settings/list_toggle.js
 create mode 100644 app/views/users/settings/_sidebar.html.erb

diff --git a/app/assets/javascripts/users/settings/list_toggle.js b/app/assets/javascripts/users/settings/list_toggle.js
new file mode 100644
index 000000000..38d2c8610
--- /dev/null
+++ b/app/assets/javascripts/users/settings/list_toggle.js
@@ -0,0 +1,11 @@
+function listToggleShow() {
+  $('#triangleDown').show();
+  $('#triangleRight').hide();
+  $('#accountNavigation').show();
+}
+
+function listToggleHide() {
+  $('#triangleDown').hide();
+  $('#triangleRight').show();
+  $('#accountNavigation').hide();
+}
diff --git a/app/controllers/users/registrations_controller.rb b/app/controllers/users/registrations_controller.rb
index 9adfc5e6c..501526f4e 100644
--- a/app/controllers/users/registrations_controller.rb
+++ b/app/controllers/users/registrations_controller.rb
@@ -4,6 +4,7 @@ class Users::RegistrationsController < Devise::RegistrationsController
                 only: %i(new create new_with_provider create_with_provider)
   before_action :sign_up_with_provider_enabled?,
                 only: %i(new_with_provider create_with_provider)
+  layout 'fluid'
 
   def avatar
     user = User.find_by_id(params[:id]) || current_user
diff --git a/app/controllers/users/settings/account/addons_controller.rb b/app/controllers/users/settings/account/addons_controller.rb
index 9b18d556a..aa4412a78 100644
--- a/app/controllers/users/settings/account/addons_controller.rb
+++ b/app/controllers/users/settings/account/addons_controller.rb
@@ -2,6 +2,7 @@ module Users
   module Settings
     module Account
       class AddonsController < ApplicationController
+        layout 'fluid'
       end
     end
   end
diff --git a/app/controllers/users/settings/account/preferences_controller.rb b/app/controllers/users/settings/account/preferences_controller.rb
index 723641a49..ef983b4c9 100644
--- a/app/controllers/users/settings/account/preferences_controller.rb
+++ b/app/controllers/users/settings/account/preferences_controller.rb
@@ -9,6 +9,7 @@ module Users
           :reset_tutorial,
           :notifications_settings
         ]
+        layout 'fluid'
 
         def index
         end
diff --git a/app/controllers/users/settings/teams_controller.rb b/app/controllers/users/settings/teams_controller.rb
index 620fcd3c5..8917cd25b 100644
--- a/app/controllers/users/settings/teams_controller.rb
+++ b/app/controllers/users/settings/teams_controller.rb
@@ -22,6 +22,8 @@ module Users
       before_action :check_create_team_permission,
                     only: %i(new create)
 
+      layout 'fluid'
+
       def index
         @user_teams =
           @user
diff --git a/app/views/users/registrations/edit.html.erb b/app/views/users/registrations/edit.html.erb
index 6ac1bd0d9..5f99d1fbd 100644
--- a/app/views/users/registrations/edit.html.erb
+++ b/app/views/users/registrations/edit.html.erb
@@ -1,14 +1,11 @@
 <% provide(:head_title, t("users.registrations.edit.head_title")) %>
 
-<%= render partial: "users/settings/navigation.html.erb" %>
+<%= render partial: "users/settings/sidebar" %>
 <div class="tab-content">
   <div class="tab-pane tab-pane-settings active" role="tabpanel">
 
     <div class="row">
-      <div class="col-xs-12 col-sm-3">
-        <%= render partial: 'users/settings/account/navigation.html.erb' %>
-      </div>
-      <div class="col-xs-12 col-sm-9">
+      <div class="col-xs-12 col-sm-12">
         <div class="row">
           <div class="col-md-4">
             <h2><%=t "users.registrations.edit.title" %></h2>
diff --git a/app/views/users/settings/_sidebar.html.erb b/app/views/users/settings/_sidebar.html.erb
new file mode 100644
index 000000000..6da85e95a
--- /dev/null
+++ b/app/views/users/settings/_sidebar.html.erb
@@ -0,0 +1,95 @@
+<%= content_for :sidebar do %>
+ <div id="slide-panel" class="visible">
+   <div class="tree">
+     <ul data-hook="user-settings-navigation-html">
+       <li>
+         <span class="tree-link line-wrap no-indent">
+           <strong title="<%= t('users.settings.sidebar.title') %>"><%= t('users.settings.sidebar.title') %></strong>
+         </span>
+       </li>
+       <!-- Account -->
+       <li class="parent_li" >
+         <span class="tree-link line-wrap no-indent">
+           <i id="triangleRight"
+              title="Expand this branch"
+              class="glyphicon glyphicon-triangle-right"
+              aria-hidden="true"
+              onclick="listToggleShow()"
+              style="<%= 'display: none;' if on_settings_account_page? %>"
+              ></i>
+           <i id="triangleDown"
+              title="Collapse this branch"
+              class="glyphicon glyphicon-triangle-right expanded"
+              aria-hidden="true"
+              onclick="listToggleHide()"
+              style="<%= 'display: none;' unless on_settings_account_page? %>"
+              ></i>
+           <% style = 'font-weight: bold;' if on_settings_account_page? %>
+           <%= link_to t("users.settings.sidebar.account"),
+                       edit_user_registration_path,
+                       style: style,
+                       data: { 'no-turbolink' => 'true' } %>
+         </span>
+
+         <ul id="accountNavigation" style="<%= 'display: none;' unless on_settings_account_page? %>">
+           <li class="<%= 'active parent_li' if on_settings_account_profile_page? %>" >
+             <span class="tree-link line-wrap first-indent">
+               <% if on_settings_account_profile_page? %>
+                 <span title="<%= t("users.settings.sidebar.account_nav.profile") %>"><%= t("users.settings.sidebar.account_nav.profile") %></span>
+               <% else %>
+                 <%= link_to t("users.settings.sidebar.account_nav.profile"),
+                             edit_user_registration_path,
+                             data: { 'no-turbolink' => 'true' } %>
+               <% end %>
+             </span>
+           </li>
+           <li class="<%= 'active parent_li' if on_settings_account_preferences_page? %>" >
+             <span class="tree-link line-wrap first-indent">
+               <% if on_settings_account_preferences_page? %>
+                 <span title="<%= t("users.settings.sidebar.account_nav.preferences") %>"><%= t("users.settings.sidebar.account_nav.preferences") %></span>
+               <% else %>
+                 <%= link_to t("users.settings.sidebar.account_nav.preferences"),
+                             preferences_path,
+                             data: { 'no-turbolink' => 'true' } %>
+               <% end %>
+             </span>
+           </li>
+           <li class="<%= 'active parent_li' if on_settings_account_addons_page? %>" >
+             <span class="tree-link line-wrap first-indent">
+               <% if on_settings_account_addons_page? %>
+                 <span title="<%= t("users.settings.sidebar.account_nav.addons") %>"><%= t("users.settings.sidebar.account_nav.addons") %></span>
+               <% else %>
+                 <%= link_to t("users.settings.sidebar.account_nav.addons"),
+                             addons_path,
+                             data: { 'no-turbolink' => 'true' } %>
+               <% end %>
+             </span>
+           </li>
+         </ul>
+       </li>
+
+       <!-- Teams -->
+       <li class="<%= 'active parent_li' if on_settings_team_page? %>" >
+         <span class="tree-link line-wrap no-indent">
+           <% if on_settings_team_page? %>
+           <span title="<%= t("users.settings.sidebar.teams") %>"><%= t("users.settings.sidebar.teams") %></span>
+           <% else %>
+             <%= link_to t("users.settings.sidebar.teams"),
+                         teams_path,
+                         data: { 'no-turbolink' => 'true' } %>
+           <% end %>
+         </span>
+       </li>
+
+     </ul>
+   </div>
+ </div>
+<% end %>
+
+<script>
+ $(document).ready(function() {
+   $('#wrapper').show();
+ })
+</script>
+
+<%= javascript_include_tag("users/settings/list_toggle") %>
diff --git a/app/views/users/settings/account/addons/index.html.erb b/app/views/users/settings/account/addons/index.html.erb
index de7c58a21..6022900b6 100644
--- a/app/views/users/settings/account/addons/index.html.erb
+++ b/app/views/users/settings/account/addons/index.html.erb
@@ -1,14 +1,11 @@
 <% provide(:head_title, t('users.settings.account.addons.head_title')) %>
 
-<%= render partial: 'users/settings/navigation.html.erb' %>
+<%= render partial: 'users/settings/sidebar.html.erb' %>
 <div class="tab-content">
   <div class="tab-pane tab-pane-settings active" role="tabpanel">
 
     <div class="row">
-      <div class="col-xs-12 col-sm-3">
-        <%= render partial: 'users/settings/account/navigation.html.erb' %>
-      </div>
-      <div class="col-xs-12 col-sm-9">
+      <div class="col-xs-12 col-sm-12">
         <h4><%= t('users.settings.account.addons.title') %></h4>
         <div data-hook="settings-addons-container">
           <em data-hook="settings-addons-no-addons">
diff --git a/app/views/users/settings/account/preferences/index.html.erb b/app/views/users/settings/account/preferences/index.html.erb
index 662caf09f..2aa0d334c 100644
--- a/app/views/users/settings/account/preferences/index.html.erb
+++ b/app/views/users/settings/account/preferences/index.html.erb
@@ -1,14 +1,11 @@
 <% provide(:head_title, t("users.settings.account.preferences.head_title")) %>
 
-<%= render partial: "users/settings/navigation.html.erb" %>
+<%= render partial: "users/settings/sidebar.html.erb" %>
 <div class="tab-content">
   <div class="tab-pane tab-pane-settings active" role="tabpanel">
 
     <div class="row">
-      <div class="col-xs-12 col-sm-3">
-        <%= render partial: 'users/settings/account/navigation.html.erb' %>
-      </div>
-      <div class="col-xs-12 col-sm-9">
+      <div class="col-xs-12 col-sm-12">
         <%= form_for(@user,
                      url: update_preferences_path(format: :json),
                      remote: true,
diff --git a/app/views/users/settings/teams/index.html.erb b/app/views/users/settings/teams/index.html.erb
index 13c749e0b..f2508f7ff 100644
--- a/app/views/users/settings/teams/index.html.erb
+++ b/app/views/users/settings/teams/index.html.erb
@@ -1,6 +1,6 @@
 <% provide(:head_title, t("users.settings.teams.head_title")) %>
 
-<%= render partial: "users/settings/navigation.html.erb" %>
+<%= render partial: "users/settings/sidebar.html.erb" %>
 <div class="tab-content">
   <div class="tab-pane tab-pane-settings" role="tabpanel"></div>
   <div class="tab-pane tab-pane-settings active" role="tabpanel">
diff --git a/app/views/users/settings/teams/new.html.erb b/app/views/users/settings/teams/new.html.erb
index 72b9967ce..9c95922c7 100644
--- a/app/views/users/settings/teams/new.html.erb
+++ b/app/views/users/settings/teams/new.html.erb
@@ -1,6 +1,6 @@
 <% provide(:head_title, t("users.settings.teams.head_title")) %>
 
-<%= render partial: "users/settings/navigation.html.erb" %>
+<%= render partial: "users/settings/sidebar.html.erb" %>
 <div class="tab-content">
   <div class="tab-pane tab-pane-settings" role="tabpanel"></div>
   <div class="tab-pane tab-pane-settings active" role="tabpanel">
diff --git a/app/views/users/settings/teams/show.html.erb b/app/views/users/settings/teams/show.html.erb
index f4cc608a2..64559af9b 100644
--- a/app/views/users/settings/teams/show.html.erb
+++ b/app/views/users/settings/teams/show.html.erb
@@ -2,7 +2,7 @@
 
 <div data-hook="team-beginning"></div>
 
-<%= render partial: "users/settings/navigation.html.erb" %>
+<%= render partial: "users/settings/sidebar.html.erb" %>
 <div class="tab-content">
   <div class="tab-pane tab-pane-settings" role="tabpanel"></div>
   <div class="tab-pane tab-pane-settings active" role="tabpanel">
diff --git a/config/initializers/assets.rb b/config/initializers/assets.rb
index 537dbec35..ee0ee4892 100644
--- a/config/initializers/assets.rb
+++ b/config/initializers/assets.rb
@@ -17,6 +17,7 @@ Rails.application.config.assets.precompile += %w(underscore.js)
 Rails.application.config.assets.precompile += %w(jsPlumb-2.0.4-min.js)
 Rails.application.config.assets.precompile += %w(jsnetworkx.js)
 Rails.application.config.assets.precompile += %w(handsontable.full.min.js)
+Rails.application.config.assets.precompile += %w(users/settings/list_toggle.js)
 Rails.application.config.assets.precompile +=
   %w(users/settings/account/preferences/index.js)
 Rails.application.config.assets.precompile += %w(users/settings/teams/index.js)
diff --git a/config/locales/en.yml b/config/locales/en.yml
index 027a0db44..a43348261 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -1329,6 +1329,14 @@ en:
       navigation:
         account: "Account"
         teams: "Teams"
+      sidebar:
+        title: "Settings"
+        account: "Account"
+        teams: "Teams"
+        account_nav:
+          profile: "Profile"
+          preferences: "Preferences"
+          addons: "Add-ons"
       account:
         navigation:
           profile: "Profile"

From 70dfe66b2ddd14c8e5bf6ab1039a83e84e3ee248 Mon Sep 17 00:00:00 2001
From: mlorb <mlorber@biosistemika.com>
Date: Fri, 6 Apr 2018 14:20:40 +0200
Subject: [PATCH 2/5] refactoring

---
 .../javascripts/users/settings/list_toggle.js | 11 --------
 .../users/settings/list_toggle.js.erb         | 18 +++++++++++++
 app/views/users/settings/_navigation.html.erb |  9 -------
 app/views/users/settings/_sidebar.html.erb    | 26 ++++++++-----------
 .../settings/account/_navigation.html.erb     | 11 --------
 config/initializers/assets.rb                 |  2 +-
 6 files changed, 30 insertions(+), 47 deletions(-)
 delete mode 100644 app/assets/javascripts/users/settings/list_toggle.js
 create mode 100644 app/assets/javascripts/users/settings/list_toggle.js.erb
 delete mode 100644 app/views/users/settings/_navigation.html.erb
 delete mode 100644 app/views/users/settings/account/_navigation.html.erb

diff --git a/app/assets/javascripts/users/settings/list_toggle.js b/app/assets/javascripts/users/settings/list_toggle.js
deleted file mode 100644
index 38d2c8610..000000000
--- a/app/assets/javascripts/users/settings/list_toggle.js
+++ /dev/null
@@ -1,11 +0,0 @@
-function listToggleShow() {
-  $('#triangleDown').show();
-  $('#triangleRight').hide();
-  $('#accountNavigation').show();
-}
-
-function listToggleHide() {
-  $('#triangleDown').hide();
-  $('#triangleRight').show();
-  $('#accountNavigation').hide();
-}
diff --git a/app/assets/javascripts/users/settings/list_toggle.js.erb b/app/assets/javascripts/users/settings/list_toggle.js.erb
new file mode 100644
index 000000000..a006dde1b
--- /dev/null
+++ b/app/assets/javascripts/users/settings/list_toggle.js.erb
@@ -0,0 +1,18 @@
+(function() {
+  'use strict';
+
+  $(".tree li.parent_li ").find("> span i").on("click", function (e) {
+    e.stopPropagation();
+    var el = $(this).closest("li.parent_li");
+
+    if (el.find(" > ul.accountNavigation").is(":visible")) {
+      el.find(" > span > i.triangleDown").hide();
+      el.find(" > span > i.triangleRight").show();
+      el.find(" > ul.accountNavigation").hide();
+    } else {
+      el.find(" > span > i.triangleDown").show();
+      el.find(" > span > i.triangleRight").hide();
+      el.find(" > ul.accountNavigation").show();
+    }
+  });
+})();
diff --git a/app/views/users/settings/_navigation.html.erb b/app/views/users/settings/_navigation.html.erb
deleted file mode 100644
index a5f481cd3..000000000
--- a/app/views/users/settings/_navigation.html.erb
+++ /dev/null
@@ -1,9 +0,0 @@
-<ul data-hook="user-settings-navigation-html"
-    class="nav nav-tabs nav-settings">
-  <li role="presentation" class="<%= 'active' if on_settings_account_page? %>">
-    <%= link_to t("users.settings.navigation.account"), edit_user_registration_path %>
-  </li>
-  <li role="presentation" class="<%= "active" if on_settings_team_page? %>">
-    <%= link_to t("users.settings.navigation.teams"), teams_path %>
-  </li>
-</ul>
diff --git a/app/views/users/settings/_sidebar.html.erb b/app/views/users/settings/_sidebar.html.erb
index 6da85e95a..de9c3c67a 100644
--- a/app/views/users/settings/_sidebar.html.erb
+++ b/app/views/users/settings/_sidebar.html.erb
@@ -10,29 +10,25 @@
        <!-- Account -->
        <li class="parent_li" >
          <span class="tree-link line-wrap no-indent">
-           <i id="triangleRight"
-              title="Expand this branch"
-              class="glyphicon glyphicon-triangle-right"
+           <i title="Expand this branch"
+              class="glyphicon glyphicon-triangle-right triangleRight"
               aria-hidden="true"
-              onclick="listToggleShow()"
               style="<%= 'display: none;' if on_settings_account_page? %>"
               ></i>
-           <i id="triangleDown"
-              title="Collapse this branch"
-              class="glyphicon glyphicon-triangle-right expanded"
+           <i title="Collapse this branch"
+              class="glyphicon glyphicon-triangle-right expanded triangleDown"
               aria-hidden="true"
-              onclick="listToggleHide()"
               style="<%= 'display: none;' unless on_settings_account_page? %>"
               ></i>
-           <% style = 'font-weight: bold;' if on_settings_account_page? %>
+           <% account_style = 'font-weight: bold;' if on_settings_account_page? %>
            <%= link_to t("users.settings.sidebar.account"),
                        edit_user_registration_path,
-                       style: style,
+                       style: account_style,
                        data: { 'no-turbolink' => 'true' } %>
          </span>
 
-         <ul id="accountNavigation" style="<%= 'display: none;' unless on_settings_account_page? %>">
-           <li class="<%= 'active parent_li' if on_settings_account_profile_page? %>" >
+         <ul class="accountNavigation" data-hook="user-settings-account-navigation-html" style="<%= 'display: none;' unless on_settings_account_page? %>">
+           <li class="<%= 'active' if on_settings_account_profile_page? %>" >
              <span class="tree-link line-wrap first-indent">
                <% if on_settings_account_profile_page? %>
                  <span title="<%= t("users.settings.sidebar.account_nav.profile") %>"><%= t("users.settings.sidebar.account_nav.profile") %></span>
@@ -43,7 +39,7 @@
                <% end %>
              </span>
            </li>
-           <li class="<%= 'active parent_li' if on_settings_account_preferences_page? %>" >
+           <li class="<%= 'active' if on_settings_account_preferences_page? %>" >
              <span class="tree-link line-wrap first-indent">
                <% if on_settings_account_preferences_page? %>
                  <span title="<%= t("users.settings.sidebar.account_nav.preferences") %>"><%= t("users.settings.sidebar.account_nav.preferences") %></span>
@@ -54,7 +50,7 @@
                <% end %>
              </span>
            </li>
-           <li class="<%= 'active parent_li' if on_settings_account_addons_page? %>" >
+           <li class="<%= 'active' if on_settings_account_addons_page? %>" >
              <span class="tree-link line-wrap first-indent">
                <% if on_settings_account_addons_page? %>
                  <span title="<%= t("users.settings.sidebar.account_nav.addons") %>"><%= t("users.settings.sidebar.account_nav.addons") %></span>
@@ -69,7 +65,7 @@
        </li>
 
        <!-- Teams -->
-       <li class="<%= 'active parent_li' if on_settings_team_page? %>" >
+       <li class="<%= 'active' if on_settings_team_page? %>" >
          <span class="tree-link line-wrap no-indent">
            <% if on_settings_team_page? %>
            <span title="<%= t("users.settings.sidebar.teams") %>"><%= t("users.settings.sidebar.teams") %></span>
diff --git a/app/views/users/settings/account/_navigation.html.erb b/app/views/users/settings/account/_navigation.html.erb
deleted file mode 100644
index efaf781db..000000000
--- a/app/views/users/settings/account/_navigation.html.erb
+++ /dev/null
@@ -1,11 +0,0 @@
-<ul class="nav nav-pills nav-stacked nav-stacked-arrow" data-hook="user-settings-account-navigation-html">
-  <li role="presentation" class="<%= 'active' if on_settings_account_profile_page? %>">
-    <%= link_to t('users.settings.account.navigation.profile'), edit_user_registration_path %>
-  </li>
-  <li role="presentation" class="<%= 'active' if on_settings_account_preferences_page? %>">
-    <%= link_to t('users.settings.account.navigation.preferences'), preferences_path %>
-  </li>
-  <li role="presentation" class="<%= 'active' if on_settings_account_addons_page? %>">
-    <%= link_to t('users.settings.account.navigation.addons'), addons_path %>
-  </li>
-</ul>
diff --git a/config/initializers/assets.rb b/config/initializers/assets.rb
index ee0ee4892..678816519 100644
--- a/config/initializers/assets.rb
+++ b/config/initializers/assets.rb
@@ -17,7 +17,7 @@ Rails.application.config.assets.precompile += %w(underscore.js)
 Rails.application.config.assets.precompile += %w(jsPlumb-2.0.4-min.js)
 Rails.application.config.assets.precompile += %w(jsnetworkx.js)
 Rails.application.config.assets.precompile += %w(handsontable.full.min.js)
-Rails.application.config.assets.precompile += %w(users/settings/list_toggle.js)
+Rails.application.config.assets.precompile += %w(users/settings/list_toggle.js.erb)
 Rails.application.config.assets.precompile +=
   %w(users/settings/account/preferences/index.js)
 Rails.application.config.assets.precompile += %w(users/settings/teams/index.js)

From 0c851f227c92700ec9c8671281629a1c818ddd65 Mon Sep 17 00:00:00 2001
From: mlorb <mlorber@biosistemika.com>
Date: Fri, 6 Apr 2018 15:00:19 +0200
Subject: [PATCH 3/5] remove unused locals

---
 config/locales/en.yml | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/config/locales/en.yml b/config/locales/en.yml
index a43348261..c82e6b248 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -1326,9 +1326,6 @@ en:
       changed_team_flash: "You are working on %{team} now!"
       changed_team_error_flash: "Something went wrong! Try again later."
       changed_team_in_search: "The searched item is not in your current team. You will be redirected to %{team} team!"
-      navigation:
-        account: "Account"
-        teams: "Teams"
       sidebar:
         title: "Settings"
         account: "Account"
@@ -1338,10 +1335,6 @@ en:
           preferences: "Preferences"
           addons: "Add-ons"
       account:
-        navigation:
-          profile: "Profile"
-          preferences: "Preferences"
-          addons: "Add-ons"
         preferences:
           head_title: "Settings | My preferences"
           edit:

From 80fe1dd73b3935ea8bc8ef92399117e370f54e43 Mon Sep 17 00:00:00 2001
From: mlorb <mlorber@biosistemika.com>
Date: Fri, 6 Apr 2018 17:16:04 +0200
Subject: [PATCH 4/5] fix travis

---
 app/controllers/users/registrations_controller.rb | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/app/controllers/users/registrations_controller.rb b/app/controllers/users/registrations_controller.rb
index 501526f4e..b50f8b9f3 100644
--- a/app/controllers/users/registrations_controller.rb
+++ b/app/controllers/users/registrations_controller.rb
@@ -4,7 +4,7 @@ class Users::RegistrationsController < Devise::RegistrationsController
                 only: %i(new create new_with_provider create_with_provider)
   before_action :sign_up_with_provider_enabled?,
                 only: %i(new_with_provider create_with_provider)
-  layout 'fluid'
+  layout :layout
 
   def avatar
     user = User.find_by_id(params[:id]) || current_user
@@ -292,6 +292,10 @@ class Users::RegistrationsController < Devise::RegistrationsController
 
   private
 
+  def layout
+    'fluid' if action_name == 'edit'
+  end
+
   def check_captcha
     if Rails.configuration.x.enable_recaptcha
       unless verify_recaptcha

From 8a35ce5c58e8bcfdca227963b192eb237383ca08 Mon Sep 17 00:00:00 2001
From: mlorb <mlorber@biosistemika.com>
Date: Mon, 9 Apr 2018 10:53:03 +0200
Subject: [PATCH 5/5] add locales

---
 app/assets/javascripts/sidebar.js.erb      | 6 +++---
 app/views/users/settings/_sidebar.html.erb | 4 ++--
 config/locales/en.yml                      | 2 ++
 3 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/app/assets/javascripts/sidebar.js.erb b/app/assets/javascripts/sidebar.js.erb
index 5fbbb2c6a..2d2558fbf 100644
--- a/app/assets/javascripts/sidebar.js.erb
+++ b/app/assets/javascripts/sidebar.js.erb
@@ -128,7 +128,7 @@ function setupSidebarTree() {
       }
       el
       .find(" > span i")
-      .attr("title", "Expand this branch")
+      .attr("title", I18n.t('sidebar.branch_expand'))
       .removeClass("expanded");
     } else {
       if (animate) {
@@ -138,7 +138,7 @@ function setupSidebarTree() {
       }
       el
       .find(" > span i")
-      .attr("title", "Collapse this branch")
+      .attr("title", I18n.t('sidebar.branch_collapse'))
       .addClass("expanded");
     }
   }
@@ -147,7 +147,7 @@ function setupSidebarTree() {
   $(".tree li:has(ul)")
   .addClass("parent_li")
   .find(" > span i")
-  .attr("title", "Collapse this branch");
+  .attr("title", I18n.t('sidebar.branch_collapse'));
   $(".tree li.parent_li ")
   .find("> span i")
   .addClass("glyphicon glyphicon-triangle-right expanded");
diff --git a/app/views/users/settings/_sidebar.html.erb b/app/views/users/settings/_sidebar.html.erb
index de9c3c67a..d27b2be12 100644
--- a/app/views/users/settings/_sidebar.html.erb
+++ b/app/views/users/settings/_sidebar.html.erb
@@ -10,12 +10,12 @@
        <!-- Account -->
        <li class="parent_li" >
          <span class="tree-link line-wrap no-indent">
-           <i title="Expand this branch"
+           <i title="<%= t('sidebar.branch_expand') %>"
               class="glyphicon glyphicon-triangle-right triangleRight"
               aria-hidden="true"
               style="<%= 'display: none;' if on_settings_account_page? %>"
               ></i>
-           <i title="Collapse this branch"
+           <i title="<%= t('sidebar.branch_collapse') %>"
               class="glyphicon glyphicon-triangle-right expanded triangleDown"
               aria-hidden="true"
               style="<%= 'display: none;' unless on_settings_account_page? %>"
diff --git a/config/locales/en.yml b/config/locales/en.yml
index c82e6b248..d2bd39433 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -111,6 +111,8 @@ en:
 
   sidebar:
     title: "Navigation"
+    branch_expand: "Expand this branch"
+    branch_collapse: "Collapse this branch"
     no_module_group: "No workflow"
     projects:
       all: "All Projects"