From a6abfc7e310dbc1f3f4746df666d7e7ce2330fa4 Mon Sep 17 00:00:00 2001
From: Ivan Kljun <ivan@scinote.net>
Date: Tue, 5 Sep 2023 13:39:21 +0200
Subject: [PATCH] Applying hound suggestions [SCI-9016]

---
 app/assets/stylesheets/protocols/protocol.scss | 6 +++---
 app/assets/stylesheets/shared/inline_edit.scss | 2 +-
 app/assets/stylesheets/steps/step.scss         | 1 -
 app/javascript/vue/shared/inline_edit.vue      | 4 ++--
 4 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/app/assets/stylesheets/protocols/protocol.scss b/app/assets/stylesheets/protocols/protocol.scss
index 1365936ac..d885a8598 100644
--- a/app/assets/stylesheets/protocols/protocol.scss
+++ b/app/assets/stylesheets/protocols/protocol.scss
@@ -129,11 +129,11 @@
         min-height: 36px;
 
         .authors-list {
-          position: relative;
-          max-width: calc(100% - 90px);
+          font-weight: bold;
           line-height: 32px;
           margin-left: 8px;
-          font-weight: bold;
+          max-width: calc(100% - 90px);
+          position: relative;
         }
 
         * {
diff --git a/app/assets/stylesheets/shared/inline_edit.scss b/app/assets/stylesheets/shared/inline_edit.scss
index 8cb687b73..036d6fdaf 100644
--- a/app/assets/stylesheets/shared/inline_edit.scss
+++ b/app/assets/stylesheets/shared/inline_edit.scss
@@ -5,7 +5,7 @@
   cursor: url("/images/icon_small/edit.svg") 0 16, auto;
 }
 
-.inline-edit-placeholder:empty:before {
+.inline-edit-placeholder:empty::before {
   content: attr(placeholder);
   display: block;
 }
diff --git a/app/assets/stylesheets/steps/step.scss b/app/assets/stylesheets/steps/step.scss
index c0c6709f5..b7c71eed5 100644
--- a/app/assets/stylesheets/steps/step.scss
+++ b/app/assets/stylesheets/steps/step.scss
@@ -221,7 +221,6 @@
   border-radius: 4px;
   display: flex;
   min-height: 40px;
-  // overflow: hidden;
   position: relative;
 
   &.editing-name {
diff --git a/app/javascript/vue/shared/inline_edit.vue b/app/javascript/vue/shared/inline_edit.vue
index 6a9cb3222..199c40a3e 100644
--- a/app/javascript/vue/shared/inline_edit.vue
+++ b/app/javascript/vue/shared/inline_edit.vue
@@ -91,10 +91,10 @@
     },
     computed: {
       isBlank() {
-        return this.newValue.length === 0
+        return this.newValue.length === 0;
       },
       isContentDefault() {
-        return this.$refs ? this.$refs.input.innerText === this.defaultValue : false;
+        return this.newValue === this.defaultValue;
       },
       error() {
         if(!this.allowBlank && this.isBlank) {