scinote-eln/scinote-web
1
1
Fork 0
mirror of https://github.com/scinote-eln/scinote-web.git synced 2024-09-21 15:36:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1289 from Zanz2/step_save_table_too_long_bug_sci2719

Browse source 
Fixed bug with table name of step not being length validated [SCI-2719]
This commit is contained in:
Zanz2 2018-09-28 14:37:08 +02:00 committed by GitHub
parent 5e797c5dae 16f9728a05
commit ada98e9eaf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 20 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
app/assets/javascripts/protocols/steps.js.erb
View file

@ -545,11 +545,29 @@
var $tinyMCEInput = TinyMCE.getContent();
var descriptionValid = textValidator(ev, $descrTextarea, 0,
<%= Constants::TEXT_MAX_LENGTH %>, false, $tinyMCEInput);
var tableNamesValidArray = [];
// iterate over table titles and validate their length
$form.find(".table_name").each(function(index , tableName) {
if (tableName.value.length > 0) {
tableNamesValidArray[index] = textValidator(ev, tableName, 1,
<%= Constants::NAME_MAX_LENGTH %> );
} else {
tableNamesValidArray[index] = true;
}
});
var tableNamesValid = true;
// passes if all table names are valid
for (var i=0;i<tableNamesValidArray.length;i++){
if(tableNamesValidArray[i] !== true){
tableNamesValid = false;
break;
}
}
if (DragNDropSteps.filesStatus() &&
checklistsValid &&
nameValid &&
descriptionValid) {
descriptionValid &&
tableNamesValid ) {
$form.find("[data-role='editable-table']").each(function() {
var hot = $(this).find(".hot").handsontable('getInstance');