From 5cc3ad6cbb49aaaeeb9a5423448c63cdeac06435 Mon Sep 17 00:00:00 2001
From: sboursen-scinote <soufiane@scinote.net>
Date: Fri, 1 Mar 2024 11:33:30 +0100
Subject: [PATCH] Truncate long names in Access modal [SCI-10273]

---
 .../vue/shared/access_modal/assign_flyout.vue         | 11 +++++------
 app/javascript/vue/shared/access_modal/edit.vue       |  9 ++++++---
 app/javascript/vue/shared/general_dropdown.vue        |  3 ++-
 app/serializers/user_assignment_serializer.rb         | 10 ++++++----
 4 files changed, 19 insertions(+), 14 deletions(-)

diff --git a/app/javascript/vue/shared/access_modal/assign_flyout.vue b/app/javascript/vue/shared/access_modal/assign_flyout.vue
index abecbd866..23735072e 100644
--- a/app/javascript/vue/shared/access_modal/assign_flyout.vue
+++ b/app/javascript/vue/shared/access_modal/assign_flyout.vue
@@ -3,7 +3,7 @@
     <div class="sci-label mb-2">
       {{ i18n.t('access_permissions.partials.new_assignments_form.grant_access') }}
     </div>
-    <GeneralDropdown @open="$emit('assigningNewUsers', true)" @close="$emit('assigningNewUsers', false)" :fieldOnlyOpen="true">
+    <GeneralDropdown @open="$emit('assigningNewUsers', true)" @close="$emit('assigningNewUsers', false)" :fieldOnlyOpen="true" :fixed-width="true">
       <template v-slot:field>
         <div class="sci-input-container-v2 left-icon">
           <input type="text" v-model="query" class="sci-input-field"
@@ -31,14 +31,13 @@
           ></MenuDropdown>
         </div>
         <perfect-scrollbar class="h-80 relative">
-          <div v-for="user in filteredUsers" :key="user.id" class="py-2 flex items-center gap-2">
+          <div v-for="user in filteredUsers" :key="user.id" class="py-2 flex items-center w-full">
             <div>
               <img :src="user.attributes.avatar_url" class="rounded-full w-8 h-8">
             </div>
-            <div>
-              {{
-                `${user.attributes.name}${user.attributes.current_user ? ` (${i18n.t('access_permissions.you')})` : ''}`
-              }}
+            <div class="truncate ml-2" :title="user.attributes.name">{{ user.attributes.name }}</div>
+            <div v-if="user.attributes.current_user" class="text-nowrap">
+              {{ `(${i18n.t('access_permissions.you')})` }}
             </div>
             <MenuDropdown
               class="ml-auto"
diff --git a/app/javascript/vue/shared/access_modal/edit.vue b/app/javascript/vue/shared/access_modal/edit.vue
index f945092d9..d3ecbc566 100644
--- a/app/javascript/vue/shared/access_modal/edit.vue
+++ b/app/javascript/vue/shared/access_modal/edit.vue
@@ -31,10 +31,13 @@
         <div>
           <img :src="userAssignment.attributes.user.avatar_url" class="rounded-full w-8 h-8">
         </div>
-        <div>
-          <div>{{ userAssignment.attributes.user.name }}</div>
-          <div class="text-xs text-sn-grey">{{ userAssignment.attributes.inherit_message }}</div>
+        <div class="truncate"
+             :title="userAssignment.attributes.user.name"
+        >{{ userAssignment.attributes.user.name }}</div>
+        <div v-if="userAssignment.attributes.current_user" class="text-nowrap">
+          {{ `(${i18n.t('access_permissions.you')})` }}
         </div>
+        <div class="text-xs text-sn-grey text-nowrap">{{ userAssignment.attributes.inherit_message }}</div>
         <MenuDropdown
           v-if="!userAssignment.attributes.last_owner && params.object.urls.update_access"
           class="ml-auto"
diff --git a/app/javascript/vue/shared/general_dropdown.vue b/app/javascript/vue/shared/general_dropdown.vue
index e6f167bd6..5496f690e 100644
--- a/app/javascript/vue/shared/general_dropdown.vue
+++ b/app/javascript/vue/shared/general_dropdown.vue
@@ -36,7 +36,8 @@ export default {
     caret: { type: Boolean, default: false },
     alwaysShow: { type: Boolean, default: false },
     closeDropdown: { type: Boolean, default: false },
-    fieldOnlyOpen: { type: Boolean, default: false }
+    fieldOnlyOpen: { type: Boolean, default: false },
+    fixedWidth: { type: Boolean, default: false }
   },
   data() {
     return {
diff --git a/app/serializers/user_assignment_serializer.rb b/app/serializers/user_assignment_serializer.rb
index a52dc624c..4b86670e1 100644
--- a/app/serializers/user_assignment_serializer.rb
+++ b/app/serializers/user_assignment_serializer.rb
@@ -5,6 +5,7 @@ class UserAssignmentSerializer < ActiveModel::Serializer
   include Rails.application.routes.url_helpers
 
   attributes :id, :assigned, :assignable_type, :user, :user_role, :last_owner, :inherit_message
+  attribute :current_user
 
   def assigned
     parent_assignment(parent).assigned
@@ -15,16 +16,17 @@ class UserAssignmentSerializer < ActiveModel::Serializer
   end
 
   def user
-    current_user = instance_options[:user]
-    name = object.user.name
-    name += " (#{I18n.t('access_permissions.you')})" if current_user == object.user
     {
       id: object.user.id,
-      name: name,
+      name: object.user.name,
       avatar_url: avatar_path(object.user, :icon_small)
     }
   end
 
+  def current_user
+    instance_options[:user].id == object.user.id
+  end
+
   def user_role
     {
       id: object.user_role.id,