diff --git a/app/assets/javascripts/reports/new.js.erb b/app/assets/javascripts/reports/new.js.erb index bec695d9a..d29903351 100644 --- a/app/assets/javascripts/reports/new.js.erb +++ b/app/assets/javascripts/reports/new.js.erb @@ -203,12 +203,6 @@ function initializeNewElement(newEl) { url = dh.data("add-experiment-contents-url"); break; case "my_module": url = dh.data("add-module-contents-url"); break; - case "step": - url = dh.data("add-step-contents-url"); break; - case "result_asset": - case "result_table": - case "result_text": - url = dh.data("add-result-contents-url"); break; } } diff --git a/app/assets/stylesheets/reports.scss b/app/assets/stylesheets/reports.scss index b97332e3b..b4cf5fde8 100644 --- a/app/assets/stylesheets/reports.scss +++ b/app/assets/stylesheets/reports.scss @@ -46,9 +46,10 @@ // Modal for adding content label { - &[for="_module_content_all"], - &[for="_step_content_all"], - &[for="result_content_all"] { + &[for="_experiment_all"], + &[for="_module_all"], + &[for="_step_all"], + &[for="result_all"] { font-weight: bold; } } diff --git a/app/controllers/concerns/report_actions.rb b/app/controllers/concerns/report_actions.rb index 6b0653738..c66e7ac13 100644 --- a/app/controllers/concerns/report_actions.rb +++ b/app/controllers/concerns/report_actions.rb @@ -70,8 +70,9 @@ module ReportActions def generate_module_contents_json(my_module) res = [] ReportExtends::MODULE_CONTENTS.each do |contents| - protocol = contents.element == :step ? my_module.protocol.present? : true - next unless in_params?("module_#{contents.element}".to_sym) && protocol + protocol = contents.element == :steps ? my_module.protocol.present? : true + next unless (in_params?("module_#{contents.element}".to_sym) || + in_params?('#{contents.element}'.to_sym)) && protocol if contents.children contents.collection(my_module).each do |report_el| res << generate_new_el(false) @@ -82,9 +83,9 @@ module ReportActions .singularize}_element.html.erb", contents.parse_locals([report_el]) ) - if contents.locals.first == :step + if :step.in? contents.locals el[:children] = generate_step_contents_json(report_el) - elsif contents.locals.first == :result + elsif :result.in? contents.locals el[:children] = generate_result_contents_json(report_el) end res << el diff --git a/app/controllers/reports_controller.rb b/app/controllers/reports_controller.rb index 9c33a4512..4b0c922b9 100644 --- a/app/controllers/reports_controller.rb +++ b/app/controllers/reports_controller.rb @@ -21,12 +21,8 @@ class ReportsController < ApplicationController :project_contents_modal, :experiment_contents_modal, :module_contents_modal, - :step_contents_modal, - :result_contents_modal, :project_contents, - :module_contents, - :step_contents, - :result_contents + :module_contents ] before_action :check_view_permissions, only: :index @@ -40,12 +36,8 @@ class ReportsController < ApplicationController :project_contents_modal, :experiment_contents_modal, :module_contents_modal, - :step_contents_modal, - :result_contents_modal, :project_contents, - :module_contents, - :step_contents, - :result_contents + :module_contents ] before_action :check_destroy_permissions, only: :destroy @@ -275,50 +267,6 @@ class ReportsController < ApplicationController end end - # Modal for adding contents into step element - def step_contents_modal - step = Step.find_by_id(params[:id]) - - respond_to do |format| - if step.blank? - format.json do - render json: {}, status: :not_found - end - else - format.json do - render json: { - html: render_to_string( - partial: 'reports/new/modal/step_contents.html.erb', - locals: { project: @project, step: step } - ) - } - end - end - end - end - - # Modal for adding contents into result element - def result_contents_modal - result = Result.find_by_id(params[:id]) - - respond_to do |format| - if result.blank? - format.json do - render json: {}, status: :not_found - end - else - format.json do - render json: { - html: render_to_string( - partial: 'reports/new/modal/result_contents.html.erb', - locals: { project: @project, result: result } - ) - } - end - end - end - end - def project_contents respond_to do |format| elements = generate_project_contents_json @@ -387,51 +335,6 @@ class ReportsController < ApplicationController end end - def step_contents - step = Step.find_by_id(params[:id]) - - respond_to do |format| - if step.blank? - format.json { render json: {}, status: :not_found } - else - elements = generate_step_contents_json(step) - - if elements_empty? elements - format.json { render json: {}, status: :no_content } - else - format.json { - render json: { - status: :ok, - elements: elements - } - } - end - end - end - end - - def result_contents - result = Result.find_by_id(params[:id]) - respond_to do |format| - if result.blank? - format.json { render json: {}, status: :not_found } - else - elements = generate_result_contents_json(result) - - if elements_empty? elements - format.json { render json: {}, status: :no_content } - else - format.json { - render json: { - status: :ok, - elements: elements - } - } - end - end - end - end - private def load_vars diff --git a/app/views/reports/new.html.erb b/app/views/reports/new.html.erb index 41c43a58f..69eb41ced 100644 --- a/app/views/reports/new.html.erb +++ b/app/views/reports/new.html.erb @@ -13,8 +13,6 @@ data-add-project-contents-url="<%= project_contents_modal_project_reports_url %>" data-add-experiment-contents-url="<%= experiment_contents_modal_project_reports_url %>" data-add-module-contents-url="<%= module_contents_modal_project_reports_url %>" - data-add-step-contents-url="<%= step_contents_modal_project_reports_url %>" - data-add-result-contents-url="<%= result_contents_modal_project_reports_url %>" data-stylesheet-url="<%= stylesheet_path "application" %>" data-print-title="<%=t "projects.reports.print_title", project: @project.name %>" data-project-id="<%= @project.id %>" diff --git a/app/views/reports/new/modal/_experiment_contents_inner.html.erb b/app/views/reports/new/modal/_experiment_contents_inner.html.erb index d3bca577f..2d9a32173 100644 --- a/app/views/reports/new/modal/_experiment_contents_inner.html.erb +++ b/app/views/reports/new/modal/_experiment_contents_inner.html.erb @@ -8,7 +8,7 @@