scinote-eln/scinote-web
1
1
Fork 0
mirror of https://github.com/scinote-eln/scinote-web.git synced 2025-01-31 03:59:51 +08:00
Code Issues Projects Releases Packages Wiki Activity

Refactor hardcoded protocol_source in SearchService

Browse source
This commit is contained in:
Jure Grabnar 2019-06-28 02:26:31 +02:00
parent 9be4fc2470
commit bc4b07cc0f
3 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
app/controllers/external_protocols_controller.rb
View file

@ -7,7 +7,8 @@ class ExternalProtocolsController < ApplicationController
# GET list_external_protocols # GET list_external_protocols
def index def index
service_call = ProtocolImporters::SearchProtocolsService service_call = ProtocolImporters::SearchProtocolsService
.call(protocol_source: 'protocolsio/v3', query_params: index_params) .call(protocol_source: index_params[:protocol_source],
query_params: index_params)
if service_call.succeed? if service_call.succeed?
render json: { render json: {

2
app/services/protocol_importers/search_protocols_service.rb
View file

@ -11,7 +11,7 @@ module ProtocolImporters
def initialize(protocol_source:, query_params: {}) def initialize(protocol_source:, query_params: {})
@protocol_source = protocol_source @protocol_source = protocol_source
@query_params = query_params @query_params = query_params.except(:protocol_source)
@errors = Hash.new { |h, k| h[k] = {} } @errors = Hash.new { |h, k| h[k] = {} }
end end

1
app/views/protocols/index/_external_protocols_tab.html.erb
View file

@ -9,6 +9,7 @@
<%= image_tag 'external_protocols/protocolsio_logo.png', <%= image_tag 'external_protocols/protocolsio_logo.png',
class: 'protocolsio-logo' %> class: 'protocolsio-logo' %>
<span class='protocolsio-title'><%= t('protocols.index.external_protocols.protocolsio_title') %></span> <span class='protocolsio-title'><%= t('protocols.index.external_protocols.protocolsio_title') %></span>
<%= hidden_field_tag 'protocol_source', 'protocolsio/v3' %>
</div> </div>
<div class='input-group'> <div class='input-group'>