fix failing tests

This commit is contained in:
mlorb 2017-12-14 10:52:13 +01:00
parent 2936770c01
commit bd7eda1506
3 changed files with 4 additions and 2 deletions

View file

@ -49,6 +49,7 @@ module ClientApi
private
def check_leave_team_permission
return unless params[:user_team]
user_team = UserTeam.find_by_id(params[:user_team])
unless current_user == user_team.user || can_read_team?(user_team.team)
respond_422(t('client_api.permission_error'))

View file

@ -24,6 +24,7 @@ module ClientApi
end
def update_role!
raise ClientApi::CustomUserTeamError if user_cant_leave?
unless @role
raise ClientApi::CustomUserTeamError,
I18n.t('client_api.generic_error_message')

View file

@ -35,10 +35,10 @@ describe ClientApi::Users::UserTeamsController, type: :controller do
describe 'POST #update_role' do
it 'should return HTTP success if user can leave the team' do
user_team_two = create :user_team, team: team, user: user_two, role: 2
create :user_team, team: team, user: user_two, role: 2
post :update_role,
params: { team: team.id,
user_team: user_team_two.id,
user_team: user_team.id,
role: 'normal_user' },
format: :json
expect(response).to be_success