mirror of
https://github.com/scinote-eln/scinote-web.git
synced 2024-09-20 23:16:15 +08:00
fix failing tests
This commit is contained in:
parent
2936770c01
commit
bd7eda1506
|
@ -49,6 +49,7 @@ module ClientApi
|
|||
private
|
||||
|
||||
def check_leave_team_permission
|
||||
return unless params[:user_team]
|
||||
user_team = UserTeam.find_by_id(params[:user_team])
|
||||
unless current_user == user_team.user || can_read_team?(user_team.team)
|
||||
respond_422(t('client_api.permission_error'))
|
||||
|
|
|
@ -24,6 +24,7 @@ module ClientApi
|
|||
end
|
||||
|
||||
def update_role!
|
||||
raise ClientApi::CustomUserTeamError if user_cant_leave?
|
||||
unless @role
|
||||
raise ClientApi::CustomUserTeamError,
|
||||
I18n.t('client_api.generic_error_message')
|
||||
|
|
|
@ -35,10 +35,10 @@ describe ClientApi::Users::UserTeamsController, type: :controller do
|
|||
|
||||
describe 'POST #update_role' do
|
||||
it 'should return HTTP success if user can leave the team' do
|
||||
user_team_two = create :user_team, team: team, user: user_two, role: 2
|
||||
create :user_team, team: team, user: user_two, role: 2
|
||||
post :update_role,
|
||||
params: { team: team.id,
|
||||
user_team: user_team_two.id,
|
||||
user_team: user_team.id,
|
||||
role: 'normal_user' },
|
||||
format: :json
|
||||
expect(response).to be_success
|
||||
|
|
Loading…
Reference in a new issue