scinote-eln/scinote-web
1
1
Fork 0
mirror of https://github.com/scinote-eln/scinote-web.git synced 2025-11-01 00:56:05 +08:00
Code Issues Projects Releases Packages Wiki Activity

Improve representation of tags empty state on tasks [SCI-12457]

Browse source
This commit is contained in:
Oleksii Kriuchykhin 2025-10-15 10:43:45 +02:00
parent f43d5cd66e
commit c09dfec146
4 changed files with 16 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
app/javascript/vue/my_module/details.vue
View file

@ -84,7 +84,7 @@
</span>
<div class="w-56" data-e2e="e2e-DP-task-details-startDate">
<DateTimePicker
v-if="myModule.attributes.permissions.manage_due_date"
v-if="myModule.attributes.permissions.manage_start_date"
@change="setStartDate"
:defaultValue="startDate"
mode="datetime"
@ -98,7 +98,7 @@
/>
<div v-else class="ml-2 py-2">
<span v-if="myModule.attributes.start_date_cell.value_formatted" class="font-bold">{{ myModule.attributes.start_date_cell.value_formatted }}</span>
<span v-else class="text-sn-grey">{{ i18n.t('my_modules.details.no_due_date') }}</span>
<span v-else class="text-sn-grey">{{ i18n.t('my_modules.details.no_start_date') }}</span>
</div>
</div>
</div>
@ -153,12 +153,13 @@
:placeholder="i18n.t('experiments.canvas.new_my_module_modal.assigned_users_placeholder')"
:tagsView="true">
</SelectDropdown>
<div v-else class="flex items-center flex-wrap gap-2 mt-2.5">
<div v-else-if="selectedUsers.length > 0" class="flex items-center flex-wrap gap-2 mt-2.5">
<div class="sci-tag bg-sn-super-light-grey" v-for="user in selectedUsers" :key="user.id">
<img :src="user.attributes.avatar_url" class="rounded-full w-5 h-5" />
<span :title="user.attributes.name" class="truncate">{{ user.attributes.name }}</span>
</div>
</div>
<span v-else class="flex items-center flex-wrap gap-2 mt-2.5 text-sn-grey">{{ i18n.t('my_modules.details.no_assigned_users') }}</span>
</div>
</div>
<div class="flex gap-2 mb-6 mt-2.5">
@ -166,8 +167,11 @@
<span class="tw-hidden lg:block shrink-0">
{{ i18n.t('my_modules.details.tags') }}
</span>
<div class="grow -mt-1.5" data-e2e="e2e-IF-task-details-tags">
<TagsInput :subject="myModule" :key="detailsKey" v-if="myModule" @reloadSubject="$emit('reloadMyModule')" />
<div class="grow -mt-1.5" data-e2e="e2e-IF-task-details-tags">
<TagsInput :subject="myModule" :key="detailsKey" v-if="myModule.attributes.permissions.assign_tags || myModule.attributes.tags.length > 0" @reloadSubject="$emit('reloadMyModule')" />
<div v-else class="ml-2 py-2">
<span class="text-sn-grey">{{ i18n.t('my_modules.details.no_tags') }}</span>
</div>
</div>
</div>
</div>

2
app/javascript/vue/shared/general_dropdown.vue
View file

@ -1,6 +1,6 @@
<template>
<div class="relative" v-click-outside="closeMenu" >
<div ref="field" class="cursor-pointer" @click.stop="toggleMenu">
<div ref="field" :class="{ 'cursor-pointer': canOpen }" @click.stop="toggleMenu">
<slot name="field"></slot>
</div>
<template v-if="isOpen">

2
app/views/my_module_tags/_index_edit.html.erb
View file

@ -1,7 +1,7 @@
<%= hidden_field_tag :tags_modal_my_module_id, @my_module.id %>
<h5><%=t "experiments.canvas.modal_manage_tags.subtitle", module: @my_module.name %></h5>
<% if @my_module_tags.size == 0 then %>
<div class="row"><div class="col-xs-4"><em><%= t 'experiments.canvas.modal_manage_tags.no_tags' %></em></div></div>
<div class="row"><div class="col-xs-4"><em><%= t 'experiments.canvas.modal_manage_tags.add_tags' %></em></div></div>
<% else %>
<ul class="list-group">
<% @my_module_tags.each_with_index do |mmt, i| tag = mmt.tag %>

8
config/locales/en.yml
View file

@ -1440,17 +1440,19 @@ en:
modified_value_without_user: "%{date}"
view_task_access: "Access"
start_date: "Start date:"
no_start_date: "No start date"
no_start_date_placeholder: "+ Add starting date"
due_date: "Due date:"
completed_date: "Completed date:"
no_due_date_placeholder: "+ Add due date"
overdue: "Overdue"
due_soon: "Due soon"
no_due_date: "not set"
no_due_date: "No due date"
assigned_users: "Assigned to:"
no_assigned_users: "+ Assign task to a project member"
no_assigned_users: "No assigned project member"
tags: "Tags:"
no_tags: "+ Add tags"
add_tags: "+ Add tags"
no_tags: "No tags"
manage_tags: "Manage tags"
create_new_tag: "→ Create new"
recent_protocols_from_repository: "Recent protocols from the Repository"