From c2eb0f18c7907f00e145f9b07e8e261ae0a9bf05 Mon Sep 17 00:00:00 2001 From: sboursen-scinote Date: Tue, 23 Apr 2024 13:09:05 +0200 Subject: [PATCH] Remove name validation flash errors in inline-editing [SCI-10338] --- app/assets/javascripts/shared/inline_editing.js | 6 ++++-- app/controllers/experiments_controller.rb | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/app/assets/javascripts/shared/inline_editing.js b/app/assets/javascripts/shared/inline_editing.js index 657fe46a4..66e9c73ad 100644 --- a/app/assets/javascripts/shared/inline_editing.js +++ b/app/assets/javascripts/shared/inline_editing.js @@ -108,8 +108,10 @@ let inlineEditing = (function() { if (response.status === 403) { HelperModule.flashAlertMsg(I18n.t('general.no_permissions'), 'danger'); } else if (response.status === 422) { - HelperModule.flashAlertMsg(response.responseJSON.errors - ? Object.values(response.responseJSON.errors).join(', ') : I18n.t('errors.general'), 'danger'); + const errors = response.responseJSON.errors || response.responseJSON; + if (!errors) { + HelperModule.flashAlertMsg(I18n.t('errors.general'), 'danger'); + } } if (!error) error = response.responseJSON.errors[fieldToUpdate]; container.addClass('error'); diff --git a/app/controllers/experiments_controller.rb b/app/controllers/experiments_controller.rb index 96c6e3d1e..5d4046fc7 100644 --- a/app/controllers/experiments_controller.rb +++ b/app/controllers/experiments_controller.rb @@ -116,7 +116,7 @@ class ExperimentsController < ApplicationController render json: { message: t('experiments.update.success_flash', experiment: @experiment.name) }, status: :ok else - render json: { message: @experiment.errors.full_messages }, status: :unprocessable_entity + render json: { errors: @experiment.errors }, status: :unprocessable_entity end end