From 47daae5b261583870c76a59c33d465298a0b67d3 Mon Sep 17 00:00:00 2001 From: sboursen-scinote Date: Tue, 27 Feb 2024 21:00:11 +0100 Subject: [PATCH] Show repositories that don't contain any items in the list [SCI-10286] --- app/services/lists/base_service.rb | 4 ++++ app/services/lists/repositories_service.rb | 14 +++++--------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/app/services/lists/base_service.rb b/app/services/lists/base_service.rb index 6240564d7..7698aa541 100644 --- a/app/services/lists/base_service.rb +++ b/app/services/lists/base_service.rb @@ -20,6 +20,10 @@ module Lists private + def fetch_records + raise NotImplementedError + end + def order_params @order_params ||= @params.require(:order).permit(:column, :dir).to_h end diff --git a/app/services/lists/repositories_service.rb b/app/services/lists/repositories_service.rb index 69eecf495..a7e348138 100644 --- a/app/services/lists/repositories_service.rb +++ b/app/services/lists/repositories_service.rb @@ -5,15 +5,11 @@ module Lists private def fetch_records - @records = @raw_data.joins( - 'LEFT OUTER JOIN users AS creators ' \ - 'ON repositories.created_by_id = creators.id' - ) - .joins( - 'LEFT OUTER JOIN users AS archivers ' \ - 'ON repositories.archived_by_id = archivers.id' - ) - .joins(:repository_rows) + @records = @raw_data.joins('LEFT OUTER JOIN users AS creators ' \ + 'ON repositories.created_by_id = creators.id') + .joins('LEFT OUTER JOIN users AS archivers ' \ + 'ON repositories.archived_by_id = archivers.id') + .left_outer_joins(:repository_rows) .joins(:team) .select('repositories.*') .select('MAX(teams.name) AS team_name')