scinote-eln/scinote-web
1
1
Fork 0
mirror of https://github.com/scinote-eln/scinote-web.git synced 2025-11-08 07:21:03 +08:00
Code Issues Projects Releases Packages Wiki Activity

Fix bug in new result table event delegation [SCI-9057]

Browse source
This commit is contained in:
wandji20 2023-08-18 07:16:01 +01:00
parent 67042ce254
commit cf3cb707fd
3 changed files with 13 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
app/assets/javascripts/results/result_tables.js.erb
View file

@ -65,8 +65,15 @@
} }
// Save result table callback // Save result table callback
function resultTableCallback () { function newResultTableCallback() {
$('result-tables-buttons').on('click', '.save-result', (event) => { $('.new-result-tables-buttons .save-result').on('click', (event) => {
Results.processResult(event, Results.ResultTypeEnum.TABLE);
});
}
// Save result table callback
function saveResultTableCallback() {
$('.edit-result-tables-buttons .save-result').on('click', (event) => {
Results.processResult(event, Results.ResultTypeEnum.TABLE); Results.processResult(event, Results.ResultTypeEnum.TABLE);
}); });
} }
@ -87,7 +94,6 @@
Results.expandResult($result); Results.expandResult($result);
Comments.init(); Comments.init();
initNewResultTable(); initNewResultTable();
resultTableCallback();
}); });
$form.on('ajax:error', function(e, xhr, status, error) { $form.on('ajax:error', function(e, xhr, status, error) {
var data = xhr.responseJSON; var data = xhr.responseJSON;
@ -119,7 +125,7 @@
Results.toggleResultEditButtons(false); Results.toggleResultEditButtons(false);
$('#result_name').focus(); $('#result_name').focus();
resultTableCallback(); saveResultTableCallback();
}); });
} }
@ -146,6 +152,7 @@
Results.initCancelFormButton($form, initNewResultTable); Results.initCancelFormButton($form, initNewResultTable);
Results.toggleResultEditButtons(false); Results.toggleResultEditButtons(false);
$('#result_name').focus(); $('#result_name').focus();
newResultTableCallback();
}, },
error: function() { error: function() {
animateSpinner(null, false); animateSpinner(null, false);

2
app/views/result_tables/_edit.html.erb
View file

@ -14,7 +14,7 @@
<% end %> <% end %>
</div> </div>
<hr> <hr>
<div class="align-right result-tables-buttons"> <div class="align-right edit-result-tables-buttons">
<button type="button" class="btn btn-secondary cancel-edit"> <button type="button" class="btn btn-secondary cancel-edit">
<%= t("general.cancel")%> <%= t("general.cancel")%>
</button> </button>

2
app/views/result_tables/_new.html.erb
View file

@ -13,7 +13,7 @@
</div> </div>
<% end %> <% end %>
</div> </div>
<div class="align-right result-tables-buttons"> <div class="align-right new-result-tables-buttons">
<button type="button" class="btn btn-secondary cancel-new"> <button type="button" class="btn btn-secondary cancel-new">
<%= t("general.cancel")%> <%= t("general.cancel")%>
</button> </button>