diff --git a/app/views/reports/new/modal/_experiment_contents.html.erb b/app/views/reports/new/modal/_experiment_contents.html.erb index 3f9b23caf..8ff3453be 100644 --- a/app/views/reports/new/modal/_experiment_contents.html.erb +++ b/app/views/reports/new/modal/_experiment_contents.html.erb @@ -3,80 +3,34 @@
-
+
+
<%= t("projects.reports.elements.modals.project_contents.tasks_tab") %>
<%= render partial: "reports/new/modal/experiment_contents_inner.html.erb", locals: { form: f, experiment: experiment } %>
-
+
+
<%= t("projects.reports.elements.modals.project_contents.content_tab") %>
<%= render partial: "reports/new/modal/module_contents_inner.html.erb", locals: { form: f } %> -
-
+
<%= render partial: "reports/new/modal/step_contents_inner.html.erb", locals: { form: f } %> -
-
+
<%= render partial: "reports/new/modal/result_contents_inner.html.erb", locals: { form: f } %>
<% end %> - - diff --git a/app/views/reports/new/modal/_experiment_contents_inner.html.erb b/app/views/reports/new/modal/_experiment_contents_inner.html.erb index 715ce102d..d3bca577f 100644 --- a/app/views/reports/new/modal/_experiment_contents_inner.html.erb +++ b/app/views/reports/new/modal/_experiment_contents_inner.html.erb @@ -4,30 +4,37 @@
-<% if experiment.my_modules.count > 0 %> - <%= form.check_box :experiment, label: experiment.name, class: "experiment-all-cb" %> - +
<% else %>
diff --git a/app/views/reports/new/modal/_module_contents.html.erb b/app/views/reports/new/modal/_module_contents.html.erb index f4536923a..72ff1f96e 100644 --- a/app/views/reports/new/modal/_module_contents.html.erb +++ b/app/views/reports/new/modal/_module_contents.html.erb @@ -3,56 +3,24 @@
-
- <%= render partial: "reports/new/modal/module_contents_inner.html.erb", locals: { form: f, my_module: my_module } %> -
-
+
+
<%= t("projects.reports.elements.modals.project_contents.content_tab") %>
+ <%= render partial: "reports/new/modal/module_contents_inner.html.erb", locals: { form: f } %> +
<%= render partial: "reports/new/modal/step_contents_inner.html.erb", locals: { form: f } %> -
-
+
<%= render partial: "reports/new/modal/result_contents_inner.html.erb", locals: { form: f } %>
<% end %> - - diff --git a/app/views/reports/new/modal/_module_contents_inner.html.erb b/app/views/reports/new/modal/_module_contents_inner.html.erb index 3785932bf..fd40d53c3 100644 --- a/app/views/reports/new/modal/_module_contents_inner.html.erb +++ b/app/views/reports/new/modal/_module_contents_inner.html.erb @@ -12,7 +12,7 @@ <%= form.check_box :module_content_all, label: t("projects.reports.elements.modals.module_contents_inner.check_all") %>
    - <% if my_module_undefined or my_module.protocol.steps.count > 0 %> + <% if my_module_undefined or my_module.protocol.steps.present? %>
  • <%= form.check_box :module_steps, label: t("projects.reports.elements.modals.module_contents_inner.steps") %>
  • @@ -26,24 +26,24 @@ <% if my_module_undefined or (my_module.results.select { |r| r.active? }).present? %>
  • - <%= form.check_box :module_results, label: t("projects.reports.elements.modals.module_contents_inner.results"), class: "results-all" %> + <%= form.check_box :module_results, label: t("projects.reports.elements.modals.module_contents_inner.results") %>
      - <% if my_module_undefined or (my_module.results.select { |r| r.is_asset && r.active? }).count > 0 %> + <% if my_module_undefined or (my_module.results.select { |r| r.is_asset && r.active? }).present? %>
    • - <%= form.check_box :module_result_assets, label: t("projects.reports.elements.modals.module_contents_inner.result_assets"), class: "result-cb" %> + <%= form.check_box :module_result_assets, label: t("projects.reports.elements.modals.module_contents_inner.result_assets") %>
    • <% end %> - <% if my_module_undefined or (my_module.results.select { |r| r.is_table && r.active? }).count > 0 %> + <% if my_module_undefined or (my_module.results.select { |r| r.is_table && r.active? }).present? %>
    • - <%= form.check_box :module_result_tables, label: t("projects.reports.elements.modals.module_contents_inner.result_tables"), class: "result-cb" %> + <%= form.check_box :module_result_tables, label: t("projects.reports.elements.modals.module_contents_inner.result_tables") %>
    • <% end %> - <% if my_module_undefined or (my_module.results.select { |r| r.is_text && r.active? }).count > 0 %> + <% if my_module_undefined or (my_module.results.select { |r| r.is_text && r.active? }).present? %>
    • - <%= form.check_box :module_result_texts, label: t("projects.reports.elements.modals.module_contents_inner.result_texts"), class: "result-cb" %> + <%= form.check_box :module_result_texts, label: t("projects.reports.elements.modals.module_contents_inner.result_texts") %>
    • <% end %> diff --git a/app/views/reports/new/modal/_project_contents.html.erb b/app/views/reports/new/modal/_project_contents.html.erb index a5a505509..ab230fec6 100644 --- a/app/views/reports/new/modal/_project_contents.html.erb +++ b/app/views/reports/new/modal/_project_contents.html.erb @@ -9,7 +9,7 @@ - <% if project.project_my_modules.is_archived(false).count > 0 %> + <% if project.project_my_modules.is_archived(false).present? %>
    • @@ -25,22 +25,20 @@
      <%= t("projects.reports.elements.modals.project_contents.tasks_tab") %>
      <%= render partial: "reports/new/modal/project_contents_inner.html.erb", locals: { form: f, project: project } %>
- <% if project.project_my_modules.is_archived(false).count > 0 %> -
-
<%= t("projects.reports.elements.modals.project_contents.content_tab") %>
- <%= render partial: "reports/new/modal/module_contents_inner.html.erb", locals: { form: f } %> -
- <%= render partial: "reports/new/modal/step_contents_inner.html.erb", locals: { form: f } %> -
- <%= render partial: "reports/new/modal/result_contents_inner.html.erb", locals: { form: f } %> -
- <% end %> +
+
<%= t("projects.reports.elements.modals.project_contents.content_tab") %>
+ <%= render partial: "reports/new/modal/module_contents_inner.html.erb", locals: { form: f } %> +
+ <%= render partial: "reports/new/modal/step_contents_inner.html.erb", locals: { form: f } %> +
+ <%= render partial: "reports/new/modal/result_contents_inner.html.erb", locals: { form: f } %> +
<% end %> diff --git a/app/views/reports/new/modal/_project_contents_inner.html.erb b/app/views/reports/new/modal/_project_contents_inner.html.erb index 600d6a4f4..1d998e549 100644 --- a/app/views/reports/new/modal/_project_contents_inner.html.erb +++ b/app/views/reports/new/modal/_project_contents_inner.html.erb @@ -10,11 +10,13 @@
  • <%= form.check_box :project, label: project.name %>
      + <% project.experiments.is_archived(false).each do |experiment| %> <% next unless experiment.my_modules.is_archived(false).present? %>
    • <%= form.check_box "experiment_#{experiment.id}", label: experiment.name %>
        + <% experiment.my_module_groups.each do |my_module_group| %> <% next unless my_module_group.my_modules.is_archived(false).present? %> <% my_module_group.ordered_modules.is_archived(false).each do |my_module| %> @@ -33,9 +35,11 @@ <% end %> <% end %> +
    • <% end %> +
  • diff --git a/app/views/reports/new/modal/_result_contents_inner.html.erb b/app/views/reports/new/modal/_result_contents_inner.html.erb index b3dc03c16..d71992ec9 100644 --- a/app/views/reports/new/modal/_result_contents_inner.html.erb +++ b/app/views/reports/new/modal/_result_contents_inner.html.erb @@ -6,7 +6,7 @@
      -
    • +
    • <%= form.label :result_content_all, t("projects.reports.elements.modals.result_contents_inner.check_all"), class: "checkbox" %>
        diff --git a/app/views/reports/new/modal/_step_contents.html.erb b/app/views/reports/new/modal/_step_contents.html.erb index d0a09d29b..c591d6244 100644 --- a/app/views/reports/new/modal/_step_contents.html.erb +++ b/app/views/reports/new/modal/_step_contents.html.erb @@ -1,19 +1,4 @@ <%= bootstrap_form_tag remote: true, url: step_contents_project_reports_path(project, format: :json), method: :post, html: { id: "add-contents-form" } do |f| %> <%= hidden_field_tag :id, step.id %> - <%= render partial: "reports/new/modal/step_contents_inner.html.erb", locals: { form: f, step: step } %> <% end %> - - diff --git a/config/locales/en.yml b/config/locales/en.yml index 7ceb85c7c..37589f4c4 100644 --- a/config/locales/en.yml +++ b/config/locales/en.yml @@ -292,7 +292,7 @@ en: instructions: "Choose what information from task/s to include in the report" check_all: "All tasks content" steps: "Completed protocol steps" - no_steps: "Task contains no protocols" + no_steps: "Task has no steps" results: "Results" result_assets: "Files" result_tables: "Tables"