Remove check for database in migrations [SCI-11213]

db/migrate/20151021082639_add_pg_trgm_support.rb

@@ -3,8 +3,6 @@ include DatabaseHelper
 
 class AddPgTrgmSupport < ActiveRecord::Migration[4.2]
   def up
-    if db_adapter_is? "PostgreSQL" then
+    enable_extension :pg_trgm
-      enable_extension :pg_trgm
-    end
   end
 end

db/migrate/20151021085335_add_search_query_indexes.rb

@@ -12,18 +12,16 @@ class AddSearchQueryIndexes < ActiveRecord::Migration[4.2]
 
     # Add GIST trigram indexes onto columns that check for
     # ILIKE %pattern% during search
-    if db_adapter_is? "PostgreSQL" then
+    add_gist_index :projects, :name
-      add_gist_index :projects, :name
+    add_gist_index :my_modules, :name
-      add_gist_index :my_modules, :name
+    add_gist_index :my_module_groups, :name
-      add_gist_index :my_module_groups, :name
+    add_gist_index :tags, :name
-      add_gist_index :tags, :name
+    add_gist_index :steps, :name
-      add_gist_index :steps, :name
+    add_gist_index :results, :name
-      add_gist_index :results, :name
 
       # There's already semi-useless BTree index on samples
-      remove_index :samples, :name
+    remove_index :samples, :name
-      add_gist_index :samples, :name
+    add_gist_index :samples, :name
-    end
   end
 
   def down
@@ -34,17 +32,15 @@ class AddSearchQueryIndexes < ActiveRecord::Migration[4.2]
     remove_index :user_projects, :project_id
     remove_index :tags, :project_id
 
-    if db_adapter_is? "PostgreSQL" then
+    remove_index :projects, :name
-      remove_index :projects, :name
+    remove_index :my_modules, :name
-      remove_index :my_modules, :name
+    remove_index :my_module_groups, :name
-      remove_index :my_module_groups, :name
+    remove_index :tags, :name
-      remove_index :tags, :name
+    remove_index :steps, :name
-      remove_index :steps, :name
+    remove_index :results, :name
-      remove_index :results, :name
 
       # Re-add semi-useless BTree index on samples
-      remove_index :samples, :name
+    remove_index :samples, :name
-      add_index :samples, :name
+    add_index :samples, :name
-    end
   end
 end

db/migrate/20151103155048_add_btree_gist_extension.rb

@@ -3,8 +3,6 @@ include DatabaseHelper
 
 class AddBtreeGistExtension < ActiveRecord::Migration[4.2]
   def up
-    if db_adapter_is? "PostgreSQL" then
+    enable_extension :btree_gist
-      enable_extension :btree_gist
-    end
   end
 end

db/migrate/20151130160157_add_text_search_vector_to_asset_text_data.rb

@@ -5,8 +5,6 @@ class AddTextSearchVectorToAssetTextData < ActiveRecord::Migration[4.2]
   def change
     add_column :asset_text_data, :data_vector, :tsvector
 
-    if db_adapter_is? "PostgreSQL" then
+    add_index :asset_text_data, :data_vector, using: "gin"
-      add_index :asset_text_data, :data_vector, using: "gin"
-    end
   end
 end

db/migrate/20151215134147_add_text_search_vector_to_tables.rb

@@ -5,8 +5,6 @@ class AddTextSearchVectorToTables < ActiveRecord::Migration[4.2]
   def change
     add_column :tables, :data_vector, :tsvector
 
-    if db_adapter_is? "PostgreSQL" then
+    add_index :tables, :data_vector, using: "gin"
-      add_index :tables, :data_vector, using: "gin"
-    end
   end
 end

db/migrate/20151216095259_generate_text_search_vector_for_table_contents.rb

@@ -3,12 +3,10 @@ include DatabaseHelper
 
 class GenerateTextSearchVectorForTableContents < ActiveRecord::Migration[4.2]
   def up
-    if db_adapter_is? "PostgreSQL" then
+    execute <<-SQL
-      execute <<-SQL
+    UPDATE tables
-      UPDATE tables
+    SET data_vector =
-      SET data_vector =
+      to_tsvector(substring(encode(contents::bytea, 'escape'), 9))
-        to_tsvector(substring(encode(contents::bytea, 'escape'), 9))
+    SQL
-      SQL
-    end
   end
 end

db/migrate/20170407082423_update_indexes_for_faster_search.rb

@@ -3,166 +3,161 @@ include DatabaseHelper
 
 class UpdateIndexesForFasterSearch < ActiveRecord::Migration[4.2]
   def up
-    if db_adapter_is? 'PostgreSQL'
+    # Removing old indexes
-      # Removing old indexes
+    if index_name_exists? :projects, :index_projects_on_name
-      if index_name_exists? :projects, :index_projects_on_name
+      remove_index :projects, name: :index_projects_on_name
-        remove_index :projects, name: :index_projects_on_name
-      end
-      if index_name_exists? :my_modules, :index_my_modules_on_name
-        remove_index :my_modules, name: :index_my_modules_on_name
-      end
-      if index_name_exists? :my_modules, :index_my_modules_on_description
-        remove_index :my_modules, name: :index_my_modules_on_description
-      end
-      if index_name_exists? :protocols, :index_protocols_on_name
-        remove_index :protocols, name: :index_protocols_on_name
-      end
-      if index_name_exists? :protocols, :index_protocols_on_description
-        remove_index :protocols, name: :index_protocols_on_description
-      end
-      if index_name_exists? :protocols, :index_protocols_on_authors
-        remove_index :protocols, name: :index_protocols_on_authors
-      end
-      if index_name_exists? :protocol_keywords, :index_protocol_keywords_on_name
-        remove_index :protocol_keywords, name: :index_protocol_keywords_on_name
-      end
-      if index_name_exists? :my_module_groups, :index_my_module_groups_on_name
-        remove_index :my_module_groups, name: :index_my_module_groups_on_name
-      end
-      if index_name_exists? :tags, :index_tags_on_name
-        remove_index :tags, name: :index_tags_on_name
-      end
-      if index_name_exists? :results, :index_results_on_name
-        remove_index :results, name: :index_results_on_name
-      end
-      if index_name_exists? :result_texts, :index_result_texts_on_text
-        remove_index :result_texts, name: :index_result_texts_on_text
-      end
-      if index_name_exists? :reports, :index_reports_on_name
-        remove_index :reports, name: :index_reports_on_name
-      end
-      if index_name_exists? :reports, :index_reports_on_description
-        remove_index :reports, name: :index_reports_on_description
-      end
-      if index_name_exists? :samples, :index_samples_on_name
-        remove_index :samples, name: :index_samples_on_name
-      end
-      if index_name_exists? :sample_types, :index_sample_types_on_name
-        remove_index :sample_types, name: :index_sample_types_on_name
-      end
-      if index_name_exists? :sample_groups, :index_sample_groups_on_name
-        remove_index :sample_groups, name: :index_sample_groups_on_name
-      end
-      if index_name_exists? :sample_custom_fields,
-                            :index_sample_custom_fields_on_value
-        remove_index :sample_custom_fields,
-                     name: :index_sample_custom_fields_on_value
-      end
-      if index_name_exists? :steps, :index_steps_on_name
-        remove_index :steps, name: :index_steps_on_name
-      end
-      if index_name_exists? :steps, :index_steps_on_description
-        remove_index :steps, name: :index_steps_on_description
-      end
-      if index_name_exists? :checklists, :index_checklists_on_name
-        remove_index :checklists, name: :index_checklists_on_name
-      end
-      if index_name_exists? :checklist_items, :index_checklist_items_on_text
-        remove_index :checklist_items, name: :index_checklist_items_on_text
-      end
-      if index_name_exists? :tables, :index_tables_on_name
-        remove_index :tables, name: :index_tables_on_name
-      end
-      if index_name_exists? :users, :index_users_on_full_name
-        remove_index :users, name: :index_users_on_full_name
-      end
-      if index_name_exists? :comments, :index_comments_on_message
-        remove_index :comments, name: :index_comments_on_message
-      end
-      if index_name_exists? :comments, :index_comments_on_type
-        remove_index :comments, name: :index_comments_on_type
-      end
-      if index_name_exists? :protocols, :index_protocols_on_protocol_type
-        remove_index :protocols, name: :index_protocols_on_protocol_type
-      end
-      if index_name_exists? :checklists, :index_checklists_on_step_id
-        remove_index :checklists, name: :index_checklists_on_step_id
-      end
-
-      execute(
-        "CREATE OR REPLACE FUNCTION
-          trim_html_tags(IN input TEXT, OUT output TEXT) AS $$
-        SELECT regexp_replace(input,
-          E'<[^>]*>|\\\\[#.*\\\\]|\\\\[@.*\\\\]',
-          '',
-          'g');
-        $$ LANGUAGE SQL;"
-      )
-
-      add_gin_index_without_tags :projects, :name
-      add_gin_index_without_tags :my_modules, :name
-      add_gin_index_without_tags :my_module_groups, :name
-      add_gin_index_without_tags :my_modules, :description
-      add_gin_index_without_tags :protocols, :name
-      add_gin_index_without_tags :protocols, :description
-      add_gin_index_without_tags :protocols, :authors
-      add_gin_index_without_tags :protocol_keywords, :name
-      add_gin_index_without_tags :tags, :name
-      add_gin_index_without_tags :results, :name
-      add_gin_index_without_tags :result_texts, :text
-      add_gin_index_without_tags :reports, :name
-      add_gin_index_without_tags :reports, :description
-      add_gin_index_without_tags :samples, :name
-      add_gin_index_without_tags :sample_types, :name
-      add_gin_index_without_tags :sample_groups, :name
-      add_gin_index_without_tags :sample_custom_fields, :value
-      add_gin_index_without_tags :steps, :name
-      add_gin_index_without_tags :steps, :description
-      add_gin_index_without_tags :checklists, :name
-      add_gin_index_without_tags :checklist_items, :text
-      add_gin_index_without_tags :tables, :name
-      add_gin_index_without_tags :users, :full_name
-      add_gin_index_without_tags :comments, :message
-      add_index :comments, :type
-      add_index :protocols, :protocol_type
-      add_index :checklists, :step_id
     end
+    if index_name_exists? :my_modules, :index_my_modules_on_name
+      remove_index :my_modules, name: :index_my_modules_on_name
+    end
+    if index_name_exists? :my_modules, :index_my_modules_on_description
+      remove_index :my_modules, name: :index_my_modules_on_description
+    end
+    if index_name_exists? :protocols, :index_protocols_on_name
+      remove_index :protocols, name: :index_protocols_on_name
+    end
+    if index_name_exists? :protocols, :index_protocols_on_description
+      remove_index :protocols, name: :index_protocols_on_description
+    end
+    if index_name_exists? :protocols, :index_protocols_on_authors
+      remove_index :protocols, name: :index_protocols_on_authors
+    end
+    if index_name_exists? :protocol_keywords, :index_protocol_keywords_on_name
+      remove_index :protocol_keywords, name: :index_protocol_keywords_on_name
+    end
+    if index_name_exists? :my_module_groups, :index_my_module_groups_on_name
+      remove_index :my_module_groups, name: :index_my_module_groups_on_name
+    end
+    if index_name_exists? :tags, :index_tags_on_name
+      remove_index :tags, name: :index_tags_on_name
+    end
+    if index_name_exists? :results, :index_results_on_name
+      remove_index :results, name: :index_results_on_name
+    end
+    if index_name_exists? :result_texts, :index_result_texts_on_text
+      remove_index :result_texts, name: :index_result_texts_on_text
+    end
+    if index_name_exists? :reports, :index_reports_on_name
+      remove_index :reports, name: :index_reports_on_name
+    end
+    if index_name_exists? :reports, :index_reports_on_description
+      remove_index :reports, name: :index_reports_on_description
+    end
+    if index_name_exists? :samples, :index_samples_on_name
+      remove_index :samples, name: :index_samples_on_name
+    end
+    if index_name_exists? :sample_types, :index_sample_types_on_name
+      remove_index :sample_types, name: :index_sample_types_on_name
+    end
+    if index_name_exists? :sample_groups, :index_sample_groups_on_name
+      remove_index :sample_groups, name: :index_sample_groups_on_name
+    end
+    if index_name_exists? :sample_custom_fields,
+                          :index_sample_custom_fields_on_value
+      remove_index :sample_custom_fields,
+                   name: :index_sample_custom_fields_on_value
+    end
+    if index_name_exists? :steps, :index_steps_on_name
+      remove_index :steps, name: :index_steps_on_name
+    end
+    if index_name_exists? :steps, :index_steps_on_description
+      remove_index :steps, name: :index_steps_on_description
+    end
+    if index_name_exists? :checklists, :index_checklists_on_name
+      remove_index :checklists, name: :index_checklists_on_name
+    end
+    if index_name_exists? :checklist_items, :index_checklist_items_on_text
+      remove_index :checklist_items, name: :index_checklist_items_on_text
+    end
+    if index_name_exists? :tables, :index_tables_on_name
+      remove_index :tables, name: :index_tables_on_name
+    end
+    if index_name_exists? :users, :index_users_on_full_name
+      remove_index :users, name: :index_users_on_full_name
+    end
+    if index_name_exists? :comments, :index_comments_on_message
+      remove_index :comments, name: :index_comments_on_message
+    end
+    if index_name_exists? :comments, :index_comments_on_type
+      remove_index :comments, name: :index_comments_on_type
+    end
+    if index_name_exists? :protocols, :index_protocols_on_protocol_type
+      remove_index :protocols, name: :index_protocols_on_protocol_type
+    end
+    if index_name_exists? :checklists, :index_checklists_on_step_id
+      remove_index :checklists, name: :index_checklists_on_step_id
+    end
+
+    execute(
+      "CREATE OR REPLACE FUNCTION
+        trim_html_tags(IN input TEXT, OUT output TEXT) AS $$
+      SELECT regexp_replace(input,
+        E'<[^>]*>|\\\\[#.*\\\\]|\\\\[@.*\\\\]',
+        '',
+        'g');
+      $$ LANGUAGE SQL;"
+    )
+
+    add_gin_index_without_tags :projects, :name
+    add_gin_index_without_tags :my_modules, :name
+    add_gin_index_without_tags :my_module_groups, :name
+    add_gin_index_without_tags :my_modules, :description
+    add_gin_index_without_tags :protocols, :name
+    add_gin_index_without_tags :protocols, :description
+    add_gin_index_without_tags :protocols, :authors
+    add_gin_index_without_tags :protocol_keywords, :name
+    add_gin_index_without_tags :tags, :name
+    add_gin_index_without_tags :results, :name
+    add_gin_index_without_tags :result_texts, :text
+    add_gin_index_without_tags :reports, :name
+    add_gin_index_without_tags :reports, :description
+    add_gin_index_without_tags :samples, :name
+    add_gin_index_without_tags :sample_types, :name
+    add_gin_index_without_tags :sample_groups, :name
+    add_gin_index_without_tags :sample_custom_fields, :value
+    add_gin_index_without_tags :steps, :name
+    add_gin_index_without_tags :steps, :description
+    add_gin_index_without_tags :checklists, :name
+    add_gin_index_without_tags :checklist_items, :text
+    add_gin_index_without_tags :tables, :name
+    add_gin_index_without_tags :users, :full_name
+    add_gin_index_without_tags :comments, :message
+    add_index :comments, :type
+    add_index :protocols, :protocol_type
+    add_index :checklists, :step_id
   end
 
   def down
     # remove_index :steps, :team_id
     # remove_column :steps, :team_id, :integer
 
-    if db_adapter_is? 'PostgreSQL'
+    remove_index :projects, :name
-      remove_index :projects, :name
+    remove_index :my_modules, :name
-      remove_index :my_modules, :name
+    remove_index :my_modules, :description
-      remove_index :my_modules, :description
+    remove_index :my_module_groups, :name
-      remove_index :my_module_groups, :name
+    remove_index :protocols, :name
-      remove_index :protocols, :name
+    remove_index :protocols, :description
-      remove_index :protocols, :description
+    remove_index :protocols, :authors
-      remove_index :protocols, :authors
+    remove_index :protocol_keywords, :name
-      remove_index :protocol_keywords, :name
+    remove_index :tags, :name
-      remove_index :tags, :name
+    remove_index :results, :name
-      remove_index :results, :name
+    remove_index :result_texts, :text
-      remove_index :result_texts, :text
+    remove_index :reports, :name
-      remove_index :reports, :name
+    remove_index :reports, :description
-      remove_index :reports, :description
+    remove_index :samples, :name
-      remove_index :samples, :name
+    remove_index :sample_types, :name
-      remove_index :sample_types, :name
+    remove_index :sample_groups, :name
-      remove_index :sample_groups, :name
+    remove_index :sample_custom_fields, :value
-      remove_index :sample_custom_fields, :value
+    remove_index :steps, :name
-      remove_index :steps, :name
+    remove_index :steps, :description
-      remove_index :steps, :description
+    remove_index :checklists, :name
-      remove_index :checklists, :name
+    remove_index :checklist_items, :text
-      remove_index :checklist_items, :text
+    remove_index :tables, :name
-      remove_index :tables, :name
+    remove_index :users, :full_name
-      remove_index :users, :full_name
+    remove_index :comments, :message
-      remove_index :comments, :message
+    remove_index :comments, :type
-      remove_index :comments, :type
+    remove_index :protocols, :protocol_type
-      remove_index :protocols, :protocol_type
+    remove_index :checklists, :step_id
-      remove_index :checklists, :step_id
+    execute('DROP FUNCTION IF EXISTS trim_html_tags(IN input TEXT);')
-
-      execute('DROP FUNCTION IF EXISTS trim_html_tags(IN input TEXT);')
-    end
   end
 end

db/migrate/20170619125051_add_search_indexes_to_repositories.rb

@@ -3,19 +3,15 @@ include DatabaseHelper
 
 class AddSearchIndexesToRepositories < ActiveRecord::Migration[4.2]
   def up
-    if db_adapter_is? 'PostgreSQL'
+    if index_exists?(:repository_rows, :name)
-      if index_exists?(:repository_rows, :name)
+      remove_index :repository_rows, :name
-        remove_index :repository_rows, :name
-      end
-      add_gin_index_without_tags :repository_rows, :name
-      add_gin_index_without_tags :repository_text_values, :data
     end
+    add_gin_index_without_tags :repository_rows, :name
+    add_gin_index_without_tags :repository_text_values, :data
   end
 
   def down
-    if db_adapter_is? 'PostgreSQL'
+    remove_index :repository_rows, :name
-      remove_index :repository_rows, :name
+    remove_index :repository_text_values, :data
-      remove_index :repository_text_values, :data
-    end
   end
 end