Refactory restore inventory service

This commit is contained in:
Urban Rotnik 2020-06-23 08:24:52 +02:00
parent d874b6f732
commit e89bf58e1c
5 changed files with 101 additions and 6 deletions

View file

@ -14,7 +14,7 @@ class RepositoryRow < ApplicationRecord
inverse_of: :archived_repository_rows,
optional: true
belongs_to :restored_by,
foreign_key: :archived_by_id,
foreign_key: :restored_by_id,
class_name: 'User',
inverse_of: :restored_repository_rows,
optional: true

View file

@ -9,11 +9,11 @@ module Repositories
@repositories.each do |repository|
repository.restore!(@user)
RepositoryActions::RestoreRowsService.call(repository: repository,
repository_rows: repository.repository_rows.pluck(:id),
user: @user,
team: @team,
log_activities: false)
# rubocop:disable Rails/SkipsModelValidations
repository.repository_rows.archived.update_all(restored_on: repository.restored_on,
restored_by_id: repository.restored_by_id,
archived: false)
# rubocop:enable Rails/SkipsModelValidations
log_activity(:restore_inventory, repository)
end

View file

@ -12,5 +12,11 @@ FactoryBot.define do
archived_on { Time.zone.now }
archived_by { created_by }
end
trait :restored do
archived { false }
restored_on { Time.zone.now }
restored_by { created_by }
end
end
end

View file

@ -0,0 +1,89 @@
# frozen_string_literal: true
require 'rails_helper'
describe Repositories::RestoreRepositoryService do
let(:user) { create :user }
let(:team) { create :team }
let(:repository) { create :repository, :archived, team: team }
let!(:row_1) { create :repository_row, :archived, repository: repository }
let!(:row_2) { create :repository_row, :archived, repository: repository }
let!(:row_3) { create :repository_row, :archived, repository: repository }
let(:repositories) { [repository] }
let(:service_call) do
Repositories::RestoreRepositoryService.call(repositories: repositories, user: user, team: team)
end
context 'when have inventory with rows' do
it 'updates repository restored_by, restored_on, archived' do
expect { service_call }
.to(change { repository.reload.restored_on }
.and(change { repository.restored_by })
.and(change { repository.archived }))
end
it 'update rows restored_by, restored_on, archived' do
expect { service_call }
.to(change { row_1.reload.restored_on }
.and(change { row_1.restored_by })
.and(change { row_1.archived }))
end
it 'creates 1 activity' do
expect { service_call }.to change { Activity.count }.by(1)
end
context 'when have restored row' do
let!(:row_1) do
create :repository_row, :restored, repository: repository
end
it 'does not update row\'s restored_on' do
row_1.restored_on = Time.zone.now - 10.days
row_1.save
expect { service_call }.not_to(change { row_1.reload.restored_on })
end
end
end
context 'when includes invalid repository' do
let(:second_repository) do
r = create :repository, :archived, team: team
r.name = ''
r.save(validate: false)
r
end
let(:repositories) { [repository, second_repository] }
it 'does not change repository restored_on' do
expect { service_call }.not_to(change { repository.reload.restored_on })
end
it 'does not create activity' do
expect { service_call }.not_to(change { Activity.count })
end
it 'returns error' do
expect(service_call.errors).to have_key(:restoring_error)
end
end
context 'when have invalid item' do
let!(:row_1) do
r = create :repository_row, :archived, repository: repository
r.name = ''
r.save(validate: false)
r
end
it 'restore item anyway' do
expect { service_call }.to(change { row_1.reload.restored_on })
end
it 'creates one activity' do
expect { service_call }.to change { Activity.count }.by(1)
end
end
end