From ebdba39445870b4007a5b7967e8a2fc86e099d04 Mon Sep 17 00:00:00 2001
From: Andrej <andrej@scinote.net>
Date: Mon, 18 Aug 2025 10:53:52 +0200
Subject: [PATCH] Fix private inventory item when adding new item relationship
 [SCI-12253]

---
 .../repository_row_connections_controller.rb  | 30 +++++++++++--------
 .../RepositoryItemSidebar.vue                 |  4 +--
 config/locales/en.yml                         |  2 +-
 3 files changed, 20 insertions(+), 16 deletions(-)

diff --git a/app/controllers/repository_row_connections_controller.rb b/app/controllers/repository_row_connections_controller.rb
index d05d47913..3e6955ae7 100644
--- a/app/controllers/repository_row_connections_controller.rb
+++ b/app/controllers/repository_row_connections_controller.rb
@@ -145,19 +145,23 @@ class RepositoryRowConnectionsController < ApplicationController
 
     repository_connections.map do |connection|
       repository_row = @relation_type == 'parent' ? connection.parent : connection.child
-
-      {
-        name: repository_row.name_with_label,
-        code: repository_row.code,
-        path: repository_repository_row_path(repository_row.repository, repository_row),
-        repository_name: repository_row.repository.name_with_label,
-        repository_path: repository_path(repository_row.repository),
-        unlink_path: repository_repository_row_repository_row_connection_path(
-          repository_row.repository,
-          repository_row,
-          connection
-        )
-      }
+      if can_read_repository?(repository_row.repository)
+        {
+          name: repository_row.name_with_label,
+          code: repository_row.code,
+          path: repository_repository_row_path(repository_row.repository, repository_row),
+          repository_name: repository_row.repository.name_with_label,
+          repository_path: repository_path(repository_row.repository),
+          can_connect_rows: can_connect_repository_rows?(repository_row.repository),
+          unlink_path: repository_repository_row_repository_row_connection_path(
+            repository_row.repository,
+            repository_row,
+            connection
+          )
+        }
+      else
+        { name: I18n.t('repositories.item_card.relationships.private_item_name') }
+      end
     end
   end
 
diff --git a/app/javascript/vue/repository_item_sidebar/RepositoryItemSidebar.vue b/app/javascript/vue/repository_item_sidebar/RepositoryItemSidebar.vue
index 54a8b7ef6..bdfcef902 100644
--- a/app/javascript/vue/repository_item_sidebar/RepositoryItemSidebar.vue
+++ b/app/javascript/vue/repository_item_sidebar/RepositoryItemSidebar.vue
@@ -184,7 +184,7 @@
                       </a>
                     </div>
                     <div v-if="parentsCount">
-                      <details v-for="(parent) in parents" @toggle="updateOpenState(parent.code, $event.target.open)" :key="parent.code" class="flex flex-col font-normal gap-4 group cursor-default">
+                      <details v-for="(parent) in parents" @toggle="updateOpenState(parent.code, $event.target.open)" :key="parent.code" class="flex flex-col font-normal group cursor-default">
                         <summary class="flex flex-row gap-3 mb-4 relative group">
                           <img :src="icons.delimiter_path" class="w-3 h-3 cursor-pointer flex-shrink-0 relative top-1"
                                :class="{ 'rotate-90': relationshipDetailsState[parent.code] }" />
@@ -234,7 +234,7 @@
                     </div>
                     <div v-if="childrenCount">
                       <details v-for="(child) in children" :key="child.code" @toggle="updateOpenState(child.code, $event.target.open)"
-                               class="flex flex-col font-normal gap-4 group-last-of-type:[&>p:last-child]:mb-0">
+                               class="flex flex-col font-normal group-last-of-type:[&>p:last-child]:mb-0">
                         <summary class="flex flex-row gap-3 mb-4 relative group"
                                  :class="{ 'group-last-of-type:mb-0': !relationshipDetailsState[child.code] }">
                           <img :src="icons.delimiter_path" class="w-3 h-3 flex-shrink-0 cursor-pointer relative top-1"
diff --git a/config/locales/en.yml b/config/locales/en.yml
index 4d7595eee..52f4f649b 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -2919,7 +2919,7 @@ en:
           select_valid_value: 'Select a valid date or date-time value'
           browser_alert_message: 'You have made some changes, are you sure you want to leave this page?'
       errors:
-        load_error_header: 'Your workspace does not have the necessary permissions to view the details of this item.'
+        load_error_header: 'You do not have the necessary permissions to view the details of this item.'
         load_error_description: 'To obtain access, reach out to your workspace administrator.'
     highlight_component:
       information_label: 'Information'