scinote-eln/scinote-web
1
1
Fork 0
mirror of https://github.com/scinote-eln/scinote-web.git synced 2024-12-29 11:45:18 +08:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #1509 from urbanrotnik/ur-SCI-3060-SN-limits-for-fields

Browse source 
Add validation limits for system notification fields [SCI-3060]
This commit is contained in:
Urban Rotnik 2019-02-20 16:41:39 +01:00 committed by GitHub
commit f0933f4a89
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
app/models/system_notification.rb
View file

@ -20,9 +20,12 @@ class SystemNotification < ApplicationRecord
:source_created_at, :source_id, :last_time_changed_at,
presence: true
validates :title, :description,
validates :title, :description, :modal_title,
length: { maximum: Constants::NAME_MAX_LENGTH }
validates :modal_body,
length: { maximum: Constants::RICH_TEXT_MAX_LENGTH }
def self.last_notifications(
user,
query = nil

2
spec/factories/system_notifications.rb
View file

@ -3,7 +3,7 @@
FactoryBot.define do
factory :system_notification do
sequence(:title) { |n| "System notification #{n}" }
description { Faker::ChuckNorris.fact }
description { Faker::ChuckNorris.fact[0..255] }
modal_title { Faker::Name.first_name }
modal_body { Faker::Lorem.paragraphs(4).map { |pr| "<p>#{pr}</p>" }.join }
source_created_at { Faker::Time.between(3.days.ago, Date.today) }

4
spec/models/system_notification_spec.rb
View file

@ -13,18 +13,22 @@ describe SystemNotification do
describe 'Validations' do
describe '#title' do
it { is_expected.to validate_presence_of(:title) }
it { is_expected.to validate_length_of(:title).is_at_most(255) }
end
describe '#modal_title' do
it { is_expected.to validate_presence_of(:modal_title) }
it { is_expected.to validate_length_of(:modal_title).is_at_most(255) }
end
describe '#modal_body' do
it { is_expected.to validate_presence_of(:modal_body) }
it { is_expected.to validate_length_of(:modal_body).is_at_most(50000) }
end
describe '#description' do
it { is_expected.to validate_presence_of(:description) }
it { is_expected.to validate_length_of(:description).is_at_most(255) }
end
describe '#source_id' do