Fix linter errors [SCI-5099]

app/assets/javascripts/users/settings/teams/invite_users_modal.js

@@ -36,7 +36,7 @@
       maxTags: modal.data('max-tags')
     });
 
-    emailTagsInput.on('change', function(e) {
+    emailTagsInput.on('change', function() {
       if (emailTagsInput.val()) {
         inviteBtn.removeAttr('disabled');
       } else {

app/assets/stylesheets/themes/scinote.scss

@@ -1317,6 +1317,8 @@ body > .loading-overlay {
 }
 
 .modal-invite-users {
+  overflow: hidden;
+
   .bootstrap-tagsinput {
     min-width: 450px;
     width: 100%;
@@ -1324,24 +1326,24 @@ body > .loading-overlay {
 
     .tag {
       color: $color-black;
-      font-weight: normal;
       font-size: 12px;
+      font-weight: normal;
       line-height: 13px;
       padding: 5px 8px;
     }
 
     [data-role="remove"] {
       margin-left: 4px;
+    }
 
-      &::after {
-        content: "\f00d";
-        font-family: "Font Awesome 5 Free";
-        padding: 0px 2px;
-        font-weight: 900;
-        display: inline-block;
-        font-size: 12px;
-        opacity: .7;
-      }
+    [data-role="remove"]::after {
+      content: "\f00d";
+      display: inline-block;
+      font-family: "Font Awesome 5 Free";
+      font-size: 12px;
+      font-weight: 900;
+      opacity: .7;
+      padding: 0 2px;
     }
   }
 
@@ -1380,16 +1382,16 @@ body > .loading-overlay {
   }
 
   .select-container--with-blank {
-    input.search-field::placeholder {
+    overflow: hidden;
+
+    .search-field::placeholder {
       color: $color-black;
       opacity: 1;
     }
 
-    input.search-field:focus::placeholder {
+    .search-field:focus::placeholder {
       opacity: 0;
     }
-
-    overflow: hidden;
   }
 }
 
@@ -1537,6 +1539,7 @@ a.disabled-with-click-events {
   position: relative;
 
   select {
+    appearance: none;
     border: 1px solid $color-silver-chalice;
     border-radius: 4px;
     color: $color-emperor;
@@ -1546,22 +1549,21 @@ a.disabled-with-click-events {
     outline: 0;
     padding: 8px 42px 3px 3px;
     width: 100%;
-    appearance: none;
   }
 
-  &:after {
+  &::after {
+    color: $color-silver-chalice;
+    content: "\f0d7";
     font-family: "Font Awesome 5 Free";
     font-weight: 900;
-    content: "\f0d7";
-    color: $color-silver-chalice;
+    height: 100%;
     padding: 12px 8px;
+    pointer-events: none;
     position: absolute;
     right: -6px;
-    top: -6px;
-    z-index: 1;
     text-align: center;
+    top: -6px;
     width: 10%;
-    height: 100%;
-    pointer-events: none;
+    z-index: 1;
   }
 }