diff --git a/app/assets/javascripts/repository_columns/index.js b/app/assets/javascripts/repository_columns/index.js index ddeb24856..144992d49 100644 --- a/app/assets/javascripts/repository_columns/index.js +++ b/app/assets/javascripts/repository_columns/index.js @@ -71,11 +71,11 @@ var RepositoryColumns = (function() { $('.repository-columns-body').off('click', '.edit-repo-column').on('click', '.edit-repo-column', function() { var editUrl = $(this).closest('li').attr('data-edit-url'); $.get(editUrl, function(data) { - $(data.html).appendTo('body'); + $(modalID).find('.modal-content').html(data.html); $(modalID).modal('show'); initColumnTypeSelector(); - $('#repository_column_data_type').val($(modalID).attr('data-edit-type')).trigger('click'); + $('#repository_column_data_type').val($(modalID).find('#new_repository_column').attr('data-edit-type')).trigger('click'); $('#repository_column_data_type').prop('disabled', true); setTimeout(function() { $('#repository_column_name').focus(); @@ -178,7 +178,7 @@ var RepositoryColumns = (function() { $('.repository-columns-header').off('click', '#new-repo-column-modal').on('click', '#new-repo-column-modal', function() { var modalUrl = $(this).attr('data-modal-url'); $.get(modalUrl, function(data) { - $(data.html).appendTo('body'); + $(modalID).find('.modal-content').html(data.html); $(modalID).modal('show'); initColumnTypeSelector(); diff --git a/app/controllers/repository_columns_controller.rb b/app/controllers/repository_columns_controller.rb index 1d990c4b7..f540f299f 100644 --- a/app/controllers/repository_columns_controller.rb +++ b/app/controllers/repository_columns_controller.rb @@ -21,7 +21,7 @@ class RepositoryColumnsController < ApplicationController format.json do render json: { html: render_to_string( - partial: 'repository_columns/manage_column_modal.html.erb' + partial: 'repository_columns/manage_column_modal_body.html.erb' ) } end @@ -77,7 +77,7 @@ class RepositoryColumnsController < ApplicationController format.json do render json: { html: render_to_string( - partial: 'repository_columns/manage_column_modal.html.erb' + partial: 'repository_columns/manage_column_modal_body.html.erb' ) } end diff --git a/app/views/repository_columns/_manage_column_modal.html.erb b/app/views/repository_columns/_manage_column_modal.html.erb index ca48b0d48..dadb6525a 100644 --- a/app/views/repository_columns/_manage_column_modal.html.erb +++ b/app/views/repository_columns/_manage_column_modal.html.erb @@ -2,76 +2,9 @@ id="manageRepositoryColumn" tabindex="-1" role="dialog" - aria-labelledby="manangeRepositoryColumnLabel" - data-edit-type="<%= @repository_column.data_type unless @repository_column.new_record? %>"> + aria-labelledby="manangeRepositoryColumnLabel">