Commit graph

2546 commits

Author SHA1 Message Date
Zanz2 f5b2ad0d34 Refactor github code review 2017-10-07 16:07:04 +02:00
Zanz2 66e5004e60 Changed import text to be inside en.yml, as said in the code review, deleted some blank lines 2017-10-07 15:56:43 +02:00
lenart de3c18509f Variable name changes, added comments to code [fixes SCI-1249] 2017-10-06 17:12:15 +02:00
Oleksii Kriuchykhin 6820511ea0 Further canvas optimizations [SCI-1642] 2017-10-06 12:43:27 +02:00
Zanz2 48f03d6dfb hound blank line fix 2017-10-05 18:41:58 +02:00
Zanz2 fc1cd73e1d fixed hound blank line 2017-10-05 18:38:44 +02:00
Zanz2 9fd67019e0 Deleted unused file 2017-10-05 18:09:07 +02:00
Zanz2 64b72f4ad4 Fixed a bug, where if the url get query is nil (if you go directly to /protocols, it doesnt get the public type from url, now when it is nil it just defaults to public 2017-10-05 17:31:49 +02:00
Oleksii Kriuchykhin b26b963e54 Optimize update canvas SQL and remove module group name [SCI-1642] 2017-10-05 16:19:25 +02:00
mlorb 91e2a6bab2 Merge pull request #787 from mlorb/ml-sci-1561
Fix bug with tinyMCE text validaton [SCI-1561]
2017-10-05 08:39:22 +02:00
okriuchykhin 2c5d913048 Merge pull request #804 from okriuchykhin/ok_SCI_1482
Improve memory utilization in PDF report generator [SCI-1482]
2017-10-04 17:51:28 +02:00
Oleksii Kriuchykhin 6824f9a8bc Improve memory utulization in PDF report generator [SCI-1482] 2017-10-02 11:29:22 +02:00
Luka Murn 7cc2136c74 Bump VERSION to 1.12.4 2017-09-29 13:32:31 +02:00
Zanz2 b23ca33e73 Deleted todo-list comments :D 2017-09-26 16:46:17 +02:00
Zanz2 9bf69276ae deleted unused files 2017-09-26 16:39:19 +02:00
Zanz2 c72cf6320a Finished rubocop refactoring 2017-09-26 16:19:09 +02:00
okriuchykhin 34d1735cf5 Merge pull request #800 from okriuchykhin/ok_SCI_1623_v2
Update AWS SDK v2 [SCI-1623]
2017-09-26 14:46:02 +02:00
Oleksii Kriuchykhin faaa016267 Update AWS SDK v2 [SCI-1623] 2017-09-26 13:41:53 +02:00
Zanz2 3074acbc0d Made javascript code nicer 2017-09-26 13:31:24 +02:00
Zanz2 055746bfd9 Rubocop beautified code v2 2017-09-26 13:21:48 +02:00
Zanz2 ad1847256c Rubocop beautified code 2017-09-26 13:20:55 +02:00
Zanz2 8d961c934a Rubocop refactored part of the controller code 2017-09-26 13:17:00 +02:00
Zanz2 2bfe8f0b95 Testing why rubocop gives errors 2017-09-25 15:27:24 +02:00
Zanz2 79e065a811 Fixed a mistake in the fix that made it not render the preview 2017-09-25 14:39:43 +02:00
Zanz2 292c1e3c31 Fixed bug, seems like unconssistent indexes instead of hash values can also happen in steps that arent first 2017-09-25 14:14:27 +02:00
Zanz2 11b2ef3112 Made code nicer, hopefully not unintentionally breaking something 2017-09-25 13:53:32 +02:00
Luka Murn 4f8f248cd2 Merge pull request #798 from Ducz0r/lm-opensci-26-fix
Fix missing value in delayed_uploader_tutorial
2017-09-22 17:12:21 +02:00
Luka Murn 05e627e976 Fix missing value in delayed_uploader_tutorial
Closes OPENSCI-26.
2017-09-22 17:10:53 +02:00
Zanz2 549346bb0a Deleted a warning that was out of place 2017-09-22 16:13:06 +02:00
Zanz2 dd4d4072e8 Made code more aesthetic 2017-09-22 16:02:56 +02:00
Zanz2 6ebdea5dce Fixed old workaround with inconsistent protocols.io json formatting and made the workaround nicer (now its only one if statement, instead of one whole block of duplicated code) 2017-09-22 15:12:29 +02:00
Zanz2 4051c0b06b Deleted old unused files i spotted on github 2017-09-22 13:28:38 +02:00
Zanz2 6a07aa28e4 Accidentally removed this line after reviewing git changes, adding it back 2017-09-22 13:11:49 +02:00
Zanz2 deef790951 added validations to controllers (file too big, names too big), some javascript error messagges, and fixed some nil exceptions in controllers appending nil strings to descriptions 2017-09-22 11:56:50 +02:00
Zanz2 1dbb03e22d Added all the fields into description of protocol steps and protocol itself, need to make protocols description format nicer 2017-09-21 16:05:33 +02:00
Zanz2 df8cbc2741 vastly improved protocol preview styling to look more like documentation specifications 2017-09-21 13:46:52 +02:00
Zanz2 8da72eb64a made code look nicer 2017-09-21 09:29:13 +02:00
Zanz2 f48833c47a added format .js response which hides the preview modal and refreshes the page with protocolsDatatable.ajax.reload(); 2017-09-21 08:40:05 +02:00
Zanz2 d59234a1e3 minor changes, working on refresh after submit 2017-09-20 16:04:52 +02:00
Zanz2 72c707ae88 protocol importing into database works, still need to decide how to add other fields from protocols.io to step description and protocol description, but that can be added easily, and need to make it refresh after submit 2017-09-20 15:31:10 +02:00
Zanz2 7b85d74a23 added jquery code to reset file selector selected file after it is canceled in the preview modal 2017-09-20 09:32:31 +02:00
Zanz2 3812b2e64b Removed on modal hide refresh, no longer needed, works without data gets updated without refresh since its not passed by javascript locals anymore 2017-09-20 08:58:00 +02:00
Zanz2 ea8f3e822d Removed all the html bug workarounds since it is now fixed (strip tags and remove " now gone 2017-09-20 08:38:34 +02:00
Zanz2 ed64ce814a i think i finally solved it, i found the issue being a certain file upload gem forcing textbox to .js files (remotipart), i tracked down their github issues and found a user that made a fix to this bug, copied his code ant it works, turns out it was a & symbol type escaped string breaking the javascript 2017-09-19 16:07:54 +02:00
Zanz2 7aba782639 optimised code so i dont need javascript locals anymore and working to fix infamous html tags bug where second modal doesnt show 2017-09-19 15:02:16 +02:00
Zanz2 f861b1fc52 Configured the controller,the main task ahead is to figure out how to import all of the data i have available 2017-09-15 15:52:55 +02:00
Zanz2 d85e02730d Addes steps, basic functionality is working, still need to style and fix bugs and upload to database etc 2017-09-15 12:19:58 +02:00
Zanz2 175aa16a7d Made submit form on preview, need to route it propperly, made text scroller for step importing that only works with my own sample protocol i created on protocols.io with every attribute set, trying to debug why it does this 2017-09-14 15:52:44 +02:00
Zanz2 5d6cc341ed added first half of inputs, working on scroller next, page now refreshes after you cancel out of import window, to update the data, will look for alternate way after im done 2017-09-14 14:42:04 +02:00
Zanz2 d6d1f9d490 changed second modal preview styling to fit its specifications 2017-09-14 11:46:41 +02:00