scinote-web/spec/requests/api/v1/inventory_columns_controller_spec.rb
Luka Murn 1093ea11f4 Merge branch 'lm-api-fixes' of https://github.com/Ducz0r/scinote-web into Ducz0r-lm-api-fixes
Conflicts:
	app/serializers/api/v1/activity_serializer.rb
	app/serializers/api/v1/inventory_column_serializer.rb
	app/serializers/api/v1/project_serializer.rb
2018-10-15 15:20:26 +02:00

426 lines
16 KiB
Ruby
Raw Blame History

This file contains invisible Unicode characters

This file contains invisible Unicode characters that are indistinguishable to humans but may be processed differently by a computer. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

# frozen_string_literal: true
require 'rails_helper'
RSpec.describe 'Api::V1::InventoryColumnsController', type: :request do
before :all do
@user = create(:user)
@teams = create_list(:team, 2, created_by: @user)
create(:user_team, user: @user, team: @teams.first, role: 2)
# valid_inventory
@valid_inventory = create(:repository, name: Faker::Name.unique.name,
created_by: @user, team: @teams.first)
# unaccessable_inventory
create(:repository, name: Faker::Name.unique.name,
created_by: @user, team: @teams.second)
create(:repository_column, name: Faker::Name.unique.name,
repository: @valid_inventory, data_type: :RepositoryTextValue)
list_column = create(:repository_column, name: Faker::Name.unique.name,
repository: @valid_inventory, data_type: :RepositoryListValue)
create(:repository_list_item, repository: @valid_inventory,
repository_column: list_column, data: Faker::Name.unique.name)
create(:repository_column, name: Faker::Name.unique.name,
repository: @valid_inventory, data_type: :RepositoryAssetValue)
@valid_headers =
{ 'Authorization': 'Bearer ' + generate_token(@user.id) }
end
describe 'GET inventory_columns, #index' do
it 'Response with correct inventory items, default per page' do
hash_body = nil
get api_v1_team_inventory_columns_path(
team_id: @teams.first.id,
inventory_id: @teams.first.repositories.first.id
), headers: @valid_headers
expect { hash_body = json }.not_to raise_exception
expect(hash_body[:data]).to match(
ActiveModelSerializers::SerializableResource
.new(@valid_inventory.repository_columns.limit(10),
each_serializer: Api::V1::InventoryColumnSerializer,
hide_list_items: true)
.as_json[:data]
)
end
it 'When invalid request, user in not member of the team' do
hash_body = nil
get api_v1_team_inventory_columns_path(
team_id: @teams.second.id,
inventory_id: @teams.second.repositories.first.id
), headers: @valid_headers
expect(response).to have_http_status(403)
expect { hash_body = json }.not_to raise_exception
expect(hash_body).to match({})
end
it 'When invalid request, non existing inventory' do
hash_body = nil
get api_v1_team_inventory_columns_path(
team_id: @teams.first.id,
inventory_id: 123
), headers: @valid_headers
expect(response).to have_http_status(404)
expect { hash_body = json }.not_to raise_exception
expect(hash_body).to match({})
end
it 'When invalid request, repository from another team' do
hash_body = nil
get api_v1_team_inventory_columns_path(
team_id: @teams.first.id,
inventory_id: @teams.second.repositories.first.id
), headers: @valid_headers
expect(response).to have_http_status(404)
expect { hash_body = json }.not_to raise_exception
expect(hash_body).to match({})
end
end
describe 'GET inventory_column, #show' do
it 'Valid text column response' do
text_column = @valid_inventory.repository_columns.first
hash_body = nil
get api_v1_team_inventory_column_path(
id: text_column.id,
team_id: @teams.first.id,
inventory_id: @valid_inventory.id
), headers: @valid_headers
expect { hash_body = json }.not_to raise_exception
expect(hash_body[:data]).to match(
ActiveModelSerializers::SerializableResource
.new(text_column,
serializer: Api::V1::InventoryColumnSerializer)
.as_json[:data]
)
expect(hash_body[:data]).not_to include('relationships')
end
it 'Valid list column response' do
list_column = @valid_inventory.repository_columns.second
hash_body = nil
get api_v1_team_inventory_column_path(
id: list_column.id,
team_id: @teams.first.id,
inventory_id: @valid_inventory.id
), headers: @valid_headers
expect { hash_body = json }.not_to raise_exception
expect(hash_body[:data]).to match(
ActiveModelSerializers::SerializableResource
.new(list_column,
serializer: Api::V1::InventoryColumnSerializer)
.as_json[:data]
)
expect(hash_body[:data]).to include('relationships')
expect(hash_body[:included]).to match(
ActiveModelSerializers::SerializableResource
.new(@valid_inventory.repository_columns.limit(10),
each_serializer: Api::V1::InventoryColumnSerializer,
include: :inventory_list_items)
.as_json[:included]
)
end
it 'Valid file column response' do
file_column = @valid_inventory.repository_columns.third
hash_body = nil
get api_v1_team_inventory_column_path(
id: file_column.id,
team_id: @teams.first.id,
inventory_id: @valid_inventory.id
), headers: @valid_headers
expect { hash_body = json }.not_to raise_exception
expect(hash_body[:data]).to match(
ActiveModelSerializers::SerializableResource
.new(file_column,
serializer: Api::V1::InventoryColumnSerializer)
.as_json[:data]
)
expect(hash_body[:data]).not_to include('relationships')
end
it 'Invalid request, non existing inventory column' do
get api_v1_team_inventory_column_path(
id: 1001,
team_id: @teams.first.id,
inventory_id: @teams.first.repositories.first.id
), headers: @valid_headers
expect(response).to have_http_status(404)
end
it 'When invalid request, incorrect repository' do
id = @teams.first.repositories.first.repository_columns.last.id
get api_v1_team_inventory_column_path(
id: id,
team_id: @teams.first.id,
inventory_id: @teams.second.repositories.first.id
), headers: @valid_headers
expect(response).to have_http_status(404)
expect(RepositoryColumn.where(id: id)).to exist
end
it 'When invalid request, repository from another team' do
id = @teams.first.repositories.first.repository_columns.last.id
get api_v1_team_inventory_column_path(
id: id,
team_id: @teams.second.id,
inventory_id: @teams.first.repositories.first.id
), headers: @valid_headers
expect(response).to have_http_status(403)
expect(RepositoryColumn.where(id: id)).to exist
end
end
describe 'POST inventory_column, #create' do
before :all do
@valid_headers['Content-Type'] = 'application/json'
@request_body = { data:
{ type: 'inventory_columns',
attributes: {
name: Faker::Name.unique.name,
data_type:
RepositoryColumn.data_types.values.first
} } }
end
it 'Response with correct inventory column' do
hash_body = nil
post api_v1_team_inventory_columns_path(
team_id: @teams.first.id,
inventory_id: @teams.first.repositories.first.id
), params: @request_body.to_json, headers: @valid_headers
expect(response).to have_http_status 201
expect { hash_body = json }.not_to raise_exception
expect(hash_body[:data]).to match(
ActiveModelSerializers::SerializableResource
.new(RepositoryColumn.last,
serializer: Api::V1::InventoryColumnSerializer,
include: :inventory_cells)
.as_json[:data]
)
end
it 'When invalid request, user in not member of the team' do
hash_body = nil
post api_v1_team_inventory_columns_path(
team_id: @teams.second.id,
inventory_id: @teams.first.repositories.first.id
), params: @request_body.to_json, headers: @valid_headers
expect(response).to have_http_status 403
expect { hash_body = json }.not_to raise_exception
expect(hash_body).to match({})
end
it 'When invalid request, non existing inventory' do
hash_body = nil
post api_v1_team_inventory_columns_path(
team_id: @teams.first.id,
inventory_id: 123
), params: @request_body.to_json, headers: @valid_headers
expect(response).to have_http_status 404
expect { hash_body = json }.not_to raise_exception
expect(hash_body).to match({})
end
it 'When invalid request, repository from another team' do
hash_body = nil
post api_v1_team_inventory_columns_path(
team_id: @teams.first.id,
inventory_id: @teams.second.repositories.first.id
), params: @request_body.to_json, headers: @valid_headers
expect(response).to have_http_status(404)
expect { hash_body = json }.not_to raise_exception
expect(hash_body).to match({})
end
it 'When invalid request, incorrect type' do
invalid_request_body = @request_body.deep_dup
invalid_request_body[:data][:type] = 'repository_rows'
hash_body = nil
post api_v1_team_inventory_columns_path(
team_id: @teams.first.id,
inventory_id: @teams.first.repositories.first.id
), params: invalid_request_body.to_json, headers: @valid_headers
expect(response).to have_http_status(400)
expect { hash_body = json }.to_not raise_exception
expect(hash_body).to match({})
end
it 'When invalid request, missing data param' do
hash_body = nil
post api_v1_team_inventory_columns_path(
team_id: @teams.first.id,
inventory_id: @teams.first.repositories.first.id
), params: {}, headers: @valid_headers
expect(response).to have_http_status(400)
expect { hash_body = json }.to_not raise_exception
expect(hash_body).to match({})
end
it 'When invalid request, missing attributes param' do
invalid_request_body = @request_body.deep_dup
invalid_request_body[:data].delete(:attributes)
hash_body = nil
post api_v1_team_inventory_columns_path(
team_id: @teams.first.id,
inventory_id: @teams.first.repositories.first.id
), params: invalid_request_body.to_json, headers: @valid_headers
expect(response).to have_http_status(400)
expect { hash_body = json }.to_not raise_exception
expect(hash_body).to match({})
end
it 'When invalid request, missing type param' do
invalid_request_body = @request_body.deep_dup
invalid_request_body[:data].delete(:type)
hash_body = nil
post api_v1_team_inventory_columns_path(
team_id: @teams.first.id,
inventory_id: @teams.first.repositories.first.id
), params: invalid_request_body.to_json, headers: @valid_headers
expect(response).to have_http_status(400)
expect { hash_body = json }.to_not raise_exception
expect(hash_body).to match({})
end
it 'When invalid request, missing attributes values' do
hash_body = nil
%i(name data_type).each do |attr|
invalid_request_body = @request_body.deep_dup
invalid_request_body[:data][:attributes].delete(attr)
post api_v1_team_inventory_columns_path(
team_id: @teams.first.id,
inventory_id: @teams.first.repositories.first.id
), params: invalid_request_body.to_json, headers: @valid_headers
expect(response).to have_http_status(400)
expect { hash_body = json }.to_not raise_exception
expect(hash_body).to match({})
end
end
end
describe 'DELETE inventory_columns, #destroy' do
it 'Destroys inventory column' do
deleted_id = @teams.first.repositories.first.repository_columns.last.id
delete api_v1_team_inventory_column_path(
id: deleted_id,
team_id: @teams.first.id,
inventory_id: @teams.first.repositories.first.id
), headers: @valid_headers
expect(response).to have_http_status(200)
expect(RepositoryColumn.where(id: deleted_id)).to_not exist
expect(RepositoryCell.where(repository_column: deleted_id).count).to equal 0
end
it 'Invalid request, non existing inventory column' do
delete api_v1_team_inventory_column_path(
id: 1001,
team_id: @teams.first.id,
inventory_id: @teams.first.repositories.first.id
), headers: @valid_headers
expect(response).to have_http_status(404)
end
it 'When invalid request, incorrect repository' do
deleted_id = @teams.first.repositories.first.repository_columns.last.id
delete api_v1_team_inventory_column_path(
id: deleted_id,
team_id: @teams.first.id,
inventory_id: @teams.second.repositories.first.id
), headers: @valid_headers
expect(response).to have_http_status(404)
expect(RepositoryColumn.where(id: deleted_id)).to exist
end
it 'When invalid request, repository from another team' do
deleted_id = @teams.first.repositories.first.repository_columns.last.id
delete api_v1_team_inventory_column_path(
id: deleted_id,
team_id: @teams.second.id,
inventory_id: @teams.first.repositories.first.id
), headers: @valid_headers
expect(response).to have_http_status(403)
expect(RepositoryColumn.where(id: deleted_id)).to exist
end
end
describe 'PATCH inventory_column, #update' do
before :all do
@valid_headers['Content-Type'] = 'application/json'
@inventory_column = ActiveModelSerializers::SerializableResource.new(
RepositoryColumn.last,
serializer: Api::V1::InventoryColumnSerializer
)
end
it 'Response with correctly updated inventory column' do
hash_body = nil
updated_inventory_column = @inventory_column.as_json
updated_inventory_column[:data][:attributes][:name] =
Faker::Name.unique.name
returned_inventory_column = updated_inventory_column.deep_dup
updated_inventory_column[:data][:attributes].delete(:data_type)
patch api_v1_team_inventory_column_path(
id: RepositoryColumn.last.id,
team_id: @teams.first.id,
inventory_id: @teams.first.repositories.first.id
), params: updated_inventory_column.to_json,
headers: @valid_headers
expect(response).to have_http_status 200
expect { hash_body = json }.not_to raise_exception
expect(hash_body.to_json).to match(returned_inventory_column.to_json)
end
it 'Invalid request, wrong team' do
hash_body = nil
updated_inventory_column = @inventory_column.as_json
updated_inventory_column[:data][:attributes][:name] =
Faker::Name.unique.name
patch api_v1_team_inventory_column_path(
id: RepositoryColumn.last.id,
team_id: @teams.second.id,
inventory_id: @teams.first.repositories.first.id
), params: updated_inventory_column.to_json,
headers: @valid_headers
expect(response).to have_http_status 403
expect { hash_body = json }.not_to raise_exception
expect(hash_body).to match({})
end
it 'Invalid request, wrong inventory' do
hash_body = nil
updated_inventory_column = @inventory_column.as_json
updated_inventory_column[:data][:attributes][:name] =
Faker::Name.unique.name
patch api_v1_team_inventory_column_path(
id: RepositoryColumn.last.id,
team_id: @teams.second.id,
inventory_id: @teams.second.repositories.first.id
), params: updated_inventory_column.to_json,
headers: @valid_headers
expect(response).to have_http_status 403
expect { hash_body = json }.not_to raise_exception
expect(hash_body).to match({})
end
it 'Invalid request, non-existent inventory' do
hash_body = nil
updated_inventory_column = @inventory_column.as_json
updated_inventory_column[:data][:attributes][:name] =
Faker::Name.unique.name
patch api_v1_team_inventory_column_path(
id: RepositoryColumn.last.id,
team_id: @teams.first.id,
inventory_id: 123
), params: updated_inventory_column.to_json,
headers: @valid_headers
expect(response).to have_http_status 404
expect { hash_body = json }.not_to raise_exception
expect(hash_body).to match({})
end
end
end