simple-login/app
1
1
Fork 0
mirror of https://github.com/simple-login/app.git synced 2025-02-23 23:34:05 +08:00
Code Issues Projects Releases Packages Wiki Activity

Always check redirect_uri for oauth (#1111)

Browse source 
* Always check redirect_uri for oauth

* Fix OAuth tests
This commit is contained in:
Carlos Quintana 2022-06-27 13:20:18 +02:00 committed by GitHub
parent f58c4a9a50
commit 686f4f3f68
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 85 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/oauth/views/authorize.py
View file

@ -72,16 +72,16 @@ def authorize():
if not client:
return redirect(url_for("auth.login"))
# check if redirect_uri is valid
# allow localhost by default
# allow any redirect_uri if the app isn't approved
hostname, scheme = get_host_name_and_scheme(redirect_uri)
if hostname != "localhost" and hostname != "127.0.0.1" and client.approved:
if hostname != "localhost" and hostname != "127.0.0.1":
# support custom scheme for mobile app
if scheme == "http":
final_redirect_uri = f"{redirect_uri}?error=http_not_allowed"
return redirect(final_redirect_uri)
# check if redirect_uri is valid
if not RedirectUri.get_by(client_id=client.id, uri=redirect_uri):
final_redirect_uri = f"{redirect_uri}?error=unknown_redirect_uri"
return redirect(final_redirect_uri)

2
templates/oauth/authorize.html
View file

@ -36,7 +36,7 @@
<form class="card" method="post" data-parsley-validate style="max-width: 40rem; margin: auto; border-radius: 2%">
{% if not client.approved %}
<div class="alert alert-warning" style="border-bottom: 3px solid;">
<b>{{ client.name }}</b> is in Dev Mode and isn't approved (yet) by SimpleLogin.
<b>{{ client.name }}</b> is in Dev Mode and isn't approved (yet) by SimpleLogin. <b>Please make sure you trust {{ client.name }} before proceeding.</b>
</div>
{% endif %}

105
tests/oauth/test_authorize.py
View file

@ -4,16 +4,19 @@ from urllib.parse import urlparse, parse_qs
from flask import url_for
from app.config import ALLOWED_REDIRECT_DOMAINS
from app.db import Session
from app.jose_utils import verify_id_token, decode_id_token
from app.models import Client, User, ClientUser
from app.models import Client, User, ClientUser, RedirectUri
from app.oauth.views.authorize import (
get_host_name_and_scheme,
generate_access_token,
construct_url,
)
from tests.utils import login
from tests.utils import login, random_domain, random_string, random_email
def generate_random_uri() -> str:
return f"https://{random_domain()}/callback"
def test_get_host_name_and_scheme():
@ -39,18 +42,25 @@ def test_construct_url():
def test_authorize_page_non_login_user(flask_client):
"""make sure to display login page for non-authenticated user"""
user = User.create("test@test.com", "test user")
user = User.create(random_email(), random_string())
Session.commit()
client = Client.create_new("test client", user.id)
client = Client.create_new(random_string(), user.id)
Session.commit()
uri = generate_random_uri()
RedirectUri.create(
client_id=client.id,
uri=uri,
commit=True,
)
r = flask_client.get(
url_for(
"oauth.authorize",
client_id=client.oauth_client_id,
state="teststate",
redirect_uri=f"https://{ALLOWED_REDIRECT_DOMAINS[0]}",
redirect_uri=uri,
response_type="code",
)
)
@ -105,12 +115,19 @@ def test_authorize_page_login_user(flask_client):
Session.commit()
uri = generate_random_uri()
RedirectUri.create(
client_id=client.id,
uri=uri,
commit=True,
)
r = flask_client.get(
url_for(
"oauth.authorize",
client_id=client.oauth_client_id,
state="teststate",
redirect_uri=f"https://{ALLOWED_REDIRECT_DOMAINS[0]}",
redirect_uri=uri,
response_type="code",
)
)
@ -128,8 +145,14 @@ def test_authorize_code_flow_no_openid_scope(flask_client):
user = login(flask_client)
client = Client.create_new("test client", user.id)
Session.commit()
domain = random_domain()
uri = f"https://{domain}/callback"
RedirectUri.create(
client_id=client.id,
uri=uri,
commit=True,
)
# user allows client on the authorization page
r = flask_client.post(
@ -137,7 +160,7 @@ def test_authorize_code_flow_no_openid_scope(flask_client):
"oauth.authorize",
client_id=client.oauth_client_id,
state="teststate",
redirect_uri=f"https://{ALLOWED_REDIRECT_DOMAINS[0]}",
redirect_uri=uri,
response_type="code",
),
data={"button": "allow", "suggested-email": "x@y.z", "suggested-name": "AB CD"},
@ -150,7 +173,7 @@ def test_authorize_code_flow_no_openid_scope(flask_client):
# r.location will have this form http://localhost?state=teststate&code=knuyjepwvg
o = urlparse(r.location)
assert o.netloc == ALLOWED_REDIRECT_DOMAINS[0]
assert o.netloc == domain
assert not o.fragment
# parse the query, should return something like
@ -193,7 +216,7 @@ def test_authorize_code_flow_no_openid_scope(flask_client):
assert not r.json["scope"]
assert r.json["token_type"] == "Bearer"
client_user = ClientUser.first()
client_user = ClientUser.get_by(client_id=client.id)
assert r.json["user"] == {
"avatar_url": None,
@ -220,13 +243,21 @@ def test_authorize_code_flow_with_openid_scope(flask_client):
Session.commit()
domain = random_domain()
uri = f"https://{domain}/callback"
RedirectUri.create(
client_id=client.id,
uri=uri,
commit=True,
)
# user allows client on the authorization page
r = flask_client.post(
url_for(
"oauth.authorize",
client_id=client.oauth_client_id,
state="teststate",
redirect_uri=f"https://{ALLOWED_REDIRECT_DOMAINS[0]}",
redirect_uri=uri,
response_type="code",
scope="openid", # openid is in scope
),
@ -240,7 +271,7 @@ def test_authorize_code_flow_with_openid_scope(flask_client):
# r.location will have this form http://localhost?state=teststate&code=knuyjepwvg
o = urlparse(r.location)
assert o.netloc == ALLOWED_REDIRECT_DOMAINS[0]
assert o.netloc == domain
assert not o.fragment
# parse the query, should return something like
@ -283,7 +314,7 @@ def test_authorize_code_flow_with_openid_scope(flask_client):
assert r.json["scope"] == "openid"
assert r.json["token_type"] == "Bearer"
client_user = ClientUser.first()
client_user = ClientUser.get_by(client_id=client.id)
assert r.json["user"] == {
"avatar_url": None,
@ -312,6 +343,13 @@ def test_authorize_token_flow(flask_client):
client = Client.create_new("test client", user.id)
Session.commit()
domain = random_domain()
uri = f"https://{domain}/callback"
RedirectUri.create(
client_id=client.id,
uri=uri,
commit=True,
)
# user allows client on the authorization page
r = flask_client.post(
@ -319,7 +357,7 @@ def test_authorize_token_flow(flask_client):
"oauth.authorize",
client_id=client.oauth_client_id,
state="teststate",
redirect_uri=f"https://{ALLOWED_REDIRECT_DOMAINS[0]}",
redirect_uri=uri,
response_type="token", # token flow
),
data={"button": "allow", "suggested-email": "x@y.z", "suggested-name": "AB CD"},
@ -332,7 +370,7 @@ def test_authorize_token_flow(flask_client):
# r.location will have this form http://localhost?state=teststate&code=knuyjepwvg
o = urlparse(r.location)
assert o.netloc == ALLOWED_REDIRECT_DOMAINS[0]
assert o.netloc == domain
# in token flow, access_token is in fragment and not query
assert o.fragment
@ -359,6 +397,13 @@ def test_authorize_id_token_flow(flask_client):
client = Client.create_new("test client", user.id)
Session.commit()
domain = random_domain()
uri = f"https://{domain}/callback"
RedirectUri.create(
client_id=client.id,
uri=uri,
commit=True,
)
# user allows client on the authorization page
r = flask_client.post(
@ -366,7 +411,7 @@ def test_authorize_id_token_flow(flask_client):
"oauth.authorize",
client_id=client.oauth_client_id,
state="teststate",
redirect_uri=f"https://{ALLOWED_REDIRECT_DOMAINS[0]}",
redirect_uri=uri,
response_type="id_token", # id_token flow
),
data={"button": "allow", "suggested-email": "x@y.z", "suggested-name": "AB CD"},
@ -379,7 +424,7 @@ def test_authorize_id_token_flow(flask_client):
# r.location will have this form http://localhost?state=teststate&code=knuyjepwvg
o = urlparse(r.location)
assert o.netloc == ALLOWED_REDIRECT_DOMAINS[0]
assert o.netloc == domain
assert not o.fragment
assert o.query
@ -408,6 +453,13 @@ def test_authorize_token_id_token_flow(flask_client):
client = Client.create_new("test client", user.id)
Session.commit()
domain = random_domain()
uri = f"https://{domain}/callback"
RedirectUri.create(
client_id=client.id,
uri=uri,
commit=True,
)
# user allows client on the authorization page
r = flask_client.post(
@ -415,7 +467,7 @@ def test_authorize_token_id_token_flow(flask_client):
"oauth.authorize",
client_id=client.oauth_client_id,
state="teststate",
redirect_uri=f"https://{ALLOWED_REDIRECT_DOMAINS[0]}",
redirect_uri=uri,
response_type="id_token token", # id_token,token flow
),
data={"button": "allow", "suggested-email": "x@y.z", "suggested-name": "AB CD"},
@ -428,7 +480,7 @@ def test_authorize_token_id_token_flow(flask_client):
# r.location will have this form http://localhost?state=teststate&code=knuyjepwvg
o = urlparse(r.location)
assert o.netloc == ALLOWED_REDIRECT_DOMAINS[0]
assert o.netloc == domain
assert o.fragment
assert not o.query
@ -498,6 +550,13 @@ def test_authorize_code_id_token_flow(flask_client):
client = Client.create_new("test client", user.id)
Session.commit()
domain = random_domain()
uri = f"https://{domain}/callback"
RedirectUri.create(
client_id=client.id,
uri=uri,
commit=True,
)
# user allows client on the authorization page
r = flask_client.post(
@ -505,7 +564,7 @@ def test_authorize_code_id_token_flow(flask_client):
"oauth.authorize",
client_id=client.oauth_client_id,
state="teststate",
redirect_uri=f"https://{ALLOWED_REDIRECT_DOMAINS[0]}",
redirect_uri=uri,
response_type="id_token code", # id_token,code flow
),
data={"button": "allow", "suggested-email": "x@y.z", "suggested-name": "AB CD"},
@ -518,7 +577,7 @@ def test_authorize_code_id_token_flow(flask_client):
# r.location will have this form http://localhost?state=teststate&code=knuyjepwvg
o = urlparse(r.location)
assert o.netloc == ALLOWED_REDIRECT_DOMAINS[0]
assert o.netloc == domain
assert not o.fragment
assert o.query
@ -606,7 +665,7 @@ def test_authorize_code_id_token_flow(flask_client):
assert not r.json["scope"]
assert r.json["token_type"] == "Bearer"
client_user = ClientUser.first()
client_user = ClientUser.get_by(client_id=client.id)
assert r.json["user"] == {
"avatar_url": None,