simple-login/app
1
1
Fork 0
mirror of https://github.com/simple-login/app.git synced 2025-02-24 15:53:22 +08:00
Code Issues Projects Releases Packages Wiki Activity

handle case msg is string in replace() (#1271)

Browse source 
should fix https://sentry.io/organizations/simplelogin/issues/3563106404/?alert_rule_id=2478639&alert_timestamp=1662404226476&alert_type=email&environment=production&project=1868546&referrer=alert_email
This commit is contained in:
Son Nguyen Kim 2022-09-07 10:22:11 +02:00 committed by GitHub
parent f47661c3d2
commit 753a28e886
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/email_utils.py
View file

@ -994,7 +994,11 @@ def add_header(msg: Message, text_header, html_header=None) -> Message:
return msg
def replace(msg: Message, old, new) -> Message:
def replace(msg: Union[Message, str], old, new) -> Union[Message, str]:
if type(msg) is str:
msg = msg.replace(old, new)
return msg
content_type = msg.get_content_type()
if (

6
tests/test_email_utils.py
View file

@ -460,6 +460,12 @@ Content-Type: text/html; charset=us-ascii
assert "old" not in new_msg.as_string()
def test_replace_str():
msg = "a string"
new_msg = replace(msg, "a", "still a")
assert new_msg == "still a string"
def test_generate_reply_email(flask_client):
user = create_new_user()
reply_email = generate_reply_email("test@example.org", user)