From 8ba75befa877c29144a0ba21750619be1ae49ab0 Mon Sep 17 00:00:00 2001 From: Carlos Quintana <74399022+cquintana92@users.noreply.github.com> Date: Fri, 8 Nov 2024 15:16:09 +0100 Subject: [PATCH] fix: handle invalid page numbers (#2313) --- app/dashboard/views/alias_contact_manager.py | 5 ++++- app/dashboard/views/index.py | 5 ++++- app/dashboard/views/notification.py | 5 ++++- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/app/dashboard/views/alias_contact_manager.py b/app/dashboard/views/alias_contact_manager.py index 088442ad..501910be 100644 --- a/app/dashboard/views/alias_contact_manager.py +++ b/app/dashboard/views/alias_contact_manager.py @@ -227,7 +227,10 @@ def alias_contact_manager(alias_id): page = 0 if request.args.get("page"): - page = int(request.args.get("page")) + try: + page = int(request.args.get("page")) + except ValueError: + pass query = request.args.get("query") or "" diff --git a/app/dashboard/views/index.py b/app/dashboard/views/index.py index 26f2ab48..c9f24992 100644 --- a/app/dashboard/views/index.py +++ b/app/dashboard/views/index.py @@ -71,7 +71,10 @@ def index(): page = 0 if request.args.get("page"): - page = int(request.args.get("page")) + try: + page = int(request.args.get("page")) + except ValueError: + pass highlight_alias_id = None if request.args.get("highlight_alias_id"): diff --git a/app/dashboard/views/notification.py b/app/dashboard/views/notification.py index e22c8e2c..405747a3 100644 --- a/app/dashboard/views/notification.py +++ b/app/dashboard/views/notification.py @@ -43,7 +43,10 @@ def notification_route(notification_id): def notifications_route(): page = 0 if request.args.get("page"): - page = int(request.args.get("page")) + try: + page = int(request.args.get("page")) + except ValueError: + pass notifications = ( Notification.filter_by(user_id=current_user.id)