simple-login/app
1
1
Fork 0
mirror of https://github.com/simple-login/app.git synced 2025-02-26 08:43:43 +08:00
Code Issues Projects Releases Packages Wiki Activity

handle the case new_email can be None if user cancels change in the meantime

Browse source
This commit is contained in:
Son NK 2020-03-09 09:14:21 +01:00
parent 743170e983
commit aadda7cb0d
1 changed files with 18 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
app/dashboard/views/mailbox_detail.py
View file

@ -158,17 +158,25 @@ def mailbox_confirm_change_route():
r_id = int(s.unsign(mailbox_id))
except BadSignature:
flash("Invalid link", "error")
return redirect(url_for("dashboard.index"))
else:
mailbox = Mailbox.get(r_id)
mailbox.email = mailbox.new_email
mailbox.new_email = None
# mark mailbox as verified if the change request is sent from an unverified mailbox
mailbox.verified = True
db.session.commit()
# new_email can be None if user cancels change in the meantime
if mailbox and mailbox.new_email:
mailbox.email = mailbox.new_email
mailbox.new_email = None
# mark mailbox as verified if the change request is sent from an unverified mailbox
mailbox.verified = True
db.session.commit()
LOG.d("Mailbox change %s is verified", mailbox)
flash(f"The {mailbox.email} is updated", "success")
return redirect(
url_for("dashboard.mailbox_detail_route", mailbox_id=mailbox.id)
)
else:
flash("Invalid link", "error")
return redirect(url_for("dashboard.index"))
LOG.d("Mailbox change %s is verified", mailbox)
flash(f"The {mailbox.email} is updated", "success")
return redirect(
url_for("dashboard.mailbox_detail_route", mailbox_id=mailbox.id)
)