From 3f2d193bf67fb3fe014c75d9a19cd77dd23eb7ba Mon Sep 17 00:00:00 2001 From: the-djmaze <> Date: Tue, 27 Dec 2022 10:11:54 +0100 Subject: [PATCH] Resolve #799 due to wrong implementation of RFC 8474 --- .../v/0.0.0/app/libraries/MailSo/Mail/Message.php | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/snappymail/v/0.0.0/app/libraries/MailSo/Mail/Message.php b/snappymail/v/0.0.0/app/libraries/MailSo/Mail/Message.php index 2a565ef14..c5d1233fc 100644 --- a/snappymail/v/0.0.0/app/libraries/MailSo/Mail/Message.php +++ b/snappymail/v/0.0.0/app/libraries/MailSo/Mail/Message.php @@ -131,11 +131,12 @@ class Message implements \JsonSerializable $oFetchResponse->GetFetchValue(FetchType::INTERNALDATE) ); - $oMessage->sEmailId = $oFetchResponse->GetFetchValue(FetchType::EMAILID) -// ?: $oFetchResponse->GetFetchValue('X-GUID') - ?: $oFetchResponse->GetFetchValue('X-GM-MSGID'); - $oMessage->sThreadId = $oFetchResponse->GetFetchValue(FetchType::THREADID) - ?: $oFetchResponse->GetFetchValue('X-GM-THRID'); + // https://www.rfc-editor.org/rfc/rfc8474 + $aEmailId = $oFetchResponse->GetFetchValue(FetchType::EMAILID); + $oMessage->sEmailId = $aEmailId ? $aEmailId[0] : $oFetchResponse->GetFetchValue('X-GM-MSGID'); +// $oMessage->sEmailId = $oMessage->sEmailId ?: $oFetchResponse->GetFetchValue('X-GUID'); + $aThreadId = $oFetchResponse->GetFetchValue(FetchType::THREADID); + $oMessage->sThreadId = $aThreadId ? $aThreadId[0] : $oFetchResponse->GetFetchValue('X-GM-THRID'); $sCharset = $oBodyStructure ? Utils::NormalizeCharset($oBodyStructure->SearchCharset()) : '';