Remove knockout-transformations dependency

dev/Model/Email.js

@@ -185,7 +185,7 @@ class EmailModel {
 		const parsedResult = addressparser(line);
 		if (isNonEmptyArray(parsedResult)) {
 			return _.compact(
-				parsedResult.map((item) =>
+				_.map(parsedResult, (item) =>
 					item.address ? new EmailModel(item.address.replace(/^[<]+(.*)[>]+$/g, '$1'), item.name || '') : null
 				)
 			);

dev/Settings/Admin/Contacts.js

@@ -47,14 +47,16 @@ class ContactsAdminSettings {
 		this.contactsSupported = 0 < supportedTypes.length;
 
 		this.contactsTypes = ko.observableArray([]);
-		this.contactsTypesOptions = this.contactsTypes.map((value) => {
+		this.contactsTypesOptions = ko.computed(() =>
+			_.map(this.contactsTypes(), (value) => {
 				const disabled = -1 === inArray(value, supportedTypes);
 				return {
 					'id': value,
 					'name': getTypeName(value) + (disabled ? ' (' + i18n('HINTS/NOT_SUPPORTED') + ')' : ''),
 					'disabled': disabled
 				};
-		});
+			})
+		);
 
 		this.contactsTypes(types);
 		this.contactsType = ko.observable('');

dev/Settings/Admin/Packages.js

@@ -18,9 +18,15 @@ class PackagesAdminSettings {
 		this.packagesReal = PackageStore.packagesReal;
 		this.packagesMainUpdatable = PackageStore.packagesMainUpdatable;
 
-		this.packagesCurrent = this.packages.filter((item) => item && '' !== item.installed && !item.compare);
+		this.packagesCurrent = ko.computed(() =>
-		this.packagesAvailableForUpdate = this.packages.filter((item) => item && '' !== item.installed && !!item.compare);
+			_.filter(this.packages(), (item) => item && '' !== item.installed && !item.compare)
-		this.packagesAvailableForInstallation = this.packages.filter((item) => item && '' === item.installed);
+		);
+		this.packagesAvailableForUpdate = ko.computed(() =>
+			_.filter(this.packages(), (item) => item && '' !== item.installed && !!item.compare)
+		);
+		this.packagesAvailableForInstallation = ko.computed(() =>
+			_.filter(this.packages(), (item) => item && '' === item.installed)
+		);
 
 		this.visibility = ko.computed(() => (PackageStore.packages.loading() ? 'visible' : 'hidden'));
 	}

dev/Stores/Admin/Domain.js

@@ -1,10 +1,11 @@
+import _ from '_';
 import ko from 'ko';
 
 class DomainAdminStore {
 	constructor() {
 		this.domains = ko.observableArray([]);
 		this.domains.loading = ko.observable(false).extend({ 'throttle': 100 });
-		this.domainsWithoutAliases = this.domains.filter((item) => item && !item.alias);
+		this.domainsWithoutAliases = ko.computed(() => _.filter(this.domains(), (item) => item && !item.alias));
 	}
 }
 

dev/Stores/User/Pgp.js

@@ -18,8 +18,8 @@ class PgpUserStore {
 		this.openpgpkeys = ko.observableArray([]);
 		this.openpgpKeyring = null;
 
-		this.openpgpkeysPublic = this.openpgpkeys.filter((item) => !!(item && !item.isPrivate));
+		this.openpgpkeysPublic = ko.computed(() => _.filter(this.openpgpkeys(), (item) => !!(item && !item.isPrivate)));
-		this.openpgpkeysPrivate = this.openpgpkeys.filter((item) => !!(item && item.isPrivate));
+		this.openpgpkeysPrivate = ko.computed(() => _.filter(this.openpgpkeys(), (item) => !!(item && item.isPrivate)));
 	}
 
 	/**

dev/View/Popup/Compose.js

@@ -226,9 +226,9 @@ class ComposePopupView extends AbstractViewNext {
 		this.saving = ko.observable(false);
 		this.attachments = ko.observableArray([]);
 
-		this.attachmentsInProcess = this.attachments.filter((item) => item && !item.complete());
+		this.attachmentsInProcess = ko.computed(() => _.filter(this.attachments(), (item) => item && !item.complete()));
-		this.attachmentsInReady = this.attachments.filter((item) => item && item.complete());
+		this.attachmentsInReady = ko.computed(() => _.filter(this.attachments(), (item) => item && item.complete()));
-		this.attachmentsInError = this.attachments.filter((item) => item && '' !== item.error());
+		this.attachmentsInError = ko.computed(() => _.filter(this.attachments(), (item) => item && '' !== item.error()));
 
 		this.attachmentsCount = ko.computed(() => this.attachments().length);
 		this.attachmentsInErrorCount = ko.computed(() => this.attachmentsInError().length);

dev/View/Popup/Contacts.js

@@ -98,27 +98,25 @@ class ContactsPopupView extends AbstractViewNext {
 
 		this.viewSaveTrigger = ko.observable(SaveSettingsStep.Idle);
 
-		this.viewPropertiesNames = this.viewProperties.filter(
+		this.viewPropertiesNames = ko.computed(() =>
-			(property) => -1 < inArray(property.type(), [ContactPropertyType.FirstName, ContactPropertyType.LastName])
+			_.filter(
-		);
-
-		// this.viewPropertiesOther = this.viewProperties.filter(
-		// 	(property) => -1 < inArray(property.type(), [ContactPropertyType.Note])
-		// );
-
-		this.viewPropertiesOther = ko.computed(() => {
-			const list = _.filter(
 				this.viewProperties(),
-				(property) => -1 < inArray(property.type(), [ContactPropertyType.Nick])
+				(property) => -1 < inArray(property.type(), [ContactPropertyType.FirstName, ContactPropertyType.LastName])
+			)
+		);
+		this.viewPropertiesOther = ko.computed(() =>
+			_.filter(this.viewProperties(), (property) => -1 < inArray(property.type(), [ContactPropertyType.Nick]))
 		);
-			return _.sortBy(list, (property) => property.type());
-		});
 
-		this.viewPropertiesEmails = this.viewProperties.filter((property) => ContactPropertyType.Email === property.type());
+		this.viewPropertiesEmails = ko.computed(() =>
+			_.filter(this.viewProperties(), (property) => ContactPropertyType.Email === property.type())
+		);
 
-		this.viewPropertiesWeb = this.viewProperties.filter((property) => ContactPropertyType.Web === property.type());
+		this.viewPropertiesWeb = ko.computed(() =>
+			_.filter(this.viewProperties(), (property) => ContactPropertyType.Web === property.type())
+		);
 
-		this.viewHasNonEmptyRequaredProperties = ko.computed(() => {
+		this.viewHasNonEmptyRequiredProperties = ko.computed(() => {
 			const names = this.viewPropertiesNames(),
 				emails = this.viewPropertiesEmails(),
 				fFilter = (property) => '' !== trim(property.value());
@@ -126,47 +124,37 @@ class ContactsPopupView extends AbstractViewNext {
 			return !!(_.find(names, fFilter) || _.find(emails, fFilter));
 		});
 
-		this.viewPropertiesPhones = this.viewProperties.filter((property) => ContactPropertyType.Phone === property.type());
+		this.viewPropertiesPhones = ko.computed(() =>
-
+			_.filter(this.viewProperties(), (property) => ContactPropertyType.Phone === property.type())
-		this.viewPropertiesEmailsNonEmpty = this.viewPropertiesNames.filter((property) => '' !== trim(property.value()));
-
-		this.viewPropertiesEmailsEmptyAndOnFocused = this.viewPropertiesEmails.filter((property) => {
-			const foc = property.focused();
-			return '' === trim(property.value()) && !foc;
-		});
-
-		this.viewPropertiesPhonesEmptyAndOnFocused = this.viewPropertiesPhones.filter((property) => {
-			const foc = property.focused();
-			return '' === trim(property.value()) && !foc;
-		});
-
-		this.viewPropertiesWebEmptyAndOnFocused = this.viewPropertiesWeb.filter((property) => {
-			const foc = property.focused();
-			return '' === trim(property.value()) && !foc;
-		});
-
-		this.viewPropertiesOtherEmptyAndOnFocused = ko.computed(() =>
-			_.filter(this.viewPropertiesOther(), (property) => {
-				const foc = property.focused();
-				return '' === trim(property.value()) && !foc;
-			})
 		);
 
-		this.viewPropertiesEmailsEmptyAndOnFocused.subscribe((list) => {
+		this.viewPropertiesEmailsNonEmpty = ko.computed(() =>
-			fFastClearEmptyListHelper(list);
+			_.filter(this.viewPropertiesNames(), (property) => '' !== trim(property.value()))
-		});
+		);
 
-		this.viewPropertiesPhonesEmptyAndOnFocused.subscribe((list) => {
+		const propertyFocused = (property) => {
-			fFastClearEmptyListHelper(list);
+			const focused = property.focused();
-		});
+			return '' === trim(property.value()) && !focused;
+		};
 
-		this.viewPropertiesWebEmptyAndOnFocused.subscribe((list) => {
+		this.viewPropertiesEmailsEmptyAndOnFocused = ko.computed(() =>
-			fFastClearEmptyListHelper(list);
+			_.filter(this.viewPropertiesEmails(), propertyFocused)
-		});
+		);
 
-		this.viewPropertiesOtherEmptyAndOnFocused.subscribe((list) => {
+		this.viewPropertiesPhonesEmptyAndOnFocused = ko.computed(() =>
-			fFastClearEmptyListHelper(list);
+			_.filter(this.viewPropertiesPhones(), propertyFocused)
-		});
+		);
+
+		this.viewPropertiesWebEmptyAndOnFocused = ko.computed(() => _.filter(this.viewPropertiesWeb(), propertyFocused));
+
+		this.viewPropertiesOtherEmptyAndOnFocused = ko.computed(() =>
+			_.filter(this.viewPropertiesOther(), propertyFocused)
+		);
+
+		this.viewPropertiesEmailsEmptyAndOnFocused.subscribe(fFastClearEmptyListHelper);
+		this.viewPropertiesPhonesEmptyAndOnFocused.subscribe(fFastClearEmptyListHelper);
+		this.viewPropertiesWebEmptyAndOnFocused.subscribe(fFastClearEmptyListHelper);
+		this.viewPropertiesOtherEmptyAndOnFocused.subscribe(fFastClearEmptyListHelper);
 
 		this.viewSaving = ko.observable(false);
 
@@ -304,7 +292,7 @@ class ContactsPopupView extends AbstractViewNext {
 	}
 
 	@command((self) => {
-		const bV = self.viewHasNonEmptyRequaredProperties(),
+		const bV = self.viewHasNonEmptyRequiredProperties(),
 			bReadOnly = self.viewReadOnly();
 		return !self.viewSaving() && bV && !bReadOnly;
 	})

package.json

@@ -103,7 +103,6 @@
     "json3": "3.3.3",
     "knockout": "3.4.2",
     "knockout-sortable": "1.1.1",
-    "knockout-transformations": "2.1.0",
     "lozad": "1.9.0",
     "matchmedia-polyfill": "0.3.2",
     "moment": "2.24.0",

tasks/config.js

@@ -98,7 +98,6 @@ config.paths.js = {
 			'node_modules/underscore/underscore-min.js',
 			'node_modules/moment/min/moment.min.js',
 			'node_modules/knockout/build/output/knockout-latest.js',
-			'node_modules/knockout-transformations/dist/knockout-transformations.min.js',
 			'node_modules/knockout-sortable/build/knockout-sortable.min.js ',
 			'node_modules/matchmedia-polyfill/matchMedia.js',
 			'node_modules/matchmedia-polyfill/matchMedia.addListener.js',

yarn.lock

@@ -3884,10 +3884,6 @@ knockout-sortable@1.1.1:
   version "1.1.1"
   resolved "https://registry.yarnpkg.com/knockout-sortable/-/knockout-sortable-1.1.1.tgz#5375f02c61c30dcef4622f6e57e1bafa970d6a0e"
 
-knockout-transformations@2.1.0:
-  version "2.1.0"
-  resolved "https://registry.yarnpkg.com/knockout-transformations/-/knockout-transformations-2.1.0.tgz#c9a9148dbe1649dc00518eccea704379aadb0097"
-
 knockout@3.4.2:
   version "3.4.2"
   resolved "https://registry.yarnpkg.com/knockout/-/knockout-3.4.2.tgz#e87958de77ad1e936f7ce645bab8b5d7c456d937"