cidWithOutTags => cidWithoutTags and don't check foundedCIDs because isLinked is already set

This commit is contained in:
djmaze 2020-09-20 11:15:00 +02:00
parent 6d5317d969
commit 46198861bc
2 changed files with 7 additions and 7 deletions

View file

@ -186,7 +186,7 @@ class AttachmentModel extends AbstractModel {
this.isLinked = false;
this.isThumbnail = false;
this.cid = '';
this.cidWithOutTags = '';
this.cidWithoutTags = '';
this.contentLocation = '';
this.download = '';
this.folder = '';
@ -215,7 +215,10 @@ class AttachmentModel extends AbstractModel {
this.mimeType = ((json.MimeType || '').toLowerCase()).trim();
this.fileName = json.FileName.trim();
this.estimatedSize = pInt(json.EstimatedSize);
// if it is inline
this.isInline = !!json.IsInline;
// if inline image is linked with CID in html
// and 'src="cid:' or background-image:url(cid:)
this.isLinked = !!json.IsLinked;
this.isThumbnail = !!json.IsThumbnail;
this.cid = json.CID;
@ -228,7 +231,7 @@ class AttachmentModel extends AbstractModel {
this.framed = !!json.Framed;
this.friendlySize = friendlySize(this.estimatedSize);
this.cidWithOutTags = this.cid.replace(/^<+/, '').replace(/>+$/, '');
this.cidWithoutTags = this.cid.replace(/^<+/, '').replace(/>+$/, '');
this.fileNameExt = getFileExtension(this.fileName);
this.fileType = staticFileType(this.fileNameExt, this.mimeType);

View file

@ -9,15 +9,12 @@ export class AttachmentCollectionModel extends AbstractCollectionModel
* @param {?Array} json
* @returns {AttachmentCollectionModel}
*/
static reviveFromJson(items, foundedCIDs) {
static reviveFromJson(items) {
let result = new AttachmentCollectionModel;
items = this.getFromJSON(items, 'AttachmentCollection') || items;
Array.isArray(items) && items.forEach(attachment => {
attachment = AttachmentModel.newInstanceFromJson(attachment);
if (attachment) {
if (attachment.cidWithOutTags && foundedCIDs.includes(attachment.cidWithOutTags)) {
attachment.isLinked = true;
}
result.push(attachment);
}
});
@ -37,6 +34,6 @@ export class AttachmentCollectionModel extends AbstractCollectionModel
*/
findByCid(cid) {
cid = cid.replace(/^<+|>+$/, '');
return this.find(item => cid === item.cidWithOutTags);
return this.find(item => cid === item.cidWithoutTags);
}
}