the-djmaze/snappymail
1
1
Fork 0
mirror of https://github.com/the-djmaze/snappymail.git synced 2024-12-29 11:01:34 +08:00
Code Issues Projects Releases Packages Wiki Activity

Cleanup closeCommand & cancelCommand because both are defined for popups

Browse source
This commit is contained in:
djmaze 2021-07-16 09:11:10 +02:00
parent c46e190a3a
commit d69743cee5
5 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
dev/Knoin/AbstractViews.js
View file

@ -38,9 +38,6 @@ class AbstractView {
keyScope(this.sCurrentScope);
}
cancelCommand() {}
closeCommand() {}
querySelector(selectors) {
return this.viewModelDom.querySelector(selectors);
}
@ -68,7 +65,10 @@ export class AbstractViewPopup extends AbstractView
this.sDefaultScope = Scope[name];
}
}
/*
cancelCommand() {}
closeCommand() {}
*/
/**
* @returns {void}
*/
@ -76,7 +76,7 @@ export class AbstractViewPopup extends AbstractView
addEventListener('keydown', event => {
if (event && this.modalVisibility && this.modalVisibility()) {
if (!this.bDisabeCloseOnEsc && 'Escape' == event.key) {
this.cancelCommand && this.cancelCommand();
this.cancelCommand();
return false;
} else if ('Backspace' == event.key && !inFocus()) {
return false;

2
dev/View/Popup/AddOpenPgpKey.js
View file

@ -78,7 +78,7 @@ class AddOpenPgpKeyPopupView extends AbstractViewPopup {
return false;
}
this.cancelCommand && this.cancelCommand();
this.cancelCommand();
return true;
}

2
dev/View/Popup/Filter.js
View file

@ -54,7 +54,7 @@ class FilterPopupView extends AbstractViewPopup {
this.fTrueCallback && this.fTrueCallback(this.filter());
this.modalVisibility() && this.closeCommand && this.closeCommand();
this.modalVisibility() && this.closeCommand();
}
return true;

2
dev/View/Popup/NewOpenPgpKey.js
View file

@ -63,7 +63,7 @@ class NewOpenPgpKeyPopupView extends AbstractViewPopup {
openpgpKeyring.store();
rl.app.reloadOpenPgpKeys();
this.cancelCommand && this.cancelCommand();
this.cancelCommand();
}
})
.catch((e) => {

2
dev/View/Popup/Plugin.js
View file

@ -85,7 +85,7 @@ class PluginPopupView extends AbstractViewPopup {
if (!isPopupVisible(AskPopupView)) {
showScreenPopup(AskPopupView, [
i18n('POPUPS_ASK/DESC_WANT_CLOSE_THIS_WINDOW'),
() => this.modalVisibility() && this.cancelCommand && this.cancelCommand()
() => this.modalVisibility() && this.cancelCommand()
]);
}
}