the-djmaze/snappymail
1
1
Fork 0
mirror of https://github.com/the-djmaze/snappymail.git synced 2024-11-10 17:13:38 +08:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #1234 from SergeyMosin/text-nodes-in-squire-root

Browse source 
fix: unwrapped text nodes attached to squire._root
This commit is contained in:
the-djmaze 2023-08-28 11:02:16 +02:00 committed by GitHub
commit e9770e17f6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 32 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
vendors/squire/build/squire-raw.js vendored
View file

@ -1846,6 +1846,38 @@ function onKey(event) {
this._ensureBottomLine();
this.setSelection(range);
this._updatePath(range, true);
} else if (range.collapsed
&& range.startContainer === this._root
&& this._root.children.length > 0) {
// Under certain conditions, cursor/range can be positioned directly
// under this._root (not wrapped) and when this happens, an inline(TEXT)
// element is attached directly to this._root. There might be other
// issues, but squire.makeUnorderedList(), squire.makeOrderedList() and
// maybe other functions that call squire.modifyBlocks() do NOT work
// on inline(TEXT) nodes that are direct children of this._root.
// Therefor, we try to detect this case here and wrap the cursor/range
// before the text is inserted.
const nextElement = this._root.children[range.startOffset];
if (nextElement.tagName === blockTag
&& nextElement.children.length === 1
&& nextElement.children[0].tagName === 'BR') {
// this is a suitable '<div<br></div>' wrapper, move selection to here
range = createRange(nextElement, 0);
} else {
// create a new wrapper
range = createRange(this._root.insertBefore(
this.createDefaultBlock(), nextElement
), 0);
if (nextElement.tagName === 'BR') {
// delete it because a new <br> is created by createDefaultBlock()
this._root.removeChild(nextElement);
}
}
const restore = this._restoreSelection;
this.setSelection(range);
this._restoreSelection = restore;
}
}