From 1424036ccd0dd96a82574613c1e3807b6f642b52 Mon Sep 17 00:00:00 2001 From: johnnyjoy Date: Sun, 17 Nov 2024 22:04:49 +0800 Subject: [PATCH] chore: use for...of --- web/src/components/MemoActionMenu.tsx | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/web/src/components/MemoActionMenu.tsx b/web/src/components/MemoActionMenu.tsx index cf9ae874..14d3f7f8 100644 --- a/web/src/components/MemoActionMenu.tsx +++ b/web/src/components/MemoActionMenu.tsx @@ -120,22 +120,17 @@ const MemoActionMenu = (props: Props) => { const confirmed = window.confirm(t("memo.remove-completed-task-list-items-confirm")); if (confirmed) { const newNodes = JSON.parse(JSON.stringify(memo.nodes)); - for (let i = 0; i < newNodes.length; i++) { - if (newNodes[i].type === NodeType.LIST && newNodes[i].listNode?.children?.length > 0) { - let childrenLength = newNodes[i].listNode.children.length; - for (let j = 0; j < childrenLength; j++) { - if ( - newNodes[i].listNode.children[j].type === NodeType.TASK_LIST_ITEM && - newNodes[i].listNode.children[j].taskListItemNode?.complete - ) { + for (const node of newNodes) { + if (node.type === NodeType.LIST && node.listNode?.children?.length > 0) { + const children = node.listNode.children; + for (let i = 0; i < children.length; i++) { + if (children[i].type === NodeType.TASK_LIST_ITEM && children[i].taskListItemNode?.complete) { // Remove completed taskList item and next line breaks - newNodes[i].listNode.children.splice(j, 1); - if (newNodes[i].listNode.children[j]?.type === NodeType.LINE_BREAK) { - newNodes[i].listNode.children.splice(j, 1); - childrenLength--; + children.splice(i, 1); + if (children[i]?.type === NodeType.LINE_BREAK) { + children.splice(i, 1); } - childrenLength--; - j--; + i--; } } }