usememos/memos
1
1
Fork 0
mirror of https://github.com/usememos/memos.git synced 2025-10-09 22:06:53 +08:00
Code Issues Projects Releases Packages Wiki Activity

feat: return not found error instead internal error for local file not exist (#3543)

Browse source 
* chore: add `/.vscode` to `.gitignore`

* feat: return not found instead of internal for resource

* feat: check file not exist only if error not nil
This commit is contained in:
Ryo 2024-06-10 14:11:28 +08:00 • committed by GitHub
parent e4a09c407c
commit 2c819ace4e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
.gitignore vendored
View file

@ -23,3 +23,6 @@ bin/air
dev-dist dev-dist
dist dist
# VSCode settings
/.vscode

3
server/router/api/v1/resource_service.go
View file

@ -198,6 +198,9 @@ func (s *APIV1Service) GetResourceBinary(ctx context.Context, request *v1pb.GetR
file, err := os.Open(resourcePath) file, err := os.Open(resourcePath)
if err != nil { if err != nil {
if os.IsNotExist(err) {
return nil, status.Errorf(codes.NotFound, "file not found for resource: %s", request.Name)
}
return nil, status.Errorf(codes.Internal, "failed to open the file: %v", err) return nil, status.Errorf(codes.Internal, "failed to open the file: %v", err)
} }
defer file.Close() defer file.Close()