usememos/memos
1
1
Fork 0
mirror of https://github.com/usememos/memos.git synced 2025-12-17 14:19:17 +08:00
Code Issues Projects Releases Packages Wiki Activity

fix(store): correct PostgreSQL placeholder generation in IN clauses

Browse source 
Fixes a regression introduced in v0.25.2 where PostgreSQL IN clause
placeholders were not properly incremented, causing all parameters to
use the same placeholder index (e.g., $1, $1, $1 instead of $1, $2, $3).

This bug affected:
- ListReactions (ContentIDList) - caused "failed to list reactions" errors
- ListAttachments (MemoIDList)
- ListMemos (IDList and UIDList)

The fix combines placeholder generation and argument appending into a
single loop to ensure proper incrementing.

Fixes #5188

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Steven 2025-10-25 06:47:06 +08:00
parent 0c0d2a6294
commit 46ce0bc62e
3 changed files with 9 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
store/db/postgres/attachment.go
View file

@ -59,13 +59,11 @@ func (d *DB) ListAttachments(ctx context.Context, find *store.FindAttachment) ([
}
if len(find.MemoIDList) > 0 {
holders := make([]string, 0, len(find.MemoIDList))
for range find.MemoIDList {
holders = append(holders, placeholder(len(args)+1))
}
where = append(where, "resource.memo_id IN ("+strings.Join(holders, ", ")+")")
for _, id := range find.MemoIDList {
holders = append(holders, placeholder(len(args)+1))
args = append(args, id)
}
where = append(where, "resource.memo_id IN ("+strings.Join(holders, ", ")+")")
}
if find.HasRelatedMemo {
where = append(where, "resource.memo_id IS NOT NULL")

12
store/db/postgres/memo.go
View file

@ -53,26 +53,22 @@ func (d *DB) ListMemos(ctx context.Context, find *store.FindMemo) ([]*store.Memo
}
if len(find.IDList) > 0 {
holders := make([]string, 0, len(find.IDList))
for range find.IDList {
holders = append(holders, placeholder(len(args)+1))
}
where = append(where, "memo.id IN ("+strings.Join(holders, ", ")+")")
for _, id := range find.IDList {
holders = append(holders, placeholder(len(args)+1))
args = append(args, id)
}
where = append(where, "memo.id IN ("+strings.Join(holders, ", ")+")")
}
if v := find.UID; v != nil {
where, args = append(where, "memo.uid = "+placeholder(len(args)+1)), append(args, *v)
}
if len(find.UIDList) > 0 {
holders := make([]string, 0, len(find.UIDList))
for range find.UIDList {
holders = append(holders, placeholder(len(args)+1))
}
where = append(where, "memo.uid IN ("+strings.Join(holders, ", ")+")")
for _, uid := range find.UIDList {
holders = append(holders, placeholder(len(args)+1))
args = append(args, uid)
}
where = append(where, "memo.uid IN ("+strings.Join(holders, ", ")+")")
}
if v := find.CreatorID; v != nil {
where, args = append(where, "memo.creator_id = "+placeholder(len(args)+1)), append(args, *v)

10
store/db/postgres/reaction.go
View file

@ -36,15 +36,11 @@ func (d *DB) ListReactions(ctx context.Context, find *store.FindReaction) ([]*st
}
if len(find.ContentIDList) > 0 {
holders := make([]string, 0, len(find.ContentIDList))
for range find.ContentIDList {
for _, id := range find.ContentIDList {
holders = append(holders, placeholder(len(args)+1))
args = append(args, id)
}
if len(holders) > 0 {
where = append(where, "content_id IN ("+strings.Join(holders, ", ")+")")
for _, id := range find.ContentIDList {
args = append(args, id)
}
}
where = append(where, "content_id IN ("+strings.Join(holders, ", ")+")")
}
rows, err := d.db.QueryContext(ctx, `