usememos/memos
1
1
Fork 0
mirror of https://github.com/usememos/memos.git synced 2025-10-09 22:06:53 +08:00
Code Issues Projects Releases Packages Wiki Activity

feat: hiding dialog using X button should remove class "overflow-hidden" (#1555)

Browse source 
Hiding dialogs result in the body to stay frozen due to mounting behaviour of the dialog, but using 'X' button hides the dialog and won't let user scroll any further. Removing overflow behaviour during hiding procedure will improve User Experience.
This commit is contained in:
deeshu 2023-04-17 17:43:33 +05:30 • committed by GitHub
parent 2b83572641
commit e62a94c05a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
web/src/components/Dialog/BaseDialog.tsx
View file

@ -92,6 +92,7 @@ export function generateDialog<T extends DialogProps>(
hide: () => {
tempDiv.firstElementChild?.classList.remove("showup");
tempDiv.firstElementChild?.classList.add("showoff");
document.body.classList.remove("overflow-hidden");
},
};