warp-tech/warpgate
1
1
Fork 0
mirror of https://github.com/warp-tech/warpgate.git synced 2024-09-20 06:46:17 +08:00
Code Issues Packages Projects Releases Wiki Activity

fixed GHSA-c94j-vqr5-3mxr - privilege escalation during web auth

Browse source
This commit is contained in:
Eugene 2023-11-23 18:35:27 +01:00
parent 80ec7444f9
commit e3b26b2699
No known key found for this signature in database
GPG key ID: 5896FCBBDD1CF4F4
2 changed files with 13 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
warpgate-protocol-http/src/api/auth.rs
View file

@ -129,7 +129,7 @@ impl Api {
let password_cred = AuthCredential::Password(Secret::new(body.password.clone()));
if cp
.validate_credential(&body.username, &password_cred)
.validate_credential(&state.username(), &password_cred)
.await?
{
state.add_valid_credential(password_cred);

20
warpgate-protocol-http/src/common.rs
View file

@ -194,16 +194,20 @@ pub async fn get_auth_state_for_request(
}
}
match session.get_auth_state_id() {
Some(id) => Ok(store.get(&id.0).ok_or(WarpgateError::InconsistentState)?),
None => {
let (id, state) = store
.create(None, username, crate::common::PROTOCOL_NAME)
.await?;
session.set(AUTH_STATE_ID_SESSION_KEY, AuthStateId(id));
Ok(state)
if let Some(id) = session.get_auth_state_id() {
let state = store.get(&id.0).ok_or(WarpgateError::InconsistentState)?;
let existing_matched = state.lock().await.username() == username;
if existing_matched {
return Ok(state);
}
}
let (id, state) = store
.create(None, username, crate::common::PROTOCOL_NAME)
.await?;
session.set(AUTH_STATE_ID_SESSION_KEY, AuthStateId(id));
Ok(state)
}
pub async fn authorize_session(req: &Request, username: String) -> poem::Result<()> {